Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add infrastructure for consent banner and link #3191

Merged
merged 61 commits into from
May 13, 2023
Merged

Add infrastructure for consent banner and link #3191

merged 61 commits into from
May 13, 2023

Commits on May 8, 2023

  1. parent 9149f2f 

    author eastandwestwind <eastandwestwind@gmail.com> 1682459940 -0600
committer eastandwestwind <eastandwestwind@gmail.com> 1683584073 -0400

banner infra- note this does not yet work
    @eastandwestwind
    eastandwestwind committed May 8, 2023
    Configuration menu
    Copy the full SHA
    ee22baa View commit details
    Browse the repository at this point in the history

  2. fixing some conflicts from rebase

    @eastandwestwind
    eastandwestwind committed May 8, 2023
    Configuration menu
    Copy the full SHA
    06e46cb View commit details
    Browse the repository at this point in the history

  3. Refactor ConsentBannerButton into a Preact FunctionComponent function

    @NevilleS
    NevilleS committed May 8, 2023
    Configuration menu
    Copy the full SHA
    d4bef32 View commit details
    Browse the repository at this point in the history

  4. Move ConsentBannerButton to a new "components" folder

    @NevilleS
    NevilleS committed May 8, 2023
    Configuration menu
    Copy the full SHA
    7655725 View commit details
    Browse the repository at this point in the history

  5. adds duplicate banner demo page that allows for config to be injected… 

    … through window
    @eastandwestwind
    eastandwestwind committed May 8, 2023
    Configuration menu
    Copy the full SHA
    88e12ef View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. cypress tests are working for consent banner

    @eastandwestwind
    eastandwestwind committed May 9, 2023
    Configuration menu
    Copy the full SHA
    19ffcbd View commit details
    Browse the repository at this point in the history

  2. regenerate package-lock, add back turbo output cache

    @eastandwestwind
    eastandwestwind committed May 9, 2023
    Configuration menu
    Copy the full SHA
    69f672a View commit details
    Browse the repository at this point in the history

  3. fix eslint configs

    @eastandwestwind
    eastandwestwind committed May 9, 2023
    Configuration menu
    Copy the full SHA
    cfa8110 View commit details
    Browse the repository at this point in the history

  4. remove public/lib file, rename css vars

    @eastandwestwind
    eastandwestwind committed May 9, 2023
    Configuration menu
    Copy the full SHA
    92c7e85 View commit details
    Browse the repository at this point in the history

  5. restructure some components to functional, removes link component

    @eastandwestwind
    eastandwestwind committed May 9, 2023
    Configuration menu
    Copy the full SHA
    71ee51e View commit details
    Browse the repository at this point in the history

  6. inject accept/reject events from fides parent for the banner

    @eastandwestwind
    eastandwestwind committed May 9, 2023
    Configuration menu
    Copy the full SHA
    55eccc0 View commit details
    Browse the repository at this point in the history

  7. Add note about aliasing react imports

    @NevilleS
    NevilleS committed May 9, 2023
    Configuration menu
    Copy the full SHA
    bf59c50 View commit details
    Browse the repository at this point in the history

  8. Update tsconfig to include tsx

    @allisonking
    allisonking committed May 9, 2023
    Configuration menu
    Copy the full SHA
    39b1618 View commit details
    Browse the repository at this point in the history

  9. Swap href instead of using onClick for anchor component

    @allisonking
    allisonking committed May 9, 2023
    Configuration menu
    Copy the full SHA
    af0282e View commit details
    Browse the repository at this point in the history

  10. Export debugLog as a function instead of default

    @allisonking
    allisonking committed May 9, 2023
    Configuration menu
    Copy the full SHA
    e5723b5 View commit details
    Browse the repository at this point in the history

  11. clarify diff between banner demo pages

    @eastandwestwind
    eastandwestwind committed May 9, 2023
    Configuration menu
    Copy the full SHA
    a815fd2 View commit details
    Browse the repository at this point in the history

  12. Update clients/fides-js/src/lib/cookie.ts 

    Co-authored-by: Allison King <allison@ethyca.com>
    @eastandwestwind @allisonking
    eastandwestwind and allisonking committed May 9, 2023
    Configuration menu
    Copy the full SHA
    878e00c View commit details
    Browse the repository at this point in the history

  13. Fix accept all and reject all logic

    @allisonking
    allisonking committed May 9, 2023
    Configuration menu
    Copy the full SHA
    5f64996 View commit details
    Browse the repository at this point in the history

  14. Run prettier

    @allisonking
    allisonking committed May 9, 2023
    Configuration menu
    Copy the full SHA
    1acf4ae View commit details
    Browse the repository at this point in the history

  15. Run prettier on privacy center

    @allisonking
    allisonking committed May 9, 2023
    Configuration menu
    Copy the full SHA
    b6f8e26 View commit details
    Browse the repository at this point in the history

  16. Run prettier on PC README

    @allisonking
    allisonking committed May 9, 2023
    Configuration menu
    Copy the full SHA
    db0ce36 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. refactor to inject legacy consent, consent experience, geolocation, a… 

    …nd other options into Fides.init
    @eastandwestwind
    eastandwestwind committed May 10, 2023
    Configuration menu
    Copy the full SHA
    902ae80 View commit details
    Browse the repository at this point in the history

  2. banner props should default properly

    @eastandwestwind
    eastandwestwind committed May 10, 2023
    Configuration menu
    Copy the full SHA
    675eff9 View commit details
    Browse the repository at this point in the history

  3. move eslint config, update banner to support banner title

    @eastandwestwind
    eastandwestwind committed May 10, 2023
    Configuration menu
    Copy the full SHA
    9c26448 View commit details
    Browse the repository at this point in the history

  4. remove unneeded npm dev dependency in fides-js

    @eastandwestwind
    eastandwestwind committed May 10, 2023
    Configuration menu
    Copy the full SHA
    fe992d7 View commit details
    Browse the repository at this point in the history

  5. re-enable some eslint rules

    @eastandwestwind
    eastandwestwind committed May 10, 2023
    Configuration menu
    Copy the full SHA
    5ac8512 View commit details
    Browse the repository at this point in the history

  6. Get cypress to run again

    @allisonking
    allisonking committed May 10, 2023
    Configuration menu
    Copy the full SHA
    482b7ec View commit details
    Browse the repository at this point in the history

  7. Update cypress test to use win.fidesConfig

    @allisonking
    allisonking committed May 10, 2023
    Configuration menu
    Copy the full SHA
    1962cd4 View commit details
    Browse the repository at this point in the history

  8. Allow visitConsentDemo to hang out with its friends

    @allisonking
    allisonking committed May 10, 2023
    Configuration menu
    Copy the full SHA
    d33ffab View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into banner-infra

    @allisonking
    allisonking committed May 10, 2023
    Configuration menu
    Copy the full SHA
    333adaa View commit details
    Browse the repository at this point in the history

  10. Format

    @allisonking
    allisonking committed May 10, 2023
    Configuration menu
    Copy the full SHA
    83d2271 View commit details
    Browse the repository at this point in the history

  11. Update package-lock.json

    @allisonking
    allisonking committed May 10, 2023
    Configuration menu
    Copy the full SHA
    6cb4b2e View commit details
    Browse the repository at this point in the history

  12. remove unneeded tslint config

    @eastandwestwind
    eastandwestwind committed May 10, 2023
    Configuration menu
    Copy the full SHA
    fb407ed View commit details
    Browse the repository at this point in the history

  13. remove passing consent defaults into init, fix circular deps

    @eastandwestwind
    eastandwestwind committed May 10, 2023
    Configuration menu
    Copy the full SHA
    4e2866d View commit details
    Browse the repository at this point in the history

  14. Patch package-lock for turbo in different architectures

    @allisonking
    allisonking committed May 10, 2023
    Configuration menu
    Copy the full SHA
    d8f7377 View commit details
    Browse the repository at this point in the history

  15. Autoformat

    @allisonking
    allisonking committed May 10, 2023
    Configuration menu
    Copy the full SHA
    428b183 View commit details
    Browse the repository at this point in the history

  16. fix jest in fides-js

    @eastandwestwind
    eastandwestwind committed May 10, 2023
    Configuration menu
    Copy the full SHA
    f3755b2 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Only render ConsentBanner after mount

    @allisonking
    allisonking committed May 11, 2023
    Configuration menu
    Copy the full SHA
    21b7883 View commit details
    Browse the repository at this point in the history

  2. do not render banner by default

    @eastandwestwind
    eastandwestwind committed May 11, 2023
    Configuration menu
    Copy the full SHA
    5fd0574 View commit details
    Browse the repository at this point in the history

  3. config.options is required by package

    @eastandwestwind
    eastandwestwind committed May 11, 2023
    Configuration menu
    Copy the full SHA
    7be8b35 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Merge branch 'main' of github.com:ethyca/fides into banner-infra

    @eastandwestwind
    eastandwestwind committed May 12, 2023
    Configuration menu
    Copy the full SHA
    48d4a21 View commit details
    Browse the repository at this point in the history

  2. add to changelog

    @eastandwestwind
    eastandwestwind committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c9ca6da View commit details
    Browse the repository at this point in the history

  3. remove unneeded deps

    @eastandwestwind
    eastandwestwind committed May 12, 2023
    Configuration menu
    Copy the full SHA
    7fa2e94 View commit details
    Browse the repository at this point in the history

  4. remove unneeded todo, update privacy center readme

    @eastandwestwind
    eastandwestwind committed May 12, 2023
    Configuration menu
    Copy the full SHA
    f0cac32 View commit details
    Browse the repository at this point in the history

  5. rename isDisabled to isOverlayDisabled

    @eastandwestwind
    eastandwestwind committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d66c260 View commit details
    Browse the repository at this point in the history

  6. small renaming, refactor todos into callback func

    @eastandwestwind
    eastandwestwind committed May 12, 2023
    Configuration menu
    Copy the full SHA
    2bca847 View commit details
    Browse the repository at this point in the history

  7. Refactor consent.tsx to render App

    @allisonking @eastandwestwind
    allisonking authored and eastandwestwind committed May 12, 2023
    Configuration menu
    Copy the full SHA
    fc31dc4 View commit details
    Browse the repository at this point in the history

  8. cleanup after cherry-picking to add new App component

    @eastandwestwind
    eastandwestwind committed May 12, 2023
    Configuration menu
    Copy the full SHA
    409d3f3 View commit details
    Browse the repository at this point in the history

  9. prettier

    @eastandwestwind
    eastandwestwind committed May 12, 2023
    Configuration menu
    Copy the full SHA
    8d1627b View commit details
    Browse the repository at this point in the history

  10. add logic to prevent retrieving geolocation under certain conditions,… 

    … add geolocation constructor to be injested by fides API
    @eastandwestwind
    eastandwestwind committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d461a27 View commit details
    Browse the repository at this point in the history

  11. add check for DOM loaded before adding listener

    @eastandwestwind
    eastandwestwind committed May 12, 2023
    Configuration menu
    Copy the full SHA
    bd35fe9 View commit details
    Browse the repository at this point in the history

  12. Make the CHANGELOG entry more exciting!

    @NevilleS
    NevilleS committed May 12, 2023
    Configuration menu
    Copy the full SHA
    1b50997 View commit details
    Browse the repository at this point in the history

  13. Unbundle the FidesConfig and pass explicit props to initOverlay

    @NevilleS
    NevilleS committed May 12, 2023
    Configuration menu
    Copy the full SHA
    15160ee View commit details
    Browse the repository at this point in the history

  14. Rename App -> Overlay

    @NevilleS
    NevilleS committed May 12, 2023
    Configuration menu
    Copy the full SHA
    0f8769e View commit details
    Browse the repository at this point in the history

  15. Add a prop for manage preferences link label

    @NevilleS
    NevilleS committed May 12, 2023
    Configuration menu
    Copy the full SHA
    adfee4e View commit details
    Browse the repository at this point in the history

  16. Fix gitignore

    @NevilleS
    NevilleS committed May 12, 2023
    Configuration menu
    Copy the full SHA
    bfb7461 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2023

  1. Add tests for makeConsentDefaults

    @NevilleS
    NevilleS committed May 13, 2023
    Configuration menu
    Copy the full SHA
    077db9a View commit details
    Browse the repository at this point in the history

  2. Add tests for setConsentCookie

    @NevilleS
    NevilleS committed May 13, 2023
    Configuration menu
    Copy the full SHA
    bdf9ab5 View commit details
    Browse the repository at this point in the history

  3. Remove TODO

    @NevilleS
    NevilleS committed May 13, 2023
    Configuration menu
    Copy the full SHA
    6d06ab2 View commit details
    Browse the repository at this point in the history

  4. Format

    @NevilleS
    NevilleS committed May 13, 2023
    Configuration menu
    Copy the full SHA
    590c826 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:ethyca/fides into banner-infra

    @NevilleS
    NevilleS committed May 13, 2023
    Configuration menu
    Copy the full SHA
    6920461 View commit details
    Browse the repository at this point in the history