New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: puller rewrite and bug fixes #3437
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
c66214a
fix: bugs
istae 84b7a37
fix: bugs
istae 20cbcdf
fix: bugs
istae 6338679
chore: more bugs
istae e15ce06
fix: more bugs
istae bcc76d4
fix: puller rewrite
istae bd72ec0
fix: trigger fix
istae 488db7b
chore: comments
istae 8a75cc4
chore: lint
istae 987a878
chore: metrics
istae a03b64d
fix: prune gone peers
istae 32ac92a
fix: missing unlock
istae a95ab4f
fix: removed listen on quite
istae 740c436
fix: disconnect with swarm address
istae 081e428
fix: pullsync and puller sync process to continue (#3444)
istae ff7688f
revert: falling edge
istae a6a7ca9
fix: missing metric
istae 0f53bfc
fix: context
istae c3fb373
chore: tests
istae 239a691
fix: remove unncessary disconnect
istae 1061c6c
fix: timer
istae 6abf7a4
chore: retry sleep
istae a7fe7a9
chore: peer gone test
istae ae7a090
chore: puller sync sleep dur options
istae File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,6 @@ linters: | |
- importas | ||
- ineffassign | ||
- misspell | ||
- nakedret | ||
- nilerr | ||
- noctx | ||
- paralleltest | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no preference on naked vs not-naked returns, but could not see a strong enough need in this pr to change the linter configuration, and consequently the coding policy. The changes with naked returns have no functional requirement, while naked returns could be a source of a subtle problems.