Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go-ethereum #2342

Merged
merged 6 commits into from Jul 27, 2021
Merged

chore: update go-ethereum #2342

merged 6 commits into from Jul 27, 2021

Conversation

ralph-pichler
Copy link
Member

@ralph-pichler ralph-pichler commented Jul 16, 2021

This change is Reviewable

@ralph-pichler ralph-pichler force-pushed the go_eth_update branch 4 times, most recently from 984c844 to ac44bfe Compare July 22, 2021 14:27
@ralph-pichler ralph-pichler force-pushed the go_eth_update branch 3 times, most recently from 18b69b7 to 7e41f2e Compare July 27, 2021 06:00
@ralph-pichler ralph-pichler marked this pull request as ready for review July 27, 2021 07:07
@ralph-pichler ralph-pichler self-assigned this Jul 27, 2021
@ralph-pichler ralph-pichler added the ready for review The PR is ready to be reviewed label Jul 27, 2021
@ralph-pichler ralph-pichler requested a review from acud July 27, 2021 08:14
Copy link
Contributor

@mrekucci mrekucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 12 files at r1, 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @acud)


pkg/transaction/backendsimulation/backend.go, line 163 at r2 (raw file):

}

func (m *simulatedBackend) SuggestGasTipCap(ctx context.Context) (*big.Int, error) {

Since the ctx isn't used I'd suggest changing the name to _ in order to explicitly signal that.

Copy link
Member

@acud acud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 12 files at r1, 3 of 3 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ralph-pichler)


go.sum, line 794 at r2 (raw file):

github.com/mattn/go-runewidth v0.0.9 h1:Lm995f3rfxdpd6TSmuVCHVb/QhupuXlYr8sCI/QdE+0=
github.com/mattn/go-runewidth v0.0.9/go.mod h1:H031xJmbD/WCDINGzjvQ9THkh0rPKHF+m2gUSrubnMI=
github.com/mattn/go-sqlite3 v1.11.0/go.mod h1:FPy6KqzDD04eiIsT53CuJW3U88zkxoIYsOqkbpncsNc=

?? i wonder where is this coming from? did you go mod tidy?


pkg/statestore/leveldb/migration.go, line 138 at r2 (raw file):

			if err = s.Put(fixed, chequebookAddress); err != nil {
				return err
			}

what about s.Delete(key)?

Copy link
Member Author

@ralph-pichler ralph-pichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @acud)


go.sum, line 794 at r2 (raw file):

Previously, acud (acud) wrote…

?? i wonder where is this coming from? did you go mod tidy?

yes. both go-ethereum and go-ens have this in their go.sum also, so probably one of their dependencies introduced this.


pkg/statestore/leveldb/migration.go, line 138 at r2 (raw file):

Previously, acud (acud) wrote…

what about s.Delete(key)?

added


pkg/transaction/backendsimulation/backend.go, line 163 at r2 (raw file):

Previously, mrekucci wrote…

Since the ctx isn't used I'd suggest changing the name to _ in order to explicitly signal that.

deleted as it was no longer needed after downgrade

@mrekucci mrekucci requested a review from acud July 27, 2021 12:01
Copy link
Member

@acud acud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 12 files at r1, 4 of 4 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ralph-pichler)

@ralph-pichler ralph-pichler merged commit d27e04e into master Jul 27, 2021
@ralph-pichler ralph-pichler deleted the go_eth_update branch July 27, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants