Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WebSocketLike to accept null types #2843

Closed
wants to merge 1 commit into from
Closed

Update WebSocketLike to accept null types #2843

wants to merge 1 commit into from

Commits on Mar 25, 2022

  1. Update WebSocketLike to accept null types 

    This is to make the interface compatible with the popular npm package "reconnecting-websocket": https://github.com/pladaria/reconnecting-websocket/blob/05a2f7cb0e31f15dff5ff35ad53d07b1bec5e197/reconnecting-websocket.ts#L196-L212

This change makes sense for general purposes, because the callbacks are initially expected to be null before user assigns it manually.
    @ranmocy
    ranmocy committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    38a9501 View commit details
    Browse the repository at this point in the history