Grayglacier HF Support (master) #1983
Conversation
ScottyPoi
added
PR state: WIP
prio: +urgent
type: enhancement
package: block
package: vm
package: common
target: master (v7)
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
The latest I don't know how to address this |
| { | ||
| "name": "grayGlacier", | ||
| "block": 15050000, | ||
| "forkHash": null |
There was a problem hiding this comment.
Please calculate an explicit forkHash here, you can do this with the respective method in the Common library. If you would get some confirmation that the forkHash is correct - e.g. by looking at other client implementation GrayGlacier HF PRs - that would also be good.
There was a problem hiding this comment.
Ok. the grayGlacier markdown file had forkHash: TBA -- i'll check with other clients
| @@ -21,6 +21,7 @@ export enum Hardfork { | |||
| Berlin = 'berlin', | |||
| London = 'london', | |||
| ArrowGlacier = 'arrowGlacier', | |||
| GrayGlacier = 'grayGlacier', | |||
There was a problem hiding this comment.
Unrelated, but since you are already working on the code: can you please move Shanghai to the last position here? This is some relic from times where people thought Shanghai would happen before the Merge. 😋
(general note: please do all change requests on both PRs, maybe do all in one commit and then cherry-pick over?)
| @@ -37,6 +37,9 @@ const hardforkTestData: TestData = { | |||
| arrowGlacier: | |||
| require('../../ethereum-tests/DifficultyTests/dfArrowGlacier/difficultyArrowGlacier.json') | |||
| .difficultyArrowGlacier.ArrowGlacier, | |||
| grayGlacier: | |||
| require('../../ethereum-tests/DifficultyTests/dfGrayGlacier/difficultyGrayGlacier.json') | |||
| .difficultyGrayGlacier.GrayGlacier, | |||
There was a problem hiding this comment.
So to your question with the tests: just copy the whole file over and move to the local Block test data folder and reference through the local path. You can maybe add a TODO here that this should be replaced with the ethereum-tests folder again at some point.
Adds support for GrayGlacier HF re: #1960
Duplicated for v5-maintenance in #1984