Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Join to template, adding python 3.12 support #3363

Merged
merged 225 commits into from May 2, 2024
Merged

Join to template, adding python 3.12 support #3363

merged 225 commits into from May 2, 2024

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Apr 24, 2024 •
edited

Bringing the joy and wonder of the python project template to web3! (finally)

Main change is adding python 3.12 testing.
Otherwise, most updates are structural to bring things in line with the template.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

image

@carver
init
a7955a5
@carver
Replace all template vars
3d87ff7
@carver
skip replacing variables inside .git/* files
cdba56a
@carver
create empty module with supplied name
9cdfd64
@carver
shorten extra name for documentation install
4a8b7b0
@carver
start at devnum 0 so the first bump goes to 1
ca670f4
@carver
add docs index
1d4e19d
@carver
add github templates for issues and pull requests
3290919
@carver
Link to dev tactical manual
2938497
@carver
add make lint-roll to locally auto de-lint
76bfefa
@carver
docs cleanup: Makefile, conf, warnings
195249c
@carver
requirements.txt: best way to build on readthedocs
109a086
@carver
bugfix: run tox -elint *after* isort
96a3717 
otherwise tox fails, and the auto-lint never runs
@carver
when do you not want ipython in local dev? never
0e57d8e
@carver
pytest default settings, plus pytest-watch
9a7d72a
@carver
add circle ci config
cb71fb4
@carver
fixups: rm template filler, xfail strict, make bug
f7b0f07
@carver
add badges: pypi version and pythons supported
4bb4f72
@carver
docs: show badge, link to release notes
b825c36
@carver
add pypy3 as a supported environment, by default
7bfa2ac
@carver
add module import test
6abf066
@carver
bugfix: setuptools reference to pypy
1695a3b
@carver
silence flake8 error during module import test
beb1b10
@carver
add doctest by default
a9d9fec
@carver
every tox environment should have a basic python
a1ba89e
@carver
squash warning about using make inside tox
37d978c
@carver
can't override python that way in tox
ecb3731
@carver
add doctest run to travis
60b026e
@carver
add doctest run to circle-ci
5890203
@carver
tox.ini bugfix: whitelist make
b3461e9
@pacrob pacrob changed the title Join to template Join to template, adding python 3.12 support Apr 25, 2024
@pacrob pacrob marked this pull request as ready for review April 26, 2024 16:39
reedsa
reedsa approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ran tests, build and docs successfully. Thanks! 🚢

kclowes
kclowes reviewed Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be so nice to get in! I left a few comments, but nothing major.

.readthedocs.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.project-template/template_vars.txt Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
tox.ini Outdated
deps=
wheel
build[virtualenv]
allowlist_externals=
bash.exe
commands=
bash.exe {toxinidir}/web3/scripts/release/test_windows_wheel_install.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should stay. See: #3046

tox.ini Show resolved Hide resolved
@pacrob pacrob requested a review from kclowes April 30, 2024 16:46
@pacrob pacrob force-pushed the join-to-template branch 2 times, most recently from 8297405 to 346ad3b Compare April 30, 2024 19:46
@pacrob pacrob removed the request for review from kclowes April 30, 2024 19:46
@pacrob pacrob force-pushed the join-to-template branch 5 times, most recently from 6edb68d to 6f3a5d6 Compare April 30, 2024 21:52
@pacrob pacrob requested a review from kclowes April 30, 2024 22:00
kclowes
kclowes approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I just left one small comment.

setup.py Outdated Show resolved Hide resolved
@pacrob pacrob merged commit b57cfb6 into ethereum:main May 2, 2024
71 checks passed
@pacrob pacrob deleted the join-to-template branch May 2, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reedsa reedsa reedsa approved these changes

@kclowes kclowes kclowes approved these changes

@fselmo fselmo Awaiting requested review from fselmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet