Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geth): Add debug_traceTransaction RPC method to Geth module #3334

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

wangereth
Copy link

What was wrong?

Related to Issue #3330

How was it fixed?

  1. Add debug module in geth.
  2. Implement debug_traceTransaction RPC Method first

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

@kclowes
Copy link
Collaborator

kclowes commented Apr 5, 2024

Thanks! This looks like the right approach. Let me know when this is ready for review!

@wangereth
Copy link
Author

Thanks! This looks like the right approach. Let me know when this is ready for review!

Hello, I implemented debug_traceTransaction with callTracer config, and tested it myself. Maybe you can help me review it now to check if is it ok.

@kclowes
Copy link
Collaborator

kclowes commented Apr 11, 2024

This looks good so far! Do you mind adding some tests? We'll probably want to add a new file to web3/_utils/module_testing, and then the new class will need to be added to the integration tests in tests/integration/go_ethereum/test_go_ethereum_*.py. Let me know if you need an example or if you don't have time and/or don't want to and I can take it from here. Thanks!

@wangereth
Copy link
Author

Sure, I will try to add test, I will ask you for help if there is any questions.

@wangereth
Copy link
Author

@kclowes I have add some tests, please help review if it's ok.

@wangereth
Copy link
Author

wangereth commented May 13, 2024

hi, @kclowes , I have no idea why the py312-core check failed, please have a look.
image
I don't think I have changed code related to the failed test.

@wangereth
Copy link
Author

wangereth commented May 13, 2024

pytest tests/core/caching-utils/test_generate_cache_key.py --hypothesis-seed=243990134122841475368898544757628869001 will fail, but with any other seed it will success.

@wangereth
Copy link
Author

wangereth commented May 13, 2024

image

@kclowes
Copy link
Collaborator

kclowes commented May 13, 2024

We're failing on main too, so it's not anything in here. I'm planning to take a look at this PR this week. Thanks for the patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants