#1002 Handle error when interacting with a bad contract

[MRLab12]

What was wrong?

When a contract error happens during a call, usually we let the eth-abi exception raise through. This makes users think that web3.py is broken.

Related to Issue #1002

How was it fixed?

A ContractLogicError is now raised in call_contract_function when a contract has no code.

Todo:

• Add entry to the release notes

[MRLab12]

Created this draft PR to initiate a conversation on this fix.

I was able to reproduce the error when connecting to a Base Sepolia test wallet and setting up an invalid contract address. In order to not have the test actually connect to the network, I have mocked the functionalities.

This is my first contribution to this repo so any suggestions on contributing and code reviewing are welcome!

[MRLab12]

The test_call_undeployed_contract was failing and I noticed this was returning the eth_abi.exceptions.InsufficientDataBytes and web3.exceptions.BadFunctionCallOutput errors, so maybe we just keep this one instead of the one I added.

[kclowes]

@MRLab12 Thanks for the PR! I haven't had a chance to look at this yet, but I hope to be able to check it out in the next few days.