Add basic support of batch requests to AsyncHTTPProvider
#3102
+38
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Built-in types are not generics
|
@fselmo looks like useful stuff at least for beginning, could you review please? |
|
I need this 👀 |
|
I've been taking a look here recently and, though this will require some non-trivial refactoring to the code base, it seems like it's not too far off the table for a |
|
This was cherry-picked in #3370 and merged. Thanks for getting it going @dmkulazhenko ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue #832
This PR contains basic/limited support of batch requests for
AsyncHTTPProvider.Problem with batch requests is living there for years... and to be honest, there is a lot of things to do to add support of batch requests 😢. With this PR I just want to add stuff that is critical for me... and praying that it will motivate someone to finally resolve #832.
Cute Animal Picture