Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require modules to inherit from the Module class #2304

Merged
merged 2 commits into from Jan 18, 2022
Merged

Don't require modules to inherit from the Module class #2304

merged 2 commits into from Jan 18, 2022

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Jan 14, 2022 •
edited by wolovim

What was wrong?

  • All attached modules needed to inherit from the web3.module.Module class

Related to Issues #2231, #2288

How was it fixed?

  • Remove requirement for all modules to inherit from the Module class

Todo:

  • Add entry to the release notes
  • Add a cute animal picture
  • @marcgarreau, take a look at the doc descriptions / changes around modules in general. I added a bit to try to make more clear what modules are but I think this could use some love. Maybe in a separate PR, but if you have suggestions feel free to comment here or push commits to this PR.

Cute Animal Picture

20220113_091916

@fselmo fselmo force-pushed the modules-need-not-inherit-from-module-class branch 2 times, most recently from e86058a to daef8ea Compare January 17, 2022 17:13
@fselmo fselmo marked this pull request as ready for review January 17, 2022 17:15
@fselmo fselmo changed the title [WIP] Don't require modules to inherit from the Module class Don't require modules to inherit from the Module class Jan 17, 2022
@fselmo fselmo force-pushed the modules-need-not-inherit-from-module-class branch from daef8ea to 124d119 Compare January 17, 2022 17:25
wolovim
wolovim approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@wolovim wolovim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fselmo fselmo merged commit fee4f4c into ethereum:master Jan 18, 2022
@fselmo fselmo deleted the modules-need-not-inherit-from-module-class branch January 18, 2022 21:52
@wolovim wolovim mentioned this pull request Jan 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolovim wolovim wolovim approved these changes

@kclowes kclowes Awaiting requested review from kclowes

@pacrob pacrob Awaiting requested review from pacrob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fselmo @wolovim