Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode block_count as hex in eth_feeHistory RPC #2117

Merged
merged 2 commits into from Aug 30, 2021

Conversation

shuklaayush
Copy link
Contributor

@shuklaayush shuklaayush commented Aug 25, 2021

What was wrong?

eth_feeHistory RPC call was sending block_count as a raw integer instead of hex. This broke hardhat since it expects QUANTITIES (integers etc.) to be hex-encoded

How was it fixed?

Modified eth_feeHistory formatter to encode block_count as hex before making the RPC call

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@shuklaayush
Copy link
Contributor Author

shuklaayush commented Aug 25, 2021

Looks like the CI uses Geth 1.10.6 which doesn't support block count as hex. This was fixed in the 1.10.7 release (relevant PR). I guess we'll have to wait till this py-geth PR gets merged.

@fselmo
Copy link
Collaborator

fselmo commented Aug 25, 2021

I guess we'll have to wait till this py-geth PR gets merged.

Thanks for this. We'll try to get this py-geth version bump in asap. I'd recommend writing a test for this as well or I can add one here later. [On second thought I think the ones we have will do.]

Also, please note that geth version 1.10.8 is the one to use post-London since it includes a hotfix for a security vulnerability. Any other version post-London is susceptible to this vulnerability. Figured I'd reiterate this here; couldn't hurt.

@fselmo
Copy link
Collaborator

fselmo commented Aug 30, 2021

@shuklaayush merged! Thanks again for jumping on this before the py-geth PR was even merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants