[wip] Filter testing architecture #1645
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
"Testing event filters sucks." - @pipermerriam, issue #1635
How was it fixed?
Pulled in large chunks of cthaeh to load logs into an in-memory sqlite db and retrieve them when methods like
getLogs
are called.test_filters_using_db.py
contains some new tests which leverage all that new business.Note sure at what point this is merge-ready, so getting this up to start the discussion. Feedback of all sizes welcome.
Todo:
Cute Animal Picture