Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Filter testing architecture #1645

Closed
wants to merge 7 commits into from

Conversation

wolovim
Copy link
Member

@wolovim wolovim commented May 8, 2020

What was wrong?

"Testing event filters sucks." - @pipermerriam, issue #1635

How was it fixed?

Pulled in large chunks of cthaeh to load logs into an in-memory sqlite db and retrieve them when methods like getLogs are called. test_filters_using_db.py contains some new tests which leverage all that new business.

Note sure at what point this is merge-ready, so getting this up to start the discussion. Feedback of all sizes welcome.

Todo:

Cute Animal Picture

@wolovim wolovim changed the title Filter testing architecture [wip] Filter testing architecture May 8, 2020
@wolovim wolovim force-pushed the filter-testing-architecture branch from 800bf30 to 50fb622 Compare May 13, 2020 16:06
@wolovim wolovim force-pushed the filter-testing-architecture branch from 50fb622 to d0d8e4e Compare May 13, 2020 16:08
@pipermerriam
Copy link
Member

I believe I'm at a point with the database models that I've created in cthaeh to pull them out and release them as a standalone package. I don't think I'll get to it today but I think I can have it done by next week.

@wolovim wolovim force-pushed the filter-testing-architecture branch from d0d8e4e to ba1fbfb Compare May 13, 2020 17:54
@wolovim
Copy link
Member Author

wolovim commented May 13, 2020

@pipermerriam 👍 finally resolved the lint-pocalypse, so this will sit on the shelf until then.

@pacrob
Copy link
Contributor

pacrob commented May 20, 2024

stale!

@pacrob pacrob closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants