[DOCS] Change code block into proper JSON #11591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reran `solc --storage-layout`, so the AST ids changed.
hrkrshnn
commented
Jun 28, 2021
| @@ -240,66 +240,66 @@ value and reference types, types that are encoded packed, and nested types. | |||
|
|
|||
| .. code:: json | |||
|
|
|||
| "storageLayout": { | |||
There was a problem hiding this comment.
The issue was that this wasn't well-defined JSON.
This is the output of solc --storage-layout of the above code. It doesn't have "storageLayout" key, so, skipping it.
cameel
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
Well, it's still not proper JSON (the outer EDIT: Oh, sorry it does have the outer {} is missing) but if Sphinx accepts that then it's fine.{}.
BTW I checked if #11477 was rebased on top of it last time I reviewed it to avoid this. Weird that it still managed to break develop.
|
Ah, we did have problems with running CI in #11477. So the problem was there, just not noticed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reran
solc --storage-layout, so the AST ids changed.