Support Current Random in StateTests with T8N Tool Changes #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winsvega
reviewed
Jan 8, 2022
| @@ -116,8 +116,8 @@ void verify1559Parent(spBlockHeader const& _header, spBlockHeader const& _parent | |||
| void verifyCommonBlock(spBlockHeader const& _header, ToolChain const& _chain) | |||
| { | |||
| BlockHeader const& header = _header.getCContent(); | |||
| if (header.difficulty() < dev::bigint("0x20000")) | |||
There was a problem hiding this comment.
This verify 1559 parent. Need an analog for POS parent
|
implemented. we need now t8n tool to export evm in merge mode so we can strart generating the tests for PoS forks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires ethereum/go-ethereum#24141.
Adds support for currentRandom field on the env.json for the t8ntool, which mimics post-PoS merge RANDOM opcode functionality.
Still a draft, and does not fully work yet.