simulators/ethereum/engine: struct inputs and TransitionConfigurationV1 tests #559
Conversation
MarcusWentz
changed the title
| // TransitionConfigurationV1 | ||
| type ExchangeTransitionConfigurationResponseExpectObject struct { |
There was a problem hiding this comment.
This type of name is pretty common in the Java world, but in go-lang, people usually tend to use shorter names. Also, the docstring is wrong -- it should always begin with the name of the struct it is describing.
Could you please write a brief description of what this struct is/does, and then maybe we can make the name a bit briefer.
There was a problem hiding this comment.
Shortened name and routine docstring updated below.
| } | ||
| } | ||
|
|
||
| type ExchangeTransitionConfigurationBytesResponseExpectObject struct { |
There was a problem hiding this comment.
I don't understand the need for these types of objects.. ?
There was a problem hiding this comment.
The original struct was not compatible with the modified bytes version.
The original struct was not used for any tests, so I have removed the original version but kept the bytes version below.
| @@ -230,6 +248,34 @@ func (exp *GetPayloadResponseExpectObject) ExpectTimestamp(expectedTimestamp uin | |||
| } | |||
| } | |||
|
|
|||
| // ExchangeTransitionConfigurationV1 in bytes format. | |||
| type ExTransConfigResponseExpectObject struct { | |||
| *TestEnv | |||
There was a problem hiding this comment.
Docstring corrected and routine name abbreviated.
Rewriting types as bytes in this context allows test size inputs beyond the original struct data types.
|
Closing PR since Geth patch added for logsBloom ethereum/go-ethereum#24946 |
Testing inputs for Engine API struct parameters (including TransitionConfigurationV1):
-prefix (0x00)
-long
-short
TransitionConfigurationV1 tests check to see if CL == EL for parameters:
-TTD
-TerminalBlockNumber
-TerminalBlockHash
Note: cannot directly test Uint64/BigInt parameters due to marshaling restriction.
Could possibly be tested with building raw packets/RLP but also should be covered by Engine API Fuzz tests.