Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulators/ethereum/engine: Increase engine timeouts #1075

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spencer-tb
Copy link
Contributor

A simple PR to increase engine timeout values.

Some tests on the hive cancun public interface occasionally fail with the context deadline exceeded error. That is they pass most of the time but on occasion fail with this error.

  1. For the engine-cancun tests we have the following case that occurs waiting for an FCU response. The proposed solution is to increase the RPC timeout from 10 seconds to 20.
  2. For the pyspec tests we have this case where we timeout waiting for the engine client to start. I have seen this occur randomly across most clients. The proposed solution is to increase the engine live check timeout from 5 seconds to 10.

Unfortunately these cases can't be reproduced locally as they are for tests that always pass when running locally.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Just btw, it could be that the context timeout (for the total max time of the test runtime) happens right when we are requesting from the client's RPC, so it might be that it's not that the specific request is taking too much to process, but that the test has already taken too long to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants