core/vm: add subgroup checks for mul/mulexp for G1/G2 #29637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
requested review from
karalabe,
holiman and
rjl493456442
as code owners
holiman
reviewed
Apr 24, 2024
holiman
reviewed
Apr 24, 2024
| @@ -787,6 +792,11 @@ func (c *bls12381G1MultiExp) Run(input []byte) ([]byte, error) { | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| // 'point is on curve' check already done, | |||
| // Here we need to apply subgroup checks. | |||
| if !p.IsInSubGroup() { | |||
There was a problem hiding this comment.
Generally, this seems un-optimal to me (all these cases). We perform both these calls, with IsOnCurve done from inside decodePointGX.
// IsOnCurve returns true if p in on the curve
func (p *G1Affine) IsOnCurve() bool {
var point G1Jac
point.FromAffine(p)
return point.IsOnCurve() // call this function to handle infinity point
}
// IsInSubGroup returns true if p is in the correct subgroup, false otherwise
func (p *G1Affine) IsInSubGroup() bool {
var _p G1Jac
_p.FromAffine(p)
return _p.IsInSubGroup()
}Seems like it should be faster to do
func (p *G1Affine) IsOnCurveAndInSubGroup() bool {
var point G1Jac
point.FromAffine(p)
point.IsOnCurve() && point.IsInSubGroup()
}?
There was a problem hiding this comment.
Maybe (probably?) it doesn't make any difference
There was a problem hiding this comment.
It makes very little difference I think. The subgroup check is the heaviest, moving from affine to jac is very quick and the curve checks are very quick as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the subgroup checks as required by the current spec: https://github.com/ethereum/EIPs/pull/8456/files