Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/tracers/native: fix flatCallTracer Stop() bug #29623

Merged
merged 5 commits into from Apr 30, 2024

Conversation

draganm
Copy link
Contributor

@draganm draganm commented Apr 23, 2024

Fix for #29622:

Store reason when Stop is called in the flatCallTracer. This will be returned when GetResult() is called.

@draganm draganm requested a review from s1na as a code owner April 23, 2024 09:20
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goot catch. Pushed some changes to fix the interrupt signal. LGTM

@s1na
Copy link
Contributor

s1na commented Apr 25, 2024

Jotting down result of discussion: we can avoid all the if interrupt.Load() checks if we instead clear the function pointers on Stop. Note this would apply to all other tracers too. This is because EVM already checks for hook != nil and will not invoke those methods.

@fjl fjl merged commit 7c7e3a7 into ethereum:master Apr 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants