p2p/discover: fix bug in checkNodesEqual
#29603
Conversation
| } else { | ||
| return fmt.Errorf("length dismatch: got %d nodes, want %d nodes", len(got), len(want)) |
There was a problem hiding this comment.
Alternative fix: just move the return nil up one line, into the if-clause. Then the non-equal case would just fall through to the code below
There was a problem hiding this comment.
@holiman Thanks for reviewing. What you suggest seems more elegant :)
But what more important is that test case TestUDPv5_lookupE2E is defective, UDPv5.Lookup actually could not find all expected nodes. So if we merge this bugfix, this test case will never pass.
There was a problem hiding this comment.
Awesome, well done then finding a bug in the testcase!
There was a problem hiding this comment.
@holiman I try to fix TestUDPv5_lookupE2E, but it seem hard for me now :)
Maybe you guys could fix it, then this PR could get merged.
|
Yeah, the test doesn't pass and I need to investigate. |
No description provided.