accounts, cmd/geth, core: close opened files #29598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songzhibin97
requested review from
karalabe,
holiman and
rjl493456442
as code owners
holiman
requested changes
Apr 23, 2024
| if unl, found := ks.unlocked[addr]; found { | ||
| ks.mu.Unlock() |
There was a problem hiding this comment.
This changes the semantics. Previously, it released the lock before invoking ks.expire, but with your changes it retains the lock during the call.
Ostensibly, this was coded like it is for a reason. Please motivate why you consider this change safe/needed
There was a problem hiding this comment.
If you just want to remove some code, but retain the semantics, you could do
ks.mu.Lock()
unl, found := ks.unlocked[addr]
ks.mu.Unlock()
if found{
ks.expire(addr, unl, time.Duration(0)*time.Nanosecond)
}
return nil
cmd/utils/history_test.go
Outdated
| @@ -113,6 +113,7 @@ func TestHistoryImportAndExport(t *testing.T) { | |||
| if err != nil { | |||
| t.Fatalf("error opening era file: %v", err) | |||
| } | |||
| defer f.Close() | |||
There was a problem hiding this comment.
This is a bit non-obvious,but era.From takes an io.ReadSeekCloser, and era.Close closes the f. So this change would make it a double-close
|
Please make a habit of always writing PR descriptions |
holiman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.