Use DiscoveryV5 as a source of peers #29533
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fjl Should we start using discv5 for full nodes? AFAIK we're not currently using it at all anywhere |
|
Yes we could. But if it's enabled like in this PR, there wont be any filtering. There is currently a circular dependency in the stack where the discovery instance is not available until the client was started, but we'd need to access it earlier to create the filtered node stream. I will solve it, but it's not as easy as this PR. |
|
Ok, feel free to close this, if you are going to handle it by a different way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version, when DiscoveryV5 is enabled, it runs and discovers peers, however they are not pushed into the
dialScheduler, so they are actually not used.