New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP mega eof #29518
base: master
Are you sure you want to change the base?
WIP mega eof #29518
Conversation
cmd/evm/eofparser.go
Outdated
@@ -161,3 +161,24 @@ func parseAndValidate(s string) (*vm.Container, error) { | |||
} | |||
return &c, nil | |||
} | |||
|
|||
func eofDump(ctx *cli.Context) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have cmd/rlpdump
and cmd/abidump
. How about a cmd/eofdump
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, will move
case op == DUPN: | ||
case op == SWAPN: | ||
arg := int(code[pos+1]) + 1 | ||
if want, have := arg, height; want >= have { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it unintuitive that want == have
is an error.
TODO: