params: print time value instead of pointer in ConfigCompatError #29514
+28
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanBSC
force-pushed
the
fix_print_ConfigCompatError
branch
from
d05595c
to
05bd185
Compare
|
failed test cases not related |
holiman
reviewed
Apr 16, 2024
|
@holiman hi, updated as you suggested and a UT added. |
NathanBSC
force-pushed
the
fix_print_ConfigCompatError
branch
from
9e861d3
to
2baaa72
Compare
fjl
changed the title
fjl
approved these changes
Apr 30, 2024
Dayday10
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two errors in func ConfigCompatError as error info in the above picture
RewindToTime overflow
for dev testnet, often set timebased hardfork to
0, so they will be enabled same with London Block at genesisfor example in genesis.json
"shanghaiTime": 0,then we change it
"shanghaiTime": 1712889032,and run `geth --datadir ./ init ./genesis.json, then RewindToTime will overflow to the max of uint64 type
err.StoredTime and err.NewTime are pointers, print them is meaningless, their value are desired