all: implement EIP-6110, execution layer triggered deposits #29431
+744
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We added some logics in downloader when we introduce |
core/types/block.go
Outdated
| if deposits == nil { | ||
| b.header.DepositsHash = nil | ||
| } else if len(deposits) == 0 { | ||
| b.header.DepositsHash = &EmptyWithdrawalsHash |
core/types/block.go
Outdated
| b = b.WithWithdrawals(withdrawals) | ||
|
|
||
| // TODO(matt): copy this | ||
| b.deposits = deposits |
There was a problem hiding this comment.
e.g. b.deposits = slices.Clone(deposits) ?
lightclient
force-pushed
the
eip-6110
branch
3 times, most recently
from
b6ebd84
to
e86bac2
Compare
lightclient
force-pushed
the
eip-6110
branch
3 times, most recently
from
8311968
to
e4446bb
Compare
|
We need to allow prague in fcuV3 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP.
This PR implements EIP-6110: Supply validator deposits on chain. It also sketches out the base for Prague in the engine API types. I plan to base future Prague EIP work against this PR.