cmd/blsync, beacon/light: standalone beacon light sync tool (WIP, reworked request framework) #28708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsfelfoldi
requested review from
fjl,
rjl493456442,
karalabe and
holiman
as code owners
|
Please rebase on master where we already have the CommitteeChain merged. |
zsfelfoldi
force-pushed
the
blsync101
branch
2 times, most recently
from
4b60205
to
a4830e3
Compare
| } | ||
|
|
||
| func (s *Scheduler) handleEvent(server Server, event Event) { | ||
| s.Trigger() |
There was a problem hiding this comment.
Not 100% sure, but if we trigger the loop here, wouldn't we run into a race where the modules would be triggered with old serverEvents?
Afaiu we should handle the events, add the serverEvents and then trigger the modules.
Might be completely wrong though
There was a problem hiding this comment.
I think it's correct, this happens under mutex lock and the next process round can only look at the event lists after this function is finished. Maybe it would look more intuitive though if I deferred the trigger after executing the function.
zsfelfoldi
force-pushed
the
blsync101
branch
2 times, most recently
from
a3be388
to
2b951ad
Compare
zsfelfoldi
force-pushed
the
blsync101
branch
from
2b951ad
to
92ea985
Compare
|
Closed in favor of #28822 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP new version of blsync that might still be ugly in some places, lacks a lot of comments and unit tests but is working already. It is based on the new, simplified request framework: #28656
Update syncing mechanism has also been improved since the last version, now it can make parallel update requests, hopefully speeding up the initial sync process.
For a quick test run, you can use this endpoint and checkpoint:
./blsync --beacon.api "https://www.lightclientdata.org" --beacon.checkpoint 0xbfe7385d59b566b66b30e2e4b834ae374d06330141d0edeff2796187e621ecbb