Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

params: set TTD for mainnet #25518

Closed
wants to merge 2 commits into from
Closed

params: set TTD for mainnet #25518

wants to merge 2 commits into from

Conversation

sandakersmann
Copy link
Contributor

Uri-Margalit-bloXroute
Uri-Margalit-bloXroute suggested changes Aug 15, 2022
View reviewed changes
Copy link

@Uri-Margalit-bloXroute Uri-Margalit-bloXroute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the initial value is larger than uint64, you need to use the Mul function to set higher value

params/config.go Outdated Show resolved Hide resolved
@sandakersmann @Uri-Margalit-bloXroute
Update params/config.go
15f966d 
Co-authored-by: urimargalit-bloxroute <43845201+Uri-Margalit-bloXroute@users.noreply.github.com>
@holiman
Copy link
Contributor

holiman commented Aug 15, 2022

Closing this in favour of #25528

@holiman holiman closed this Aug 15, 2022
@MariusVanDerWijden
Copy link
Member

Hey @sandakersmann,
thank you for your contribution! Sorry that I made a second PR instead of merging yours.
I've been working on the merge for very long now and making the PR that finally enabled all of this hard work felt right.
I'm sorry, we're usually prioritizing outside contribution over our own. I hope you understand and that this will not discourage you from contributing.

@sandakersmann
Copy link
Contributor Author

No problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uri-Margalit-bloXroute Uri-Margalit-bloXroute Uri-Margalit-bloXroute requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sandakersmann @holiman @MariusVanDerWijden @Uri-Margalit-bloXroute