core, trie, eth, cmd: rework preimage store #25287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
force-pushed
the
preimage-store
branch
from
45eb56d
to
9665058
Compare
holiman
reviewed
Jul 18, 2022
Wait what, it already was right? |
|
@holiman It's disabled by default in Geth, because we always pass But from the perspective of if config == nil || config.Preimages { // TODO(karalabe): Flip to default off in the futureAnyway, just want to highlight the behavior of |
rjl493456442
force-pushed
the
preimage-store
branch
from
cbb3b1e
to
dbde947
Compare
gballet
reviewed
Jul 21, 2022
14 tasks
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Aug 6, 2022
* core, trie, eth, cmd: rework preimage store * trie: address comment
HanWang233
pushed a commit
to Meshee-Team/go-ethereum
that referenced
this pull request
Sep 11, 2022
* core, trie, eth, cmd: rework preimage store * trie: address comment
blakehhuynh
pushed a commit
to blakehhuynh/go-ethereum
that referenced
this pull request
Oct 3, 2022
* core, trie, eth, cmd: rework preimage store * trie: address comment
gitteri
pushed a commit
to paxosglobal/go-ethereum
that referenced
this pull request
Oct 3, 2022
* cmd/faucet: add sepolia network support (ethereum#25128) cmd/faucet: Add Sepolia network support to faucet * trie: fix size accounting in cleaner (ethereum#25007) Decrease children size instead of dirties size when marking dirties as cleaned up in trie cleaner * all: remove concept of public/private API definitions (ethereum#25053) * internal/ethapi: rename PublicEthereumAPI to EthereumAPI * eth: rename PublicEthereumAPI to EthereumAPI * internal/ethapi: rename PublicTxPoolAPI to TxPoolAPI * internal/ethapi: rename PublicAccountAPI to EthereumAccountAPI * internal/ethapi: rename PrivateAccountAPI to PersonalAccountAPI * internal/ethapi: rename PublicBlockChainAPI to BlockChainAPI * internal/ethapi: rename PublicTransactionPoolAPI to TransactionAPI * internal/ethapi: rename PublicDebugAPI to DebugAPI * internal/ethapi: move PrivateDebugAPI methods to DebugAPI * internal/ethapi: rename PublicNetAPI to NetAPI * les: rename PrivateLightServerAPI to LightServerAPI * les: rename PrivateLightAPI to LightAPI * les: rename PrivateDebugAPI to DebugAPI * les: rename PublicDownloaderAPI to DownloaderAPI * eth,les: rename PublicFilterAPI to FilterAPI * eth: rename PublicMinerAPI to MinerAPI * eth: rename PublicDownloaderAPI to DownloaderAPI * eth: move PrivateMinerAPI methods to MinerAPI * eth: rename PrivateAdminAPI to AdminAPI * eth: rename PublicDebugAPI to DebugAPI * eth: move PrivateDebugAPI methods to DebugAPI * node: rename publicAdminAPI to adminAPI * node: move privateAdminAPI methods to adminAPI * node: rename publicWeb3API to web3API * eth,internal/ethapi: sync comments with previous renamings * cmd/geth: drop geth js command (ethereum#25000) * cmd/geth: drop js command * cmd: simplify ipc path determination for attach * Add deprecation warning for js * rm testdata for exec * fix account unlock test cases * Update cmd/geth/consolecmd.go Co-authored-by: Martin Holst Swende <martin@swende.se> * fix Co-authored-by: Martin Holst Swende <martin@swende.se> * README,rpc: remove mention of "shh" RPC API (ethereum#25137) * eth, miner: retrieve mining state from live database (ethereum#25139) * miner: retrieve mining state from live database * eth/catalyst: ignore stale fcu events from cl * core: fix typo in txpool (ethereum#25149) Fix typo in txPool truncateQueue comment * go.mod: upgrade to latest goleveldb (ethereum#25067) Co-authored-by: Felix Lange <fjl@twurst.com> * eth/tracers: optimize goja buffer conversion (ethereum#25156) This changes the []byte <-> Uint8Array conversion to use an ArrayBuffer, avoiding inefficient copying of the slice data in Goja. Co-authored-by: Felix Lange <fjl@twurst.com> * eth: fix typo (ethereum#25161) * internal/ethapi: always return chain id (ethereum#25166) The error was introduced in PR ethereum#21686, but there is no good reason to enforce sync in this method, and it causes issues with EL/CL integration. * internal/ethapi: add note about eth_chainId compatibility with EIP-695 (ethereum#25168) Co-authored-by: Felix Lange <fjl@twurst.com> * all: remove `public` field from `rpc.API` (ethereum#25059) all: remove public field from rpc.API * cmd: migrate to urfave/cli/v2 (ethereum#24751) This change updates our urfave/cli dependency to the v2 branch of the library. There are some Go API changes in cli v2: - Flag values can now be accessed using the methods ctx.Bool, ctx.Int, ctx.String, ... regardless of whether the flag is 'local' or 'global'. - v2 has built-in support for flag categories. Our home-grown category system is removed and the categories of flags are assigned as part of the flag definition. For users, there is only one observable difference with cli v2: flags must now strictly appear before regular arguments. For example, the following command is now invalid: geth account import mykey.json --password file.txt Instead, the command must be invoked as follows: geth account import --password file.txt mykey.json * params: set TTD for sepolia testnet (ethereum#25179) * cmd/geth, p2p: add support for custom discovery UDP port (ethereum#24979) This adds a new flag to set the discovery port to be different from the TCP listener port. Co-authored-by: Felix Lange <fjl@twurst.com> * fix: linter warning (ethereum#25192) * core/rawdb: fix typo in comment (ethereum#25191) * core/rawdb: simplify TestDiskSeek to use memorydb (ethereum#25182) * cmd/utils: fix applying bootstrap nodes from config file (ethereum#25174) * internal/ethapi: return chain id for EIP-155 legacy txs (ethereum#25155) * common: increase StorageSize test coverage (ethereum#25188) * consensus/beacon: check that only the latest pow block is valid ttd block (ethereum#25187) * consensus/beacon: check that only the latest pow block is valid ttd block * consensus/beacon: move verification to async function * consensus/beacon: fix verifyTerminalPoWBlock, add test cases * consensus/beacon: cosmetic changes * consensus/beacon: apply karalabe's fixes * build: fix auto-completion scripts and include them in .deb package (ethereum#25195) Co-authored-by: Felix Lange <fjl@twurst.com> * build: upgrade to golangci-lint v1.46.2 (ethereum#25202) This upgrade is required to fix lint issues with urfave/cli/v2, which uses generics when built with Go 1.18 * build/deb: fix auto-completion install paths (ethereum#25204) * params: go-ethereum v1.10.20 stable * params: begin v1.10.21 release cycle * common/prque: fix typo * eth/catalyst: disallow importing blocks via newPayload during snap sync (ethereum#25210) * eth/catalyst: disallow importing blocks via newPayload during snap sync * eth/catalyst: make tests pass by using full sync only * eth/catalysts: make the import delay a bit cleaner * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * Replace fmt.Errorf with errors.New in abi argument (ethereum#25181) Replace unnecessary fmt.Errorf with errors.New in accounts/abi/argument.go * all: change format `0x%x` to `%#x` (ethereum#25221) * consensus/beacon: copy td value so we can modify it (ethereum#25230) * consensus/beacon: copy td value so we can modify it * consensus/beacon: copy td value so we can modify it * core: allow external code to set the block validator for malicious tests (ethereum#25119) * core: don't validate state * core: allow external validator * core: revert * core: comments * Update blockchain_reader.go * core: move SetValidator to blockchain.go * core: rename method * core: apply ttd override to uninitialized db (ethereum#25136) * core: apply ttd override to genesis block * core: apply overrides properly * signer/core/apitypes: support primitive types int96/uint96 (ethereum#25105) I have a EIP712 typehash using uint96, but it's currently not supported by go-ethereum. This change fixes it. * cmd/geth, cmd/devp2p: fix some cli parsing issues (ethereum#25234) * cmd/geth: add some missing argument count checks * internal/flags: skip cmds with no action func in MigrateGlobalFlags * internal/flags: add Merge * cmd/devp2p: re-add listener config flags in discv4 commands * core: allow external processor (ethereum#25233) * consensus/beacon: verify timestamp is greater than parent timestamp (ethereum#25236) * go.mod: updated logfmt dependency (ethereum#25231) This fixes an issue in abigen tests with go 1.17. * internal/ethapi: add basefee to block overrides (ethereum#25219) * trie: fix typo in comment (ethereum#25241) paralallel -> parallel * core/types: fix typo in comment (ethereum#25249) * internal/ethapi: fix chain ID check to return all non-zero IDs (ethereum#25244) * rpc: add graceful shutdown timeout for HTTP server (ethereum#25258) This change ensures the HTTP server will always terminate within at most 5s, even when all connections are busy and do not become idle. Co-authored-by: Felix Lange <fjl@twurst.com> * p2p/discover: fix typos in comments (ethereum#25272) * build: upgrade -dlgo version to Go 1.18.3 * core, eth: pre-allocate map in storage copy (ethereum#25279) * eth/tracers: add initial revertReasonTracer tracer (ethereum#25265) Adds a native tracer that returns that in case of failure returns the error message or the revert reason of a transaction. Co-authored-by: Martin Holst Swende <martin@swende.se> * params: enable DNS discovery on Sepolia too * internal/build: add a timestamp to the tar archive folder * build: upgrade -dlgo version to Go 1.18.4 * accounts/abi: fix typo in comment (ethereum#25271) * accounts/abi/bind/backends: return hash of new blocks (ethereum#25163) Co-authored-by: Jens <jmw.1906@gmx.de> * all: remove version field from rpc.API * internal/ethapi: error if tx args includes chain id that doesn't match local (ethereum#25157) * internal/ethapi: error if tx args includes chain id that doesn't match local * internal/ethapi: simplify code a bit Co-authored-by: Péter Szilágyi <peterke@gmail.com> * core: remove lock in BlockChain.ExportN (ethereum#25254) * Remove locking in (*BlockChain).ExportN Since ExportN is read-only, it shouldn't need the lock. (?) * Add hash check to detect reorgs during export. * fix check order * Update blockchain.go * Update blockchain.go Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * core: prevent negative fee during RPC calls (ethereum#25214) During RPC calls such as eth_call and eth_estimateGas, st.evm.Config.NoBaseFee is set which allows the gas price to be below the base fee. This results the tip being negative, and balance being subtracted from the coinbase instead of added to it, which results in a potentially negative coinbase balance interestingly. This can't happen during normal chain processing as outside of RPC calls the gas price is required to be at least the base fee, as NoBaseFee is false. This change prevents this behavior by disabling fee payment when the fee is not set. Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> * core, les, eth: port snap sync changes (ethereum#24898) core, eth, les, trie: rework snap sync * tests: only activate merge on london rules (ethereum#25239) * trie: fix 'gosimple' lint issue (ethereum#25309) * p2p/discover: apply netrestrict in discv5 response handler (ethereum#25304) * cmd/geth: remove redundant 0x in dbGet/dbDelete (ethereum#25315) * accounts/abi: substitude arg%d to the range keyword (ethereum#25307) * accounts/abi: substitude arg%d to the range keyword * support more keywords * review feedback * params: Add Shanghai and Cancun blocks (ethereum#25305) * params: Add Shangai and Cancun blocks * fix copy/paste error Co-authored-by: Martin Holst Swende <martin@swende.se> * fix typo in Shanghai name Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd/puppeth: remove support for exporting non-Geth genesis configurations (ethereum#25329) * cmd/puppeth: remove support for exporting non-Geth genesis configurations * remove unused function * params: set goerli TTD to 10_790_000 (ethereum#25324) * signer/core: add canonical TypedData hashing methods (ethereum#25283) * params: set sepolia mergeNetsplitBlock to 1735371 (ethereum#25372) * cmd/geth: eth/catalyst: enable authrpc by default (ethereum#25152) * cmd/geth: eth/catalyst: enable authrpc by default * eth/catalyst: rename catalyst -> Engine API in logs * eth/catalyst: don't panic * deps: update goleveldb * eth/catalyst: better warning for ttd not configured (ethereum#25394) * cmd: use flags.Merge for grouping flags (ethereum#25392) * consensus/beacon: fix typo in comment (ethereum#25391) * p2p/netutil: minor code cosmetic Signed-off-by: Abirdcfly <fp544037857@gmail.com> * eth, internal, light: fix error string capitalization (ethereum#25364) * light: fix differTries err message in tests (ethereum#25358) * all: add whitespace linter (ethereum#25312) * golangci: typo Signed-off-by: Delweng <delweng@gmail.com> * golangci: add whietspace Signed-off-by: Delweng <delweng@gmail.com> * *: rm whitesapce using golangci-lint Signed-off-by: Delweng <delweng@gmail.com> * cmd/puppeth: revert accidental resurrection Co-authored-by: Péter Szilágyi <peterke@gmail.com> * eth/tracers/js: fix capitalization in tests * eth: support bubbling up bad blocks from sync to the engine API (ethereum#25190) * eth: support bubbling up bad blocks from sync to the engine API * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * Update eth/catalyst/api.go * eth/catalyst: when forgetting bad hashes, also forget descendants * eth/catalyst: minor bad block tweaks for resilience Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Martin Holst Swende <martin@swende.se> * params: change Merge config to print simpler message This fixes ethereum#25366 * core: eth: rpc: implement safe rpc block (ethereum#25165) * core: eth: rpc: implement safe rpc block * core: fix setHead, panics * go.mod: downgrade leveldb (ethereum#25413) * params: go-ethereum v1.10.21 stable * params: begin v1.10.22 release cycle * core, trie, eth, cmd: rework preimage store (ethereum#25287) * core, trie, eth, cmd: rework preimage store * trie: address comment * eth/catalyst: fix NewPayload warn log when dropping due to snap sync * node: set JWT expiry to 60 seconds (ethereum#25416) * node: set JWT expiry to 60 seconds * node: rename var * eth/catalyst: return syncing not accepted (ethereum#25414) * eth/catalyst: return syncing not accepted * eth/catalyst: fix test * eth/catalyst: return 0x0 if latestvalid is pow block (ethereum#25423) * eth/catalyst: return 0x0 if latestvalid is pow block * eth/catalyst: return 0x0 if latestvalid is pow block * eth/catalyst: fix header retrieval, fix sign check Co-authored-by: Péter Szilágyi <peterke@gmail.com> * ethereum, ethclient: add FeeHistory support (ethereum#25403) Co-authored-by: Felix Lange <fjl@twurst.com> * all: use AbsTime.Add instead of conversion (ethereum#25417) * cm/puppeth: fix crash when of ethstats specifier doesn't contain `:` (ethereum#25405) Signed-off-by: Delweng <delweng@gmail.com> * eth: fix typo in comment (ethereum#25327) * common/compiler: json unmarshalling error checks (ethereum#25449) complier/solidity:add json.Unmarshal err check * cmd, core, eth, les, params: add merge-passed chain config (ethereum#24538) * cmd, core, eth, les, params: add merge-passed chain config * eth/catalyst, params: add various warning on malfunctioning beacons * eth/catalyst: fix warning for beacons without transition exchanges * eth: fix typo in catalyst api (ethereum#25460) eth: fix typo * eth/gasprice/feehistory: support finalized block (ethereum#25442) * build: upgrade -dlgo version to Go 1.18.5 * consensus/ethash: remove temp files created during DAG generation (ethereum#25381) This makes it remove not only the actual DAG file, but also the temporary file which the DAG data is written to while generating. * cmd/devp2p/internal/ethtest: update tests for eth/67 (ethereum#25306) * node, rpc: add ReadHeaderTimeout config option (ethereum#25338) This change makes http.Server.ReadHeaderTimeout configurable separately from ReadTimeout for RPC servers. The default is set to the same as ReadTimeout, which in order to cause no change in existing deployments. * core/types: fix typo in comment (ethereum#25359) * core: preallocate batch size in bloomIndexer (ethereum#25289) This change reduces allocations when committing bloombits indexes by creating the database batch with a larger initial size. * internal/ethapi: don't estimate gas if no limit provided in eth_createAccessList (ethereum#25467) Because the goal of eth_createAccessList is providing the caller with the largest-possible access list, it's generally not important that the gas limit used by the tracer will match the usage of the call exactly. Avoiding the gas estimation step is a performance improvement. As long as the call does not branch based on gas limit, the returned access list will be accurate. * graphql: embed *Resolver instead of backend interface (ethereum#25468) This creates some infrastructure to share resources between graphql API objects. * node: remove noop path.Join (ethereum#25475) Signed-off-by: Delweng <delweng@gmail.com> * core, trie: rework trie committer (ethereum#25320) * all: rework trie and trie committer * all: get rid of internal cache in trie * all: fixes * trie: polish * core, trie: address comments * trie: fix imports * core/state: address comments * core/state/snapshot: polish * trie: remove unused code * trie: update tests * trie: don't set db as nil * trie: address comments * trie: unskip test * core: use TryGetAccount to read what TryUpdateAccount has written (ethereum#25458) * core: use TryGetAccount to read where TryUpdateAccount has been used to write * Gary's review feedback * implement Gary's suggestion * fix bug + rename NewSecure into NewStateTrie * trie: add backwards-compatibility aliases for SecureTrie * Update database.go * make the linter happy Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * cmd, core, ethdb, node: move chain freezer one folder deeper (ethereum#25487) * cmd, core, ethdb, node: create chain freezer in a sub folder * core/rawdb: remove unused code * core, ethdb, node: add AncientDatadir API back * cmd, core: extend freezer info dump for sub-ancient-store * core/rawdb: rework freezer inspector * core/rawdb: address comments from Peter * core/rawdb: fix build issue * eth/downloader: fix log errors of queue_test.go (ethereum#25494) * core: fix uncle creation in TestFastVsFullChains (ethereum#25476) Co-authored-by: Felix Lange <fjl@twurst.com> * eth: formatted error nit (ethereum#25499) * eth/tracers: add onlyTopCall option to callTracer (ethereum#25430) This PR allows users to pass in a config object directly to the tracers. Previously only the struct logger was configurable. It also adds an option to the call tracer which if enabled makes it ignore any subcall and collect only information about the top-level call. See ethereum#25419 for discussion. The tracers will silently ignore if they are passed a config they don't care about. * all: cleanup the APIs for initializing genesis (ethereum#25473) * all: polish tests * core: apply feedback from Guillaume * core: fix comment * signer/rules: register clef api properly when rules are used (ethereum#25455) signer/rules: register clef api properly when rules are used, fixes ethereum#25298 * core: remove unused bc ChainContext in applyTransaction * build: add static linking support (ethereum#25492) This adds support for building statically-linked executables using ci.go. Static linking is enabled by default in Docker builds, making it possible to use the geth executable in any Docker image, regardless of the Linux distribution the Dockerfile is based on. Co-authored-by: Felix Lange <fjl@twurst.com> * accounts/abi: display name in "method/event not found" error (ethereum#25512) * internal/ethapi: rework setDefaults for tx args so fee logic is separate (ethereum#25197) Co-authored-by: bobpkr <bob.p@krustuniverse.com> * core/genesis: remove calaverasAllocData (ethereum#25516) core/genesis: calaverasAllocData no longer used * params: set ttdpassed on goerli (ethereum#25519) * params: set mainnet terminal total difficulty for the merge (ethereum#25528) * params: set mainnet ttd to 58_750_000_000_000_000_000_000 * params: set mainnet ttd to 58_750_000_000_000_000_000_000 * core, trie: flush preimages to db on blockchain close (ethereum#25533) * core, trie: flush preimages to db on database close Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * rename Close to CommitPreimages for clarity * core, trie: nitpick fixes Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> * core/state, trie, light: add a TryDeleteAccount method (ethereum#25531) * core/state, trie, light: Add a DeleteAccount method * review feedback * Update database.go * pr triage feedback Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * core: make tx journal check and open atomic (ethereum#25530) * core: reduce system call about `os` * avoid deprecated method * cmd. core: save preimages on genesis creation (ethereum#25538) force preimage dump for genesis * rlp/rlpgen: fix error handling when target type not found (ethereum#25547) typ will be nil when lookupStructType returns an error. cfg.Type should be used instead. * trie: improve node rlp decoding performance (ethereum#25357) This avoids copying the input []byte while decoding trie nodes. In most cases, particularly when the input slice is provided by the underlying database, this optimization is safe to use. For cases where the origin of the input slice is unclear, the copying version is retained. The new code performs better even when the input must be copied, because it is now only copied once in decodeNode. * all: fix some typos (ethereum#25551) * Fix some typos * Fix some mistakes * Revert 4byte.json * Fix an incorrect fix * Change files to fails * internal/ethapi: fix comment typo (ethereum#25548) * accounts/abi/bind/backends: typo fix (ethereum#25549) * eth, les: unlock downloader peerSet if there's an error (ethereum#25546) Unlock peerSet if there's an error in the downloader * cmd/geth: parse uint64 value with ParseUint instead of Atoi (ethereum#25545) Parse uint64 value with ParseUint instead of Atoi * consensus/beacon: check ttd reached on pos blocks (ethereum#25552) * consensus/beacon: check ttd reached on pos blocks * consensus/beacon: check ttd reached on pos blocks * consensus/beacon: check ttd reached on pos blocks * eth/filters: add global block logs cache (ethereum#25459) This adds a cache for block logs which is shared by all filters. The cache size of is configurable using the `--cache.blocklogs` flag. Co-authored-by: Felix Lange <fjl@twurst.com> * accounts/abi: fix set function (ethereum#25477) * accounts/abi: fix set function * don't break things * update test * internal/ethapi: fix build regression (ethereum#25555) * eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524) * eth/fetcher: introduce some lag in tx fetching * eth/fetcher: change conditions a bit * eth/fetcher: use per-batch quota check * eth/fetcher: fix some comments * eth/fetcher: address review concerns * eth/fetcher: fix panic + add warn log * eth/fetcher: fix log * eth/fetcher: fix log * cmd/devp2p/internal/ethtest: fix ignorign tx announcements from prev. tests * cmd/devp2p/internal/ethtest: fix TestLargeTxRequest This increases the number of tx relay messages the test waits for. Since go-ethereum now processes incoming txs in smaller batches, the announcement messages it sends are also smaller. Co-authored-by: Felix Lange <fjl@twurst.com> * Revert "eth/fetcher: don't spend too much time on transaction inclusion" (ethereum#25567) Revert "eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524)" This reverts commit 0ce494b. * eth/catalyst: warn less frequently if no beacon client is available (ethereum#25569) * eth/catalyst: warn less frequently if no beacon client is available * eth/catalyst: tweak warning frequency a bit * eth/catalyst: some more tweaks * Update api.go Co-authored-by: Felix Lange <fjl@twurst.com> * params: release go-ethereum v1.10.22 * params: begin v1.10.23 release cycle * core, eth/downloader: handle spurious junk bodies from racey rollbacks (ethereum#25578) * eth/downloader: handle junkbodies/receipts in the beacon sync * core: check for header presence when checking for blocks * core/state, trie: fix trie flush order for proper pruning * consensus/beacon: don't ignore errors * params: release Geth v1.10.23 * params: begin v1.10.24 release cycle * params: begin go-ethereum v1.11 release cycle * internal/ethapi: rename debug getters to match spec (ethereum#25176) Some small fixes to get the existing debug methods to conform to the spec. Mainly dropping the encoding information from the method name as it should be deduced from the debug context and allowing the method to be invoked by either block number or block hash. It also adds the method debug_getTransaction which returns the raw tx bytes by tx hash. This is pretty much equivalent to the eth_getRawTransactionByHash method. * accounts/abi/bind: add const for tx fee elasticity multiplier (ethereum#25504) Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * all: remove duplicate word in comments (ethereum#25618) Signed-off-by: Abirdcfly <fp544037857@gmail.com> Signed-off-by: Abirdcfly <fp544037857@gmail.com> * cmd/geth: fix legacy receipt detection for empty db (ethereum#25609) * build: fix ignored errors (ethereum#25591) * docs: specify execution client (ethereum#25566) Co-authored-by: Felix Lange <fjl@twurst.com> * ethclient: add 'finalized' and 'safe' block number support (ethereum#25580) * node: change JWT error status to 401 Unauthorized (ethereum#25629) * node: fix regression in TestJWT (ethereum#25635) * all: move genesis initialization to blockchain (ethereum#25523) * all: move genesis initialization to blockchain * core: add one more check * core: fix tests * eth/catalyst: adjust eta for themerge (ethereum#25601) * eth/catalyst: adjust eta for themerge * squash * squash * eth/catalyst: address review concerns * mobile: close node on error (ethereum#25643) * graphql: return correct logs for tx (ethereum#25612) * graphql: fix tx logs * minor * Use optimized search for selecting tx logs * trie: fix grammar in comment (ethereum#25648) * trie: cleanup stateTrie (ethereum#25640) It's a trivial PR to hide the error log when the trie node is not found in the database. The idea for this change is for all TryXXX functions, the error is already returned and we don't need to fire a log explicitly. Recently there are a few tickets ethereum#25613 ethereum#25589 reporting that the trie nodes are missing because of debug.SetHead. The root cause is after resetting, the chain rewinds to a historical point and re-imports the blocks on top. Since the node is already synced and started to accept transactions previously, these transactions are still kept in the txpool and verified by txpool with a live state. This live state is constructed based on the live trie database, which is changed fast by node referencing and de-referencing. Unfortunately, when we construct a live state(like the state in txpool), we don't reference the state we have. The blockchain will garbage collect the intermediate version nodes in another thread which leads the broken live state. The best solution for this is to forcibly obtain a reference for all live states we create and call release function once it's used up. But it might end up with more junks persisted into disk. Will try to find an elegant solution later in the following PR. * eth/catalyst: prevent division by zero (ethereum#25654) eth/catalyst: prevent diff by zero * trie: better error reporting (ethereum#25645) * core/state: filter out nil trie for copy (ethereum#25575) * eth/protocols/snap: fix problems due to idle-but-busy peers * mobile: register filter APIs (ethereum#25642) This fixes a regression introduced in PR ethereum#25459. * README.md: improve grammar (ethereum#25646) Co-authored-by: Felix Lange <fjl@twurst.com> * eth/tracers/js: fill in log.refund field (ethereum#25661) For some reason, an accessor method for this field exists in JS, but the value was never actually assigned. * eth/fetcher: throttle peers which deliver many invalid transactions (ethereum#25573) Co-authored-by: Felix Lange <fjl@twurst.com> * node, rpc: add JWT auth support in client (ethereum#24911) This adds a generic mechanism for 'dial options' in the RPC client, and also implements a specific dial option for the JWT authentication mechanism used by the engine API. Some real tests for the server-side authentication handling are also added. Co-authored-by: Joshua Gutow <jgutow@optimism.io> Co-authored-by: Felix Lange <fjl@twurst.com> * rpc: check that "version" is "2.0" in request objects (ethereum#25570) The JSON-RPC spec requires the "version" field to be exactly "2.0", so we should verify that. This change is not backwards-compatible with sloppy client implementations, but I decided to go ahead with it anyway because the failure will be caught via the returned error. * trie: fix typo in comment (ethereum#25667) * trie: fix unhandled error in test (ethereum#25628) * eth/tracers/js: improve integer types in log object (ethereum#25668) All fields related to gas must be represented as uint64. Depth is internally tracked as int, so it makes sense to also store it as int. * trie: check childrens' existence concurrently for snap heal * core, light, trie: remove DiskDB function from trie database (ethereum#25690) * params: update chts (ethereum#25707) * core/vm: rename RANDOM to PREVRANDAO (ethereum#25691) See: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-4399.md > This EIP supplants the semantics of the return value of existing DIFFICULTY (0x44) opcode and renames the opcode to PREVRANDAO (0x44). * all: cleanup tests (ethereum#25641) Follow-up to PR ethereum#25523 to cleanup all relevant tests. * eth, les: rework chain tracer (ethereum#25143) This PR simplifies the logic of chain tracer and also adds the unit tests. The most important change has been made in this PR is the state management. Whenever a tracing state is acquired there is a corresponding release function be returned as well. It must be called once the state is used up, otherwise resource leaking can happen. And also the logic of state management has been simplified a lot. Specifically, the state provider(eth backend, les backend) should ensure the state is available and referenced. State customers can use the state according to their own needs, or build other states based on the given state. But once the release function is called, there is no guarantee of the availability of the state. Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> * eth/tracer: fix broken test (ethereum#25715) * trie: update comments + err check for preimages (ethereum#25672) This PR includes minor updates to comments in trie/committer that reference insertion to the db, and adds an err != nil check for the return value of preimages.commit. * eth/protocols/snap: throttle trie heal requests when peers DoS us (ethereum#25666) * eth/protocols/snap: throttle trie heal requests when peers DoS us * eth/protocols/snap: lower heal throttle log to debug Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/protocols/snap: fix comment Co-authored-by: Martin Holst Swende <martin@swende.se> * p2p/msgrate: be more lenient when calculating 'mean' (ethereum#25653) The p2p msgrate tracker is a thing which tries to estimate some mean round-trip times. However, it did so in a very curious way: if a node had 200 peers, it would sort their 200 respective rtt estimates, and then it would pick item number 2 as the mean. So effectively taking third fastest and calling it mean. This probably works "ok" when the number of peers are low (there are other factors too, such as ttlScaling which takes some of the edge off this) -- however when the number of peers is high, it becomes very skewed. This PR instead bases the 'mean' on the square root of the length of the list. Still pretty harsh, but a bit more lenient. * rpc: improve error codes for internal server errors (ethereum#25678) This changes the error code returned by the RPC server in certain situations: - handler panic: code -32603 - result marshaling error: code -32603 - attempt to subscribe via HTTP: code -32001 In all of the above cases, the server previously returned the default error code -32000. Co-authored-by: Nicholas Zhao <nicholas.zhao@gmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> * core: place a cap on reorglogs (ethereum#25711) This PR makes the event-sending for deleted and new logs happen in batches, to prevent OOM situation due to large reorgs. Co-authored-by: Felix Lange <fjl@twurst.com> * build: upgrade to go 1.19 (ethereum#25726) This changes the CI / release builds to use the latest Go version. It also upgrades golangci-lint to a newer version compatible with Go 1.19. In Go 1.19, godoc has gained official support for links and lists. The syntax for code blocks in doc comments has changed and now requires a leading tab character. gofmt adapts comments to the new syntax automatically, so there are a lot of comment re-formatting changes in this PR. We need to apply the new format in order to pass the CI lint stage with Go 1.19. With the linter upgrade, I have decided to disable 'gosec' - it produces too many false-positive warnings. The 'deadcode' and 'varcheck' linters have also been removed because golangci-lint warns about them being unmaintained. 'unused' provides similar coverage and we already have it enabled, so we don't lose much with this change. * p2p/discover/v5wire: reject packets smaller than 63 bytes (ethereum#25740) * core: preallocate maps in TxPool helper methods (ethereum#25737) * accounts/abi: fix typo in error message (ethereum#25742) * graphql: fixes missing tx logs (ethereum#25745) * graphql: fix tx logs * graphql: refactor test service setup * graphql: add test for tx logs * cmd/geth: add a verkle subcommand (ethereum#25718) * cmd/geth: add a verkle subcommand * fix copyright year * remove unused command parameters * check that the output file was successfully written to Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd/geth: goimports fix Co-authored-by: Martin Holst Swende <martin@swende.se> * node: fix HTTP server always force closing (ethereum#25755) Co-authored-by: Felix Lange <fjl@twurst.com> * core: fix log order in "Imported new chain segment" (ethereum#25768) * node: fix lint issue in rpcstack.go (ethereum#25774) * les/catalyst/api: add support for ExchangeTransitionConfigurationV1 (ethereum#25752) This method is missing in light client mode and breaks consensus clients that require a valid response. * params: set TerminalTotalDifficultyPassed to true (ethereum#25769) * params: set TerminalTotalDifficultyPassed to true * Update params/config.go Co-authored-by: Martin Holst Swende <martin@swende.se> * trie: handle more batch commit errors in Database (ethereum#25674) * core/rawdb: fix leak of backoff timer (ethereum#25776) * crypto/bls12381: docfix of g1 Affine (ethereum#25729) bls12381: docfix of g1 Affine. * internal/ethapi: return error when requesting invalid trie key (ethereum#25762) This change makes eth_getProof and eth_getStorageAt return an error when the argument contains invalid hex in storage keys. Co-authored-by: Felix Lange <fjl@twurst.com> * core: don't cache zero nonce in txNoncer (ethereum#25603) This changes the nonce cache used by TxPool to not store cached nonces for non-existing accounts. * core: more compact bad block report (ethereum#25714) This shortens the chain config summary in bad block reports, and adds go-ethereum version information as well. Co-authored-by: Felix Lange <fjl@twurst.com> * core: move build version reading to its own package (ethereum#25806) This fixes the build with Go 1.17, which does not have BuildInfo.Settings yet. * eth: fix a rare datarace on CHT challenge reply / shutdown * core/vm: return copy of input slice in identity precompile, avoid returndata copy (ethereum#25183) * core/vm: return copy of input slice in identity precompile. don't deep copy return data slice upon call completion * make use of common.CopyBytes * core/blockchain: downgrade tx indexing and unindexing logs (ethereum#25832) core/blockchain: downgrade tx indexing and unindexing logs from info to debug If a user has a finite tx lookup limit, they will see an "unindexing" info level log each time a block is imported. This information might help a user understand that they are removing the index each block and some txs may not be retrievable by hash, but overall it is generally more of a nuisance than a benefit. This change downgrades the log to a debug log. * eth/tracers: fix trace config for `TraceCall` (ethereum#25821) Co-authored-by: AtomicAzzaz <AtomicAzzaz@users.noreply.github.com> Co-authored-by: ewile <ewile@users.noreply.github.com> * eth/catalyst: add locking around newpayload (ethereum#25816) Sometimes we get stuck on db compaction, and the CL re-issues the "same" command to us multiple times. Each request get stuck on the same place, in the middle of the handler. This changes makes it so we do not reprocess the same payload, but instead detects it early. * eth/catalyst: make tests run faster (ethereum#25818) * cmd/utils: make --authrpc.jwtsecret a DirectoryFlag (ethereum#25849) Signed-off-by: Delweng <delweng@gmail.com> * eth/protocols/snap: make log messages more clear that sync is ongoing (ethereum#25837) * eth/protocols/snap: make log messages more clear that sync is ongoing * Update sync.go Co-authored-by: Felix Lange <fjl@twurst.com> * .github: add CL client to issue template (ethereum#25814) * p2p: add channel buffers to avoid goroutine leaks in tests (ethereum#24929) * internal/version: use gitCommit injection in version handling code (ethereum#25851) This changes the CI build to store the git commit and date into package internal/version instead of package main. Doing this essentially merges our two ways of tracking the go-ethereum version into a single place, achieving two objectives: - Bad block reports, which use version.Info(), will now have the git commit information even when geth is built in an environment such as launchpad.net where git access is unavailable. - For geth builds created by `go build ./cmd/geth` (i.e. not using `go run build/ci.go install`), git information stored by the go tool is now used in the p2p node name as well as in `geth version` and `geth version-check`. * cmd/abigen: change --exc to exclude by type name (ethereum#22620) The abigen exclusion pattern, previously on the form "path:type", now supports wildcards. Examples "*:type" to exclude a named type in all files, or "/path/to/foo.sol:*" all types in foo.sol. * tests, les, eth: remove mentions of deprecated Morden testnet (ethereum#23570) * remove morden * Update commons.go * Update handler.go * empty commit to make appveyor happy * all: clean up the configs for pruner and snapshotter (ethereum#22396) This PR cleans up the configurations for pruner and snapshotter by passing a config struct. And also, this PR disables the snapshot background generation if the chain is opened in "read-only" mode. The read-only mode is necessary in some cases. For example, we have a list of commands to open the etheruem node in "read-only" mode, like export-chain. In these cases, the snapshot background generation is non expected and should be banned explicitly. * cmd/puppeth, cmd/utils: finalize removal of gasTarget flag (ethereum#24370) This PR fully removes the --miner.gastarget flag, as previously it was only hidden from the geth --help command, but could still be used. * core/types: improve accuracy of header.Size() (ethereum#25859) The header.Size() method did not take the basefee into account. * eth/tracers: pad memory slice on OOB case (ethereum#25213) * eth/tracers: pad memory slice on oob case * eth/tracers/js: fix testfailure due to err msg capitalization Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd/faucet: fix readme typos (ethereum#25867) * Fix: typos Fix: typos * Undo change Undo change * core: fix datarace in txpool, fixes ethereum#25870 and ethereum#25869 (ethereum#25872) core: fix datarace in txpool pendingnoce, fixes ethereum#25870 * eth/downloader, les/downloader: fix subtle flaw in queue delivery (ethereum#25861) * fix queue.deliver * les/downloader: fix queue.deliver Co-authored-by: Martin Holst Swende <martin@swende.se> * core/vm: better handle error on eip activation check (ethereum#25131) * core/vm: correct logic for eip check of NewEVMInterpreter * refactor * cmd/geth: make dumpgenesis load genesis datadir if it exists (ethereum#25135) `geth dumpgenesis` currently does not respect the content of the data directory. Instead, it outputs the genesis block created by command-line flags. This PR fixes it to read the genesis from the database, if the database already exists. Co-authored-by: Martin Holst Swende <martin@swende.se> * tests: fix state test error checking (ethereum#25702) Some tests define an 'expectException' error but the tests runner does not check for conditions where this test value is filled (error expected) but in which no error is returned by the test runner. An example of this scenario is GeneralStateTests/stTransactionTest/HighGasPrice.json, which expects a 'TR_NoFunds' error, but the test runner does not return any error. Signed-off-by: meows <b5c6@protonmail.com> * eth/tracers: use gencodec for native tracers (ethereum#25637) The call tracer and prestate tracer store data JSON-encoded in memory. In order to support alternative encodings (specifically RLP), it's better to keep data a native format during tracing. This PR does marshalling at the end, using gencodec. OBS! This PR changes the call tracer result slightly: - Order of type and value fields are changed (should not matter). - Output fields are completely omitted when they're empty (no more output: "0x"). Previously, this was only _sometimes_ omitted (e.g. when call ended in a non-revert error) and otherwise 0x when the output was actually empty. * cmd, core, eth, les, light: track deleted nodes (ethereum#25757) * cmd, core, eth, les, light: track deleted nodes * trie: add docs * trie: address comments * cmd, core, eth, les, light, trie: trie id * trie: add tests * trie, core: updates * trie: fix imports * trie: add utility print-method for nodeset * trie: import err * trie: fix go vet warnings Co-authored-by: Martin Holst Swende <martin@swende.se> * eth: return state error via GetEVM (ethereum#25876) * make vmError more useful * fix for review * Update api.go * revert calling site Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * eth/downloader: make flakey test less flakey (ethereum#25879) * ethclient/gethclient: fix bugs in override object encoding (ethereum#25616) This fixes a bug where contract code would be overridden to empty code ("0x") when the Code field of OverrideAccount was left nil. The change also cleans up the encoding of overrides to only send necessary fields, and improves documentation. Fixes ethereum#25615 Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Martin Holst Swende <martin@swende.se> * trie, eth/protocols/snap: less tiny db-writes during trie-healing (ethereum#25681) This PR prevent making tiny writes during state healing, by only performing the batch-write if the accumulated data is large enough to be meaningful. * accounts/abi/bind/backends: fix AdjustTime to respect Fork (ethereum#25225) * tests: report mgas/s metric in evm benchmarks (ethereum#25700) * test(state): report mgas/s metric in EVM benchmark * revert testdata submodule update * aggregate mgas/s results * calculate elapsed time better * tests: benchmarks - handle access list + take refund into account Co-authored-by: Martin Holst Swende <martin@swende.se> * core/vm: minor trivial clean up (ethereum#25880) * dropped `vm.keccakState` for `crypto.KeccakState` * cleaned up `OpCode.IsPush()` * eth/tracers: fix a bug in prestateTracer (ethereum#25884) * internal/ethapi: handle odd length hex in decodeHash (ethereum#25883) This change adds zero-padding (prefix) of odd nibbles in the decodeHash function. Co-authored-by: ty <ty@oncoder.com> * core: rework tx indexer (ethereum#25723) This PR reworks tx indexer a bit. Compared to the original version, one scenario is no longer handled - upgrading from legacy geth without indexer support. The tx indexer was introduced in 2020 and have been present through hardforks, so it can be assumed that all Geth nodes have tx indexer already. So we can simplify the tx indexer logic a bit: - If the tail flag is not present, it means node is just initialized may or may not with an ancient store attached. In this case all blocks are regarded as unindexed - If the tail flag is present, it means blocks below tail are unindexed, blocks above tail are indexed This change also address some weird cornercases that could make the indexer not work after a crash. * accounts/abi: return toGoType error immediately (ethereum#25565) * eth/tracers: remove revertReasonTracer, add revert reason to callTracer (ethereum#25508) * eth/tracers: add revertReason to callTracer * update callframe gen json * add revertal to calltrace test * accounts/abi/bind: parse ABI only once on bind (ethereum#25574) * accounts/abi/bind: parse ABI once on bind * accounts/abi/bind: suppress 'imported and not used' error for abi package * internal/flags: fix issue with stringslice migration (ethereum#25830) This fixes a cornercase bug where the flag migration would mess up the value of StringSlice flags. * cmd/geth, cmd/utils: geth attach with custom headers (ethereum#25829) This PR makes it possible to set custom headers, in particular for two scenarios: - geth attach - geth commands which can use --remotedb, e..g geth db inspect The ability to use custom headers is typically useful for connecting to cloud-apis, e.g. providing an infura- or alchemy key, or for that matter access-keys for environments behind cloudflare. Co-authored-by: Felix Lange <fjl@twurst.com> * add market gas price to simulate duplicate nonce behavior (#7) * fix duplicated test * add back tests Signed-off-by: Abirdcfly <fp544037857@gmail.com> Signed-off-by: Delweng <delweng@gmail.com> Signed-off-by: meows <b5c6@protonmail.com> Co-authored-by: Zachinquarantine <Zachinquarantine@protonmail.com> Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: ucwong <ucwong@126.com> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: int88 <106391185+int88@users.noreply.github.com> Co-authored-by: willian.eth <willian@ufpa.br> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: zeim839 <50573884+zeim839@users.noreply.github.com> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: Ruohui Wang <nomaru@outlook.com> Co-authored-by: Andre Patta <andre_luis@outlook.com> Co-authored-by: Seungbae.yu <72970043+dbadoy@users.noreply.github.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> Co-authored-by: スパイク <1311798+spkjp@users.noreply.github.com> Co-authored-by: Brion <4777457+cifer76@users.noreply.github.com> Co-authored-by: Marius Kjærstad <mkjaerstad@protonmail.com> Co-authored-by: Philip Fan <fanwengang@hotmail.com> Co-authored-by: Ikko Ashimine <eltociear@gmail.com> Co-authored-by: Jens W <8270201+DragonDev1906@users.noreply.github.com> Co-authored-by: Jens <jmw.1906@gmx.de> Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: henridf <henridf@gmail.com> Co-authored-by: Lee Bousfield <ljbousfield@gmail.com> Co-authored-by: Ha ĐANG <dvietha@gmail.com> Co-authored-by: jwasinger <j-wasinger@hotmail.com> Co-authored-by: Nikhil Suri <nikhilsuri@comcast.net> Co-authored-by: Abirdcfly <fp544037857@gmail.com> Co-authored-by: Eval EXEC <execvy@gmail.com> Co-authored-by: Delweng <delweng@gmail.com> Co-authored-by: Rithwik Babu <rithwikbabu2020@gmail.com> Co-authored-by: Henry <101552941+henry-0@users.noreply.github.com> Co-authored-by: Manoj Kumar <mnjkmr398@gmail.com> Co-authored-by: Tristan-Wilson <87238672+Tristan-Wilson@users.noreply.github.com> Co-authored-by: yong <33920876+yzhaoyu@users.noreply.github.com> Co-authored-by: Seungbae Yu <dbadoy4874@gmail.com> Co-authored-by: ycyraum <ycyraum@fastmail.com> Co-authored-by: 0xe3b0c4 <110295932+0xe3b0c4@users.noreply.github.com> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: bobpkr <bob.p@krustuniverse.com> Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Co-authored-by: zhiqiangxu <652732310@qq.com> Co-authored-by: xinbenlv <zzn@zzn.im> Co-authored-by: uji <49834542+uji@users.noreply.github.com> Co-authored-by: Marius Kjærstad <sandakersmann@users.noreply.github.com> Co-authored-by: Rachel Bousfield <nfranks@protonmail.com> Co-authored-by: Jakub Freebit <49676311+jakub-freebit@users.noreply.github.com> Co-authored-by: xternet <majewski.post@gmail.com> Co-authored-by: protolambda <proto@protolambda.com> Co-authored-by: Joshua Gutow <jgutow@optimism.io> Co-authored-by: Amir Hossein <77993374+Kamandlou@users.noreply.github.com> Co-authored-by: Nicholas <nicholas.zhaoyu@gmail.com> Co-authored-by: Nicholas Zhao <nicholas.zhao@gmail.com> Co-authored-by: Benjamin Prosnitz <bprosnitz@gmail.com> Co-authored-by: Nicolas Gotchac <ngotchac@gmail.com> Co-authored-by: pinkiebell <40266861+pinkiebell@users.noreply.github.com> Co-authored-by: George Carder <georgercarder@gmail.com> Co-authored-by: makcandrov <108467407+makcandrov@users.noreply.github.com> Co-authored-by: AtomicAzzaz <AtomicAzzaz@users.noreply.github.com> Co-authored-by: ewile <ewile@users.noreply.github.com> Co-authored-by: Boqin@MetaSecureLabs <Bobbqqin@gmail.com> Co-authored-by: Sebastian Stammler <stammler.s@gmail.com> Co-authored-by: omahs <73983677+omahs@users.noreply.github.com> Co-authored-by: Leon <316032931@qq.com> Co-authored-by: meowsbits <b5c6@protonmail.com> Co-authored-by: Janko Simonovic <simonovic86@gmail.com> Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com> Co-authored-by: lmittmann <lmittmann@users.noreply.github.com> Co-authored-by: TY <45994721+tylerK1294@users.noreply.github.com> Co-authored-by: ty <ty@oncoder.com> Co-authored-by: Ceyhun Onur <ceyhun.onur@avalabs.org> Co-authored-by: Mikhail Vazhnov <michael.vazhnov@gmail.com> Co-authored-by: susannapaxos <86749396+susannapaxos@users.noreply.github.com>
blakehhuynh
pushed a commit
to blakehhuynh/go-ethereum
that referenced
this pull request
Oct 7, 2022
* core, trie, eth, cmd: rework preimage store * trie: address comment
blakehhuynh
pushed a commit
to blakehhuynh/go-ethereum
that referenced
this pull request
Oct 7, 2022
* core, trie, eth, cmd: rework preimage store * trie: address comment
gitteri
pushed a commit
to paxosglobal/go-ethereum
that referenced
this pull request
Oct 10, 2022
* tests/fuzzers/bls12381: fix blst deserializing (ethereum#25036) * tests/fuzzers/bls12381: fix blst deserializing * tests/fuzzers/bls12381: fix blst deserializing * cmd/geth, core/state/snapshot: rework journal loading, implement account-check (ethereum#24765) * cmd/geth, core/state/snapshot: rework journal loading, implement account-check * core/state/snapshot, cmd/geth: polish code (ethereum#37) * core/state/snapshot: minor nits * core/state/snapshot: simplify error logic * cmd/geth: go format Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * all: introduce trie owner notion (ethereum#24750) * cmd, core/state, light, trie, eth: add trie owner notion * all: refactor * tests: fix goimports * core/state/snapshot: fix ineffasigns Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/api: use `hexutil.Bytes` for account range method (ethereum#25024) eth/api: use hexutil.Bytes for range at methods * eth/tracers: fix typo in 4byte_tracer_legacy.js (ethereum#25020) indentifier -> identifier * trie: move locking into trieDB insert method (ethereum#25030) Move locking into trieDB insert function * params: update ropsten terminal total difficulty block (ethereum#25018) * eth/filters: fix getLogs for pending block (ethereum#24949) * eth/filters: fix pending for getLogs * add pending method to test backend * fix block range validation * accounts/abi/bind: fix duplicate field names in the generated go struct (ethereum#24924) * accounts/abi/bind: fix duplicate field names in the generated go struct ethereum#24627 * accounts, cmd/abigen: resolve name conflicts * ci lint, accounts/abi: remove unused function overloadedArgName Co-authored-by: Gary Rong <garyrong0905@gmail.com> * tests/fuzzers/bls12381: fix blst pairing (ethereum#25037) * tests/fuzzers/bls12381: fix blst pairing * tests/fuzzers/bls12381: only build on gofuzz * tests/fuzzers/bls12381: remove unused code * tests/fuzzers/bls12381: remove unused code * p2p/discover: fix panicky test (ethereum#25038) * accounts: increase parseURL test coverage (ethereum#25033) accounts/url: add test logic what check null string to parseURL() * eth, les, params: log chain config a bit saner (ethereum#24904) Previously on Geth startup we just logged the chain config is a semi-json-y format. Whilst that worked while we had a handful of hard-forks defined, currently it's kind of unwieldy. This PR converts that original data dump and converts it into a user friendly - alas multiline - log output. * p2p: use errors.Is for error comparison (ethereum#24882) Co-authored-by: Felix Lange <fjl@twurst.com> * rpc: swap out timer metrics to histograms * eth/catalyst: remove unauthenticated 'engine' api (ethereum#24997) Removes engine from any unauthenticated RPC service. * core/types: remove unused field 'td' in Block (ethereum#25010) * core/types: improve LogForStorage and ReceiptForStorage comments (ethereum#25032) Co-authored-by: Felix Lange <fjl@twurst.com> * core/evm: fix error in comment (ethereum#25040) Co-authored-by: Martin Holst Swende <martin@swende.se> * internal/ethapi: fix typo in comment (ethereum#25056) typo error: keccack256 -> keccak256 * Chore: Minimal gramatical errors (signleton -> singleton) (ethereum#25057) core: fix typos * all: more linters (ethereum#24783) This enables the following linters - typecheck - unused - staticcheck - bidichk - durationcheck - exportloopref - gosec WIth a few exceptions. - We use a deprecated protobuf in trezor. I didn't want to mess with that, since I cannot meaningfully test any changes there. - The deprecated TypeMux is used in a few places still, so the warning for it is silenced for now. - Using string type in context.WithValue is apparently wrong, one should use a custom type, to prevent collisions between different places in the hierarchy of callers. That should be fixed at some point, but may require some attention. - The warnings for using weak random generator are squashed, since we use a lot of random without need for cryptographic guarantees. * cmd/utils: update --ropsten description (ethereum#25078) * readme,eth: remove references to eth.wiki (ethereum#25086) * cmd/ethkey: use accounts.TextHash (ethereum#25069) * common: improve pretty duration regex (ethereum#25073) * common: improve pretty duration regex * common: improve pretty duration regex * all: prefer `new(big.Int)` over `big.NewInt(0)` (ethereum#25087) minor performance improvement: `big.NewInt(0).Xxx` -> `new(big.Int).Xxx` * eth: add missing period at end of sentences (ethereum#25058) eth: add missing periods on end of comments * eth: introduce eth67 protocol (ethereum#24093) The new protocol version removes support for GetNodeData. See https://eips.ethereum.org/EIPS/eip-4938 for more information. Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd, params: implement Gray Glacier hard-fork (EIP-5133) (ethereum#25088) * cmd/geth, params: implement Gray Glacier (EIP-5133) * cmd/evm: add gray glacier tests * params: nitpicks * params: fixes * node: add info message when JWT secret is loaded (ethereum#25095) Co-authored-by: Felix Lange <fjl@twurst.com> * params: release Geth v1.10.19 * params: begin v1.10.20 release cycle * internal/ethapi: add comment explaining return of nil instead of error (ethereum#25097) Co-authored-by: Felix Lange <fjl@twurst.com> * tests/fuzzers/rlp: avoid very large input (ethereum#25109) The oss-fuzz engine crashes due to stack overflow decoding a large nested structure into a interface{}. This PR limits the size of the input data, so should avoid such crashes. * node: make jwt tests less time-dependent (ethereum#25120) * cmd/faucet: more verbose message about private posts (ethereum#25129) * cmd/faucet: Add error message for private posts Fixes ethereum#22631 * grammar * internal/ethapi: remove SignAndSendTransaction (ethereum#25111) * cmd/faucet: add sepolia network support (ethereum#25128) cmd/faucet: Add Sepolia network support to faucet * trie: fix size accounting in cleaner (ethereum#25007) Decrease children size instead of dirties size when marking dirties as cleaned up in trie cleaner * all: remove concept of public/private API definitions (ethereum#25053) * internal/ethapi: rename PublicEthereumAPI to EthereumAPI * eth: rename PublicEthereumAPI to EthereumAPI * internal/ethapi: rename PublicTxPoolAPI to TxPoolAPI * internal/ethapi: rename PublicAccountAPI to EthereumAccountAPI * internal/ethapi: rename PrivateAccountAPI to PersonalAccountAPI * internal/ethapi: rename PublicBlockChainAPI to BlockChainAPI * internal/ethapi: rename PublicTransactionPoolAPI to TransactionAPI * internal/ethapi: rename PublicDebugAPI to DebugAPI * internal/ethapi: move PrivateDebugAPI methods to DebugAPI * internal/ethapi: rename PublicNetAPI to NetAPI * les: rename PrivateLightServerAPI to LightServerAPI * les: rename PrivateLightAPI to LightAPI * les: rename PrivateDebugAPI to DebugAPI * les: rename PublicDownloaderAPI to DownloaderAPI * eth,les: rename PublicFilterAPI to FilterAPI * eth: rename PublicMinerAPI to MinerAPI * eth: rename PublicDownloaderAPI to DownloaderAPI * eth: move PrivateMinerAPI methods to MinerAPI * eth: rename PrivateAdminAPI to AdminAPI * eth: rename PublicDebugAPI to DebugAPI * eth: move PrivateDebugAPI methods to DebugAPI * node: rename publicAdminAPI to adminAPI * node: move privateAdminAPI methods to adminAPI * node: rename publicWeb3API to web3API * eth,internal/ethapi: sync comments with previous renamings * cmd/geth: drop geth js command (ethereum#25000) * cmd/geth: drop js command * cmd: simplify ipc path determination for attach * Add deprecation warning for js * rm testdata for exec * fix account unlock test cases * Update cmd/geth/consolecmd.go Co-authored-by: Martin Holst Swende <martin@swende.se> * fix Co-authored-by: Martin Holst Swende <martin@swende.se> * README,rpc: remove mention of "shh" RPC API (ethereum#25137) * eth, miner: retrieve mining state from live database (ethereum#25139) * miner: retrieve mining state from live database * eth/catalyst: ignore stale fcu events from cl * core: fix typo in txpool (ethereum#25149) Fix typo in txPool truncateQueue comment * go.mod: upgrade to latest goleveldb (ethereum#25067) Co-authored-by: Felix Lange <fjl@twurst.com> * eth/tracers: optimize goja buffer conversion (ethereum#25156) This changes the []byte <-> Uint8Array conversion to use an ArrayBuffer, avoiding inefficient copying of the slice data in Goja. Co-authored-by: Felix Lange <fjl@twurst.com> * eth: fix typo (ethereum#25161) * internal/ethapi: always return chain id (ethereum#25166) The error was introduced in PR ethereum#21686, but there is no good reason to enforce sync in this method, and it causes issues with EL/CL integration. * internal/ethapi: add note about eth_chainId compatibility with EIP-695 (ethereum#25168) Co-authored-by: Felix Lange <fjl@twurst.com> * all: remove `public` field from `rpc.API` (ethereum#25059) all: remove public field from rpc.API * cmd: migrate to urfave/cli/v2 (ethereum#24751) This change updates our urfave/cli dependency to the v2 branch of the library. There are some Go API changes in cli v2: - Flag values can now be accessed using the methods ctx.Bool, ctx.Int, ctx.String, ... regardless of whether the flag is 'local' or 'global'. - v2 has built-in support for flag categories. Our home-grown category system is removed and the categories of flags are assigned as part of the flag definition. For users, there is only one observable difference with cli v2: flags must now strictly appear before regular arguments. For example, the following command is now invalid: geth account import mykey.json --password file.txt Instead, the command must be invoked as follows: geth account import --password file.txt mykey.json * params: set TTD for sepolia testnet (ethereum#25179) * cmd/geth, p2p: add support for custom discovery UDP port (ethereum#24979) This adds a new flag to set the discovery port to be different from the TCP listener port. Co-authored-by: Felix Lange <fjl@twurst.com> * fix: linter warning (ethereum#25192) * core/rawdb: fix typo in comment (ethereum#25191) * core/rawdb: simplify TestDiskSeek to use memorydb (ethereum#25182) * cmd/utils: fix applying bootstrap nodes from config file (ethereum#25174) * internal/ethapi: return chain id for EIP-155 legacy txs (ethereum#25155) * common: increase StorageSize test coverage (ethereum#25188) * consensus/beacon: check that only the latest pow block is valid ttd block (ethereum#25187) * consensus/beacon: check that only the latest pow block is valid ttd block * consensus/beacon: move verification to async function * consensus/beacon: fix verifyTerminalPoWBlock, add test cases * consensus/beacon: cosmetic changes * consensus/beacon: apply karalabe's fixes * build: fix auto-completion scripts and include them in .deb package (ethereum#25195) Co-authored-by: Felix Lange <fjl@twurst.com> * build: upgrade to golangci-lint v1.46.2 (ethereum#25202) This upgrade is required to fix lint issues with urfave/cli/v2, which uses generics when built with Go 1.18 * build/deb: fix auto-completion install paths (ethereum#25204) * params: go-ethereum v1.10.20 stable * params: begin v1.10.21 release cycle * common/prque: fix typo * eth/catalyst: disallow importing blocks via newPayload during snap sync (ethereum#25210) * eth/catalyst: disallow importing blocks via newPayload during snap sync * eth/catalyst: make tests pass by using full sync only * eth/catalysts: make the import delay a bit cleaner * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * Replace fmt.Errorf with errors.New in abi argument (ethereum#25181) Replace unnecessary fmt.Errorf with errors.New in accounts/abi/argument.go * all: change format `0x%x` to `%#x` (ethereum#25221) * consensus/beacon: copy td value so we can modify it (ethereum#25230) * consensus/beacon: copy td value so we can modify it * consensus/beacon: copy td value so we can modify it * core: allow external code to set the block validator for malicious tests (ethereum#25119) * core: don't validate state * core: allow external validator * core: revert * core: comments * Update blockchain_reader.go * core: move SetValidator to blockchain.go * core: rename method * core: apply ttd override to uninitialized db (ethereum#25136) * core: apply ttd override to genesis block * core: apply overrides properly * signer/core/apitypes: support primitive types int96/uint96 (ethereum#25105) I have a EIP712 typehash using uint96, but it's currently not supported by go-ethereum. This change fixes it. * cmd/geth, cmd/devp2p: fix some cli parsing issues (ethereum#25234) * cmd/geth: add some missing argument count checks * internal/flags: skip cmds with no action func in MigrateGlobalFlags * internal/flags: add Merge * cmd/devp2p: re-add listener config flags in discv4 commands * core: allow external processor (ethereum#25233) * consensus/beacon: verify timestamp is greater than parent timestamp (ethereum#25236) * go.mod: updated logfmt dependency (ethereum#25231) This fixes an issue in abigen tests with go 1.17. * internal/ethapi: add basefee to block overrides (ethereum#25219) * trie: fix typo in comment (ethereum#25241) paralallel -> parallel * core/types: fix typo in comment (ethereum#25249) * internal/ethapi: fix chain ID check to return all non-zero IDs (ethereum#25244) * rpc: add graceful shutdown timeout for HTTP server (ethereum#25258) This change ensures the HTTP server will always terminate within at most 5s, even when all connections are busy and do not become idle. Co-authored-by: Felix Lange <fjl@twurst.com> * p2p/discover: fix typos in comments (ethereum#25272) * build: upgrade -dlgo version to Go 1.18.3 * core, eth: pre-allocate map in storage copy (ethereum#25279) * eth/tracers: add initial revertReasonTracer tracer (ethereum#25265) Adds a native tracer that returns that in case of failure returns the error message or the revert reason of a transaction. Co-authored-by: Martin Holst Swende <martin@swende.se> * params: enable DNS discovery on Sepolia too * internal/build: add a timestamp to the tar archive folder * build: upgrade -dlgo version to Go 1.18.4 * accounts/abi: fix typo in comment (ethereum#25271) * accounts/abi/bind/backends: return hash of new blocks (ethereum#25163) Co-authored-by: Jens <jmw.1906@gmx.de> * all: remove version field from rpc.API * internal/ethapi: error if tx args includes chain id that doesn't match local (ethereum#25157) * internal/ethapi: error if tx args includes chain id that doesn't match local * internal/ethapi: simplify code a bit Co-authored-by: Péter Szilágyi <peterke@gmail.com> * core: remove lock in BlockChain.ExportN (ethereum#25254) * Remove locking in (*BlockChain).ExportN Since ExportN is read-only, it shouldn't need the lock. (?) * Add hash check to detect reorgs during export. * fix check order * Update blockchain.go * Update blockchain.go Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * core: prevent negative fee during RPC calls (ethereum#25214) During RPC calls such as eth_call and eth_estimateGas, st.evm.Config.NoBaseFee is set which allows the gas price to be below the base fee. This results the tip being negative, and balance being subtracted from the coinbase instead of added to it, which results in a potentially negative coinbase balance interestingly. This can't happen during normal chain processing as outside of RPC calls the gas price is required to be at least the base fee, as NoBaseFee is false. This change prevents this behavior by disabling fee payment when the fee is not set. Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> * core, les, eth: port snap sync changes (ethereum#24898) core, eth, les, trie: rework snap sync * tests: only activate merge on london rules (ethereum#25239) * trie: fix 'gosimple' lint issue (ethereum#25309) * p2p/discover: apply netrestrict in discv5 response handler (ethereum#25304) * cmd/geth: remove redundant 0x in dbGet/dbDelete (ethereum#25315) * accounts/abi: substitude arg%d to the range keyword (ethereum#25307) * accounts/abi: substitude arg%d to the range keyword * support more keywords * review feedback * params: Add Shanghai and Cancun blocks (ethereum#25305) * params: Add Shangai and Cancun blocks * fix copy/paste error Co-authored-by: Martin Holst Swende <martin@swende.se> * fix typo in Shanghai name Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd/puppeth: remove support for exporting non-Geth genesis configurations (ethereum#25329) * cmd/puppeth: remove support for exporting non-Geth genesis configurations * remove unused function * params: set goerli TTD to 10_790_000 (ethereum#25324) * signer/core: add canonical TypedData hashing methods (ethereum#25283) * params: set sepolia mergeNetsplitBlock to 1735371 (ethereum#25372) * cmd/geth: eth/catalyst: enable authrpc by default (ethereum#25152) * cmd/geth: eth/catalyst: enable authrpc by default * eth/catalyst: rename catalyst -> Engine API in logs * eth/catalyst: don't panic * deps: update goleveldb * eth/catalyst: better warning for ttd not configured (ethereum#25394) * cmd: use flags.Merge for grouping flags (ethereum#25392) * consensus/beacon: fix typo in comment (ethereum#25391) * p2p/netutil: minor code cosmetic Signed-off-by: Abirdcfly <fp544037857@gmail.com> * eth, internal, light: fix error string capitalization (ethereum#25364) * light: fix differTries err message in tests (ethereum#25358) * all: add whitespace linter (ethereum#25312) * golangci: typo Signed-off-by: Delweng <delweng@gmail.com> * golangci: add whietspace Signed-off-by: Delweng <delweng@gmail.com> * *: rm whitesapce using golangci-lint Signed-off-by: Delweng <delweng@gmail.com> * cmd/puppeth: revert accidental resurrection Co-authored-by: Péter Szilágyi <peterke@gmail.com> * eth/tracers/js: fix capitalization in tests * eth: support bubbling up bad blocks from sync to the engine API (ethereum#25190) * eth: support bubbling up bad blocks from sync to the engine API * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * Update eth/catalyst/api.go * eth/catalyst: when forgetting bad hashes, also forget descendants * eth/catalyst: minor bad block tweaks for resilience Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Martin Holst Swende <martin@swende.se> * params: change Merge config to print simpler message This fixes ethereum#25366 * core: eth: rpc: implement safe rpc block (ethereum#25165) * core: eth: rpc: implement safe rpc block * core: fix setHead, panics * go.mod: downgrade leveldb (ethereum#25413) * params: go-ethereum v1.10.21 stable * params: begin v1.10.22 release cycle * core, trie, eth, cmd: rework preimage store (ethereum#25287) * core, trie, eth, cmd: rework preimage store * trie: address comment * eth/catalyst: fix NewPayload warn log when dropping due to snap sync * node: set JWT expiry to 60 seconds (ethereum#25416) * node: set JWT expiry to 60 seconds * node: rename var * eth/catalyst: return syncing not accepted (ethereum#25414) * eth/catalyst: return syncing not accepted * eth/catalyst: fix test * eth/catalyst: return 0x0 if latestvalid is pow block (ethereum#25423) * eth/catalyst: return 0x0 if latestvalid is pow block * eth/catalyst: return 0x0 if latestvalid is pow block * eth/catalyst: fix header retrieval, fix sign check Co-authored-by: Péter Szilágyi <peterke@gmail.com> * ethereum, ethclient: add FeeHistory support (ethereum#25403) Co-authored-by: Felix Lange <fjl@twurst.com> * all: use AbsTime.Add instead of conversion (ethereum#25417) * cm/puppeth: fix crash when of ethstats specifier doesn't contain `:` (ethereum#25405) Signed-off-by: Delweng <delweng@gmail.com> * eth: fix typo in comment (ethereum#25327) * common/compiler: json unmarshalling error checks (ethereum#25449) complier/solidity:add json.Unmarshal err check * cmd, core, eth, les, params: add merge-passed chain config (ethereum#24538) * cmd, core, eth, les, params: add merge-passed chain config * eth/catalyst, params: add various warning on malfunctioning beacons * eth/catalyst: fix warning for beacons without transition exchanges * eth: fix typo in catalyst api (ethereum#25460) eth: fix typo * eth/gasprice/feehistory: support finalized block (ethereum#25442) * build: upgrade -dlgo version to Go 1.18.5 * consensus/ethash: remove temp files created during DAG generation (ethereum#25381) This makes it remove not only the actual DAG file, but also the temporary file which the DAG data is written to while generating. * cmd/devp2p/internal/ethtest: update tests for eth/67 (ethereum#25306) * node, rpc: add ReadHeaderTimeout config option (ethereum#25338) This change makes http.Server.ReadHeaderTimeout configurable separately from ReadTimeout for RPC servers. The default is set to the same as ReadTimeout, which in order to cause no change in existing deployments. * core/types: fix typo in comment (ethereum#25359) * core: preallocate batch size in bloomIndexer (ethereum#25289) This change reduces allocations when committing bloombits indexes by creating the database batch with a larger initial size. * internal/ethapi: don't estimate gas if no limit provided in eth_createAccessList (ethereum#25467) Because the goal of eth_createAccessList is providing the caller with the largest-possible access list, it's generally not important that the gas limit used by the tracer will match the usage of the call exactly. Avoiding the gas estimation step is a performance improvement. As long as the call does not branch based on gas limit, the returned access list will be accurate. * graphql: embed *Resolver instead of backend interface (ethereum#25468) This creates some infrastructure to share resources between graphql API objects. * node: remove noop path.Join (ethereum#25475) Signed-off-by: Delweng <delweng@gmail.com> * core, trie: rework trie committer (ethereum#25320) * all: rework trie and trie committer * all: get rid of internal cache in trie * all: fixes * trie: polish * core, trie: address comments * trie: fix imports * core/state: address comments * core/state/snapshot: polish * trie: remove unused code * trie: update tests * trie: don't set db as nil * trie: address comments * trie: unskip test * core: use TryGetAccount to read what TryUpdateAccount has written (ethereum#25458) * core: use TryGetAccount to read where TryUpdateAccount has been used to write * Gary's review feedback * implement Gary's suggestion * fix bug + rename NewSecure into NewStateTrie * trie: add backwards-compatibility aliases for SecureTrie * Update database.go * make the linter happy Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * cmd, core, ethdb, node: move chain freezer one folder deeper (ethereum#25487) * cmd, core, ethdb, node: create chain freezer in a sub folder * core/rawdb: remove unused code * core, ethdb, node: add AncientDatadir API back * cmd, core: extend freezer info dump for sub-ancient-store * core/rawdb: rework freezer inspector * core/rawdb: address comments from Peter * core/rawdb: fix build issue * eth/downloader: fix log errors of queue_test.go (ethereum#25494) * core: fix uncle creation in TestFastVsFullChains (ethereum#25476) Co-authored-by: Felix Lange <fjl@twurst.com> * eth: formatted error nit (ethereum#25499) * eth/tracers: add onlyTopCall option to callTracer (ethereum#25430) This PR allows users to pass in a config object directly to the tracers. Previously only the struct logger was configurable. It also adds an option to the call tracer which if enabled makes it ignore any subcall and collect only information about the top-level call. See ethereum#25419 for discussion. The tracers will silently ignore if they are passed a config they don't care about. * all: cleanup the APIs for initializing genesis (ethereum#25473) * all: polish tests * core: apply feedback from Guillaume * core: fix comment * signer/rules: register clef api properly when rules are used (ethereum#25455) signer/rules: register clef api properly when rules are used, fixes ethereum#25298 * core: remove unused bc ChainContext in applyTransaction * build: add static linking support (ethereum#25492) This adds support for building statically-linked executables using ci.go. Static linking is enabled by default in Docker builds, making it possible to use the geth executable in any Docker image, regardless of the Linux distribution the Dockerfile is based on. Co-authored-by: Felix Lange <fjl@twurst.com> * accounts/abi: display name in "method/event not found" error (ethereum#25512) * internal/ethapi: rework setDefaults for tx args so fee logic is separate (ethereum#25197) Co-authored-by: bobpkr <bob.p@krustuniverse.com> * core/genesis: remove calaverasAllocData (ethereum#25516) core/genesis: calaverasAllocData no longer used * params: set ttdpassed on goerli (ethereum#25519) * params: set mainnet terminal total difficulty for the merge (ethereum#25528) * params: set mainnet ttd to 58_750_000_000_000_000_000_000 * params: set mainnet ttd to 58_750_000_000_000_000_000_000 * core, trie: flush preimages to db on blockchain close (ethereum#25533) * core, trie: flush preimages to db on database close Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * rename Close to CommitPreimages for clarity * core, trie: nitpick fixes Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> * core/state, trie, light: add a TryDeleteAccount method (ethereum#25531) * core/state, trie, light: Add a DeleteAccount method * review feedback * Update database.go * pr triage feedback Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * core: make tx journal check and open atomic (ethereum#25530) * core: reduce system call about `os` * avoid deprecated method * cmd. core: save preimages on genesis creation (ethereum#25538) force preimage dump for genesis * rlp/rlpgen: fix error handling when target type not found (ethereum#25547) typ will be nil when lookupStructType returns an error. cfg.Type should be used instead. * trie: improve node rlp decoding performance (ethereum#25357) This avoids copying the input []byte while decoding trie nodes. In most cases, particularly when the input slice is provided by the underlying database, this optimization is safe to use. For cases where the origin of the input slice is unclear, the copying version is retained. The new code performs better even when the input must be copied, because it is now only copied once in decodeNode. * all: fix some typos (ethereum#25551) * Fix some typos * Fix some mistakes * Revert 4byte.json * Fix an incorrect fix * Change files to fails * internal/ethapi: fix comment typo (ethereum#25548) * accounts/abi/bind/backends: typo fix (ethereum#25549) * eth, les: unlock downloader peerSet if there's an error (ethereum#25546) Unlock peerSet if there's an error in the downloader * cmd/geth: parse uint64 value with ParseUint instead of Atoi (ethereum#25545) Parse uint64 value with ParseUint instead of Atoi * consensus/beacon: check ttd reached on pos blocks (ethereum#25552) * consensus/beacon: check ttd reached on pos blocks * consensus/beacon: check ttd reached on pos blocks * consensus/beacon: check ttd reached on pos blocks * eth/filters: add global block logs cache (ethereum#25459) This adds a cache for block logs which is shared by all filters. The cache size of is configurable using the `--cache.blocklogs` flag. Co-authored-by: Felix Lange <fjl@twurst.com> * accounts/abi: fix set function (ethereum#25477) * accounts/abi: fix set function * don't break things * update test * internal/ethapi: fix build regression (ethereum#25555) * eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524) * eth/fetcher: introduce some lag in tx fetching * eth/fetcher: change conditions a bit * eth/fetcher: use per-batch quota check * eth/fetcher: fix some comments * eth/fetcher: address review concerns * eth/fetcher: fix panic + add warn log * eth/fetcher: fix log * eth/fetcher: fix log * cmd/devp2p/internal/ethtest: fix ignorign tx announcements from prev. tests * cmd/devp2p/internal/ethtest: fix TestLargeTxRequest This increases the number of tx relay messages the test waits for. Since go-ethereum now processes incoming txs in smaller batches, the announcement messages it sends are also smaller. Co-authored-by: Felix Lange <fjl@twurst.com> * Revert "eth/fetcher: don't spend too much time on transaction inclusion" (ethereum#25567) Revert "eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524)" This reverts commit 0ce494b. * eth/catalyst: warn less frequently if no beacon client is available (ethereum#25569) * eth/catalyst: warn less frequently if no beacon client is available * eth/catalyst: tweak warning frequency a bit * eth/catalyst: some more tweaks * Update api.go Co-authored-by: Felix Lange <fjl@twurst.com> * params: release go-ethereum v1.10.22 * params: begin v1.10.23 release cycle * core, eth/downloader: handle spurious junk bodies from racey rollbacks (ethereum#25578) * eth/downloader: handle junkbodies/receipts in the beacon sync * core: check for header presence when checking for blocks * core/state, trie: fix trie flush order for proper pruning * consensus/beacon: don't ignore errors * params: release Geth v1.10.23 * graphql: return correct logs for tx (ethereum#25612) * graphql: fix tx logs * minor * Use optimized search for selecting tx logs * graphql: fixes missing tx logs (ethereum#25745) * graphql: fix tx logs * graphql: refactor test service setup * graphql: add test for tx logs * Release Geth v1.10.24 * params: set TerminalTotalDifficultyPassed to true (ethereum#25769) * params: set TerminalTotalDifficultyPassed to true * Update params/config.go Co-authored-by: Martin Holst Swende <martin@swende.se> * params: release Geth v1.10.25 Signed-off-by: Abirdcfly <fp544037857@gmail.com> Signed-off-by: Delweng <delweng@gmail.com> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: Ikko Ashimine <eltociear@gmail.com> Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com> Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: lwh <lwhile521@gmail.com> Co-authored-by: Seungbae.yu <72970043+dbadoy@users.noreply.github.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> Co-authored-by: Håvard Anda Estensen <haavard.ae@gmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Rajaram Gaunker <zimbabao@gmail.com> Co-authored-by: henridf <henri@dubfer.com> Co-authored-by: int88 <106391185+int88@users.noreply.github.com> Co-authored-by: Luozhu <70309026+LuozhuZhang@users.noreply.github.com> Co-authored-by: Gustavo Silva <GustavoRSSilva@users.noreply.github.com> Co-authored-by: Ivan Aracki <aracki.ivan@gmail.com> Co-authored-by: s7v7nislands <s7v7nislands@gmail.com> Co-authored-by: lmittmann <lmittmann@users.noreply.github.com> Co-authored-by: Kosuke Taniguchi <73885532+TaniguchiKosuke@users.noreply.github.com> Co-authored-by: Zachinquarantine <Zachinquarantine@protonmail.com> Co-authored-by: ucwong <ucwong@126.com> Co-authored-by: willian.eth <willian@ufpa.br> Co-authored-by: zeim839 <50573884+zeim839@users.noreply.github.com> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: Ruohui Wang <nomaru@outlook.com> Co-authored-by: Andre Patta <andre_luis@outlook.com> Co-authored-by: スパイク <1311798+spkjp@users.noreply.github.com> Co-authored-by: Brion <4777457+cifer76@users.noreply.github.com> Co-authored-by: Marius Kjærstad <mkjaerstad@protonmail.com> Co-authored-by: Philip Fan <fanwengang@hotmail.com> Co-authored-by: Jens W <8270201+DragonDev1906@users.noreply.github.com> Co-authored-by: Jens <jmw.1906@gmx.de> Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: henridf <henridf@gmail.com> Co-authored-by: Lee Bousfield <ljbousfield@gmail.com> Co-authored-by: Ha ĐANG <dvietha@gmail.com> Co-authored-by: jwasinger <j-wasinger@hotmail.com> Co-authored-by: Nikhil Suri <nikhilsuri@comcast.net> Co-authored-by: Abirdcfly <fp544037857@gmail.com> Co-authored-by: Eval EXEC <execvy@gmail.com> Co-authored-by: Delweng <delweng@gmail.com> Co-authored-by: Rithwik Babu <rithwikbabu2020@gmail.com> Co-authored-by: Henry <101552941+henry-0@users.noreply.github.com> Co-authored-by: Manoj Kumar <mnjkmr398@gmail.com> Co-authored-by: Tristan-Wilson <87238672+Tristan-Wilson@users.noreply.github.com> Co-authored-by: yong <33920876+yzhaoyu@users.noreply.github.com> Co-authored-by: Seungbae Yu <dbadoy4874@gmail.com> Co-authored-by: ycyraum <ycyraum@fastmail.com> Co-authored-by: 0xe3b0c4 <110295932+0xe3b0c4@users.noreply.github.com> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: bobpkr <bob.p@krustuniverse.com> Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Co-authored-by: zhiqiangxu <652732310@qq.com>
0xTomoyo
pushed a commit
to 0xTomoyo/go-ethereum
that referenced
this pull request
Dec 12, 2022
* params: begin v1.10.19 release cycle * cmd/geth: exit when freezer has legacy receipts (ethereum#24943) In ethereum#24028 we flagged a warning when finding legacy receipts in the freezer. This PR nudges users a bit more strongly by preventing geth from starting in this case until receipts have been migrated. It also adds a flag --ignore-legacy-receipts which when present allows geth to start normally. * cmd/abigen: accept combined-json via stdin (ethereum#24960) * params: set emergency ropsten TTD to 100_000_000_000_000_000_000_000 (ethereum#24975) * core: use less memory during reorgs (ethereum#24616) This PR significantly reduces the memory consumption of a long reorg * cmd/geth: extend traverseRawState command (ethereum#24954) This PR adds node verification into traverseRawState command, so corrupted trie nodes can also be detected. * consensus/clique: fix race condition (ethereum#24957) * consensus/clique: remove race condition * consensus/clique: fix one more signer data race Co-authored-by: Gary Rong <garyrong0905@gmail.com> * eth/catalyst: fix edge case in NewPayload (ethereum#24955) Fixes an issue where we would accept a NewPayload where the grandparent is already post ttd, and the parent still has a Difficulty * contracs/checkpointoracle: fix directives (ethereum#24944) contracts/checkpointoracle: redefine go-generate logic * eth/filters: use buffered channel to avoid goroutine leak (ethereum#24928) * core/beacon: prevent invalid logsBloom length panic (ethereum#24946) * core/beacon: prevent invalid logsBloom length panic * core/beacon: prevent negative baseFeePerGas * Update core/beacon/types.go Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/catalys: go format Co-authored-by: Martin Holst Swende <martin@swende.se> * core: fix canonical hash marker update (ethereum#24996) * core: fix reorg * core: revert change for memory efficiency * core: revert changes * eth/tracers: add support for block overrides in debug_traceCall (ethereum#24871) This PR adds support for block overrides when doing debug_traceCall. - Previously, debug_traceCall against pending erroneously used a common.Hash{} stateroot when looking up the state, meaning that a totally empty state was used -- so it always failed, - With this change, we reject executing debug_traceCall against pending. - And we add ability to override all evm-visible header fields. * tests/fuzzers/bls12381: Add BLST to fuzzing support (ethereum#24249) * tests/fuzzers/bls12381: added blst library * go.mod: added blst dependency * tests/fuzzers/bls12381: stuff * tests/fuzzers/bls12381: added blst to pairing fuzzer * eth/catalyst: return 0x0 on Invalid block on top of pow block (ethereum#25006) * node: make jwt test less dependent on time (ethereum#25016) * consensus/misc: reduce allocations and improve comments in CalcBaseFee (ethereum#24958) * consensus/misc: reduce allocations in CalcBaseFee * consensus/misc: add formulas of CalcBaseFee * go.mod: set go version to 1.17 (ethereum#24926) set go version to 1.17 * go.mod: clean up (ethereum#25017) * core/vm: optimize jumpdest analysis (ethereum#23500) core/vm: optimize PUSH opcode discrimination * tests/fuzzers/bls12381: fix blst deserializing (ethereum#25036) * tests/fuzzers/bls12381: fix blst deserializing * tests/fuzzers/bls12381: fix blst deserializing * cmd/geth, core/state/snapshot: rework journal loading, implement account-check (ethereum#24765) * cmd/geth, core/state/snapshot: rework journal loading, implement account-check * core/state/snapshot, cmd/geth: polish code (ethereum#37) * core/state/snapshot: minor nits * core/state/snapshot: simplify error logic * cmd/geth: go format Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * all: introduce trie owner notion (ethereum#24750) * cmd, core/state, light, trie, eth: add trie owner notion * all: refactor * tests: fix goimports * core/state/snapshot: fix ineffasigns Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/api: use `hexutil.Bytes` for account range method (ethereum#25024) eth/api: use hexutil.Bytes for range at methods * eth/tracers: fix typo in 4byte_tracer_legacy.js (ethereum#25020) indentifier -> identifier * trie: move locking into trieDB insert method (ethereum#25030) Move locking into trieDB insert function * params: update ropsten terminal total difficulty block (ethereum#25018) * eth/filters: fix getLogs for pending block (ethereum#24949) * eth/filters: fix pending for getLogs * add pending method to test backend * fix block range validation * accounts/abi/bind: fix duplicate field names in the generated go struct (ethereum#24924) * accounts/abi/bind: fix duplicate field names in the generated go struct ethereum#24627 * accounts, cmd/abigen: resolve name conflicts * ci lint, accounts/abi: remove unused function overloadedArgName Co-authored-by: Gary Rong <garyrong0905@gmail.com> * tests/fuzzers/bls12381: fix blst pairing (ethereum#25037) * tests/fuzzers/bls12381: fix blst pairing * tests/fuzzers/bls12381: only build on gofuzz * tests/fuzzers/bls12381: remove unused code * tests/fuzzers/bls12381: remove unused code * p2p/discover: fix panicky test (ethereum#25038) * accounts: increase parseURL test coverage (ethereum#25033) accounts/url: add test logic what check null string to parseURL() * eth, les, params: log chain config a bit saner (ethereum#24904) Previously on Geth startup we just logged the chain config is a semi-json-y format. Whilst that worked while we had a handful of hard-forks defined, currently it's kind of unwieldy. This PR converts that original data dump and converts it into a user friendly - alas multiline - log output. * p2p: use errors.Is for error comparison (ethereum#24882) Co-authored-by: Felix Lange <fjl@twurst.com> * rpc: swap out timer metrics to histograms * eth/catalyst: remove unauthenticated 'engine' api (ethereum#24997) Removes engine from any unauthenticated RPC service. * core/types: remove unused field 'td' in Block (ethereum#25010) * core/types: improve LogForStorage and ReceiptForStorage comments (ethereum#25032) Co-authored-by: Felix Lange <fjl@twurst.com> * core/evm: fix error in comment (ethereum#25040) Co-authored-by: Martin Holst Swende <martin@swende.se> * internal/ethapi: fix typo in comment (ethereum#25056) typo error: keccack256 -> keccak256 * Chore: Minimal gramatical errors (signleton -> singleton) (ethereum#25057) core: fix typos * all: more linters (ethereum#24783) This enables the following linters - typecheck - unused - staticcheck - bidichk - durationcheck - exportloopref - gosec WIth a few exceptions. - We use a deprecated protobuf in trezor. I didn't want to mess with that, since I cannot meaningfully test any changes there. - The deprecated TypeMux is used in a few places still, so the warning for it is silenced for now. - Using string type in context.WithValue is apparently wrong, one should use a custom type, to prevent collisions between different places in the hierarchy of callers. That should be fixed at some point, but may require some attention. - The warnings for using weak random generator are squashed, since we use a lot of random without need for cryptographic guarantees. * cmd/utils: update --ropsten description (ethereum#25078) * readme,eth: remove references to eth.wiki (ethereum#25086) * cmd/ethkey: use accounts.TextHash (ethereum#25069) * common: improve pretty duration regex (ethereum#25073) * common: improve pretty duration regex * common: improve pretty duration regex * all: prefer `new(big.Int)` over `big.NewInt(0)` (ethereum#25087) minor performance improvement: `big.NewInt(0).Xxx` -> `new(big.Int).Xxx` * eth: add missing period at end of sentences (ethereum#25058) eth: add missing periods on end of comments * eth: introduce eth67 protocol (ethereum#24093) The new protocol version removes support for GetNodeData. See https://eips.ethereum.org/EIPS/eip-4938 for more information. Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd, params: implement Gray Glacier hard-fork (EIP-5133) (ethereum#25088) * cmd/geth, params: implement Gray Glacier (EIP-5133) * cmd/evm: add gray glacier tests * params: nitpicks * params: fixes * node: add info message when JWT secret is loaded (ethereum#25095) Co-authored-by: Felix Lange <fjl@twurst.com> * params: release Geth v1.10.19 * params: begin v1.10.20 release cycle * internal/ethapi: add comment explaining return of nil instead of error (ethereum#25097) Co-authored-by: Felix Lange <fjl@twurst.com> * tests/fuzzers/rlp: avoid very large input (ethereum#25109) The oss-fuzz engine crashes due to stack overflow decoding a large nested structure into a interface{}. This PR limits the size of the input data, so should avoid such crashes. * node: make jwt tests less time-dependent (ethereum#25120) * cmd/faucet: more verbose message about private posts (ethereum#25129) * cmd/faucet: Add error message for private posts Fixes ethereum#22631 * grammar * internal/ethapi: remove SignAndSendTransaction (ethereum#25111) * cmd/faucet: add sepolia network support (ethereum#25128) cmd/faucet: Add Sepolia network support to faucet * trie: fix size accounting in cleaner (ethereum#25007) Decrease children size instead of dirties size when marking dirties as cleaned up in trie cleaner * all: remove concept of public/private API definitions (ethereum#25053) * internal/ethapi: rename PublicEthereumAPI to EthereumAPI * eth: rename PublicEthereumAPI to EthereumAPI * internal/ethapi: rename PublicTxPoolAPI to TxPoolAPI * internal/ethapi: rename PublicAccountAPI to EthereumAccountAPI * internal/ethapi: rename PrivateAccountAPI to PersonalAccountAPI * internal/ethapi: rename PublicBlockChainAPI to BlockChainAPI * internal/ethapi: rename PublicTransactionPoolAPI to TransactionAPI * internal/ethapi: rename PublicDebugAPI to DebugAPI * internal/ethapi: move PrivateDebugAPI methods to DebugAPI * internal/ethapi: rename PublicNetAPI to NetAPI * les: rename PrivateLightServerAPI to LightServerAPI * les: rename PrivateLightAPI to LightAPI * les: rename PrivateDebugAPI to DebugAPI * les: rename PublicDownloaderAPI to DownloaderAPI * eth,les: rename PublicFilterAPI to FilterAPI * eth: rename PublicMinerAPI to MinerAPI * eth: rename PublicDownloaderAPI to DownloaderAPI * eth: move PrivateMinerAPI methods to MinerAPI * eth: rename PrivateAdminAPI to AdminAPI * eth: rename PublicDebugAPI to DebugAPI * eth: move PrivateDebugAPI methods to DebugAPI * node: rename publicAdminAPI to adminAPI * node: move privateAdminAPI methods to adminAPI * node: rename publicWeb3API to web3API * eth,internal/ethapi: sync comments with previous renamings * cmd/geth: drop geth js command (ethereum#25000) * cmd/geth: drop js command * cmd: simplify ipc path determination for attach * Add deprecation warning for js * rm testdata for exec * fix account unlock test cases * Update cmd/geth/consolecmd.go Co-authored-by: Martin Holst Swende <martin@swende.se> * fix Co-authored-by: Martin Holst Swende <martin@swende.se> * README,rpc: remove mention of "shh" RPC API (ethereum#25137) * eth, miner: retrieve mining state from live database (ethereum#25139) * miner: retrieve mining state from live database * eth/catalyst: ignore stale fcu events from cl * core: fix typo in txpool (ethereum#25149) Fix typo in txPool truncateQueue comment * go.mod: upgrade to latest goleveldb (ethereum#25067) Co-authored-by: Felix Lange <fjl@twurst.com> * eth/tracers: optimize goja buffer conversion (ethereum#25156) This changes the []byte <-> Uint8Array conversion to use an ArrayBuffer, avoiding inefficient copying of the slice data in Goja. Co-authored-by: Felix Lange <fjl@twurst.com> * eth: fix typo (ethereum#25161) * internal/ethapi: always return chain id (ethereum#25166) The error was introduced in PR ethereum#21686, but there is no good reason to enforce sync in this method, and it causes issues with EL/CL integration. * internal/ethapi: add note about eth_chainId compatibility with EIP-695 (ethereum#25168) Co-authored-by: Felix Lange <fjl@twurst.com> * all: remove `public` field from `rpc.API` (ethereum#25059) all: remove public field from rpc.API * all: remove version field from rpc.API * cmd: migrate to urfave/cli/v2 (ethereum#24751) This change updates our urfave/cli dependency to the v2 branch of the library. There are some Go API changes in cli v2: - Flag values can now be accessed using the methods ctx.Bool, ctx.Int, ctx.String, ... regardless of whether the flag is 'local' or 'global'. - v2 has built-in support for flag categories. Our home-grown category system is removed and the categories of flags are assigned as part of the flag definition. For users, there is only one observable difference with cli v2: flags must now strictly appear before regular arguments. For example, the following command is now invalid: geth account import mykey.json --password file.txt Instead, the command must be invoked as follows: geth account import --password file.txt mykey.json * params: set TTD for sepolia testnet (ethereum#25179) * cmd/geth, p2p: add support for custom discovery UDP port (ethereum#24979) This adds a new flag to set the discovery port to be different from the TCP listener port. Co-authored-by: Felix Lange <fjl@twurst.com> * fix: linter warning (ethereum#25192) * core/rawdb: fix typo in comment (ethereum#25191) * core/rawdb: simplify TestDiskSeek to use memorydb (ethereum#25182) * cmd/utils: fix applying bootstrap nodes from config file (ethereum#25174) * internal/ethapi: return chain id for EIP-155 legacy txs (ethereum#25155) * common: increase StorageSize test coverage (ethereum#25188) * consensus/beacon: check that only the latest pow block is valid ttd block (ethereum#25187) * consensus/beacon: check that only the latest pow block is valid ttd block * consensus/beacon: move verification to async function * consensus/beacon: fix verifyTerminalPoWBlock, add test cases * consensus/beacon: cosmetic changes * consensus/beacon: apply karalabe's fixes * build: fix auto-completion scripts and include them in .deb package (ethereum#25195) Co-authored-by: Felix Lange <fjl@twurst.com> * build: upgrade to golangci-lint v1.46.2 (ethereum#25202) This upgrade is required to fix lint issues with urfave/cli/v2, which uses generics when built with Go 1.18 * build/deb: fix auto-completion install paths (ethereum#25204) * params: go-ethereum v1.10.20 stable * params: begin v1.10.21 release cycle * common/prque: fix typo * eth/catalyst: disallow importing blocks via newPayload during snap sync (ethereum#25210) * eth/catalyst: disallow importing blocks via newPayload during snap sync * eth/catalyst: make tests pass by using full sync only * eth/catalysts: make the import delay a bit cleaner * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * Replace fmt.Errorf with errors.New in abi argument (ethereum#25181) Replace unnecessary fmt.Errorf with errors.New in accounts/abi/argument.go * all: change format `0x%x` to `%#x` (ethereum#25221) * consensus/beacon: copy td value so we can modify it (ethereum#25230) * consensus/beacon: copy td value so we can modify it * consensus/beacon: copy td value so we can modify it * core: allow external code to set the block validator for malicious tests (ethereum#25119) * core: don't validate state * core: allow external validator * core: revert * core: comments * Update blockchain_reader.go * core: move SetValidator to blockchain.go * core: rename method * core: apply ttd override to uninitialized db (ethereum#25136) * core: apply ttd override to genesis block * core: apply overrides properly * signer/core/apitypes: support primitive types int96/uint96 (ethereum#25105) I have a EIP712 typehash using uint96, but it's currently not supported by go-ethereum. This change fixes it. * cmd/geth, cmd/devp2p: fix some cli parsing issues (ethereum#25234) * cmd/geth: add some missing argument count checks * internal/flags: skip cmds with no action func in MigrateGlobalFlags * internal/flags: add Merge * cmd/devp2p: re-add listener config flags in discv4 commands * core: allow external processor (ethereum#25233) * consensus/beacon: verify timestamp is greater than parent timestamp (ethereum#25236) * go.mod: updated logfmt dependency (ethereum#25231) This fixes an issue in abigen tests with go 1.17. * internal/ethapi: add basefee to block overrides (ethereum#25219) * build: upgrade -dlgo version to Go 1.18.3 * trie: fix typo in comment (ethereum#25241) paralallel -> parallel * core/types: fix typo in comment (ethereum#25249) * internal/ethapi: fix chain ID check to return all non-zero IDs (ethereum#25244) * rpc: add graceful shutdown timeout for HTTP server (ethereum#25258) This change ensures the HTTP server will always terminate within at most 5s, even when all connections are busy and do not become idle. Co-authored-by: Felix Lange <fjl@twurst.com> * p2p/discover: fix typos in comments (ethereum#25272) * core, eth: pre-allocate map in storage copy (ethereum#25279) * eth/tracers: add initial revertReasonTracer tracer (ethereum#25265) Adds a native tracer that returns that in case of failure returns the error message or the revert reason of a transaction. Co-authored-by: Martin Holst Swende <martin@swende.se> * params: enable DNS discovery on Sepolia too * internal/build: add a timestamp to the tar archive folder * build: upgrade -dlgo version to Go 1.18.4 * accounts/abi: fix typo in comment (ethereum#25271) * accounts/abi/bind/backends: return hash of new blocks (ethereum#25163) Co-authored-by: Jens <jmw.1906@gmx.de> * internal/ethapi: error if tx args includes chain id that doesn't match local (ethereum#25157) * internal/ethapi: error if tx args includes chain id that doesn't match local * internal/ethapi: simplify code a bit Co-authored-by: Péter Szilágyi <peterke@gmail.com> * core: remove lock in BlockChain.ExportN (ethereum#25254) * Remove locking in (*BlockChain).ExportN Since ExportN is read-only, it shouldn't need the lock. (?) * Add hash check to detect reorgs during export. * fix check order * Update blockchain.go * Update blockchain.go Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * core: prevent negative fee during RPC calls (ethereum#25214) During RPC calls such as eth_call and eth_estimateGas, st.evm.Config.NoBaseFee is set which allows the gas price to be below the base fee. This results the tip being negative, and balance being subtracted from the coinbase instead of added to it, which results in a potentially negative coinbase balance interestingly. This can't happen during normal chain processing as outside of RPC calls the gas price is required to be at least the base fee, as NoBaseFee is false. This change prevents this behavior by disabling fee payment when the fee is not set. Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> * core, les, eth: port snap sync changes (ethereum#24898) core, eth, les, trie: rework snap sync * tests: only activate merge on london rules (ethereum#25239) * trie: fix 'gosimple' lint issue (ethereum#25309) * p2p/discover: apply netrestrict in discv5 response handler (ethereum#25304) * cmd/geth: remove redundant 0x in dbGet/dbDelete (ethereum#25315) * accounts/abi: substitude arg%d to the range keyword (ethereum#25307) * accounts/abi: substitude arg%d to the range keyword * support more keywords * review feedback * params: Add Shanghai and Cancun blocks (ethereum#25305) * params: Add Shangai and Cancun blocks * fix copy/paste error Co-authored-by: Martin Holst Swende <martin@swende.se> * fix typo in Shanghai name Co-authored-by: Martin Holst Swende <martin@swende.se> * params: change Merge config to print simpler message This fixes ethereum#25366 * cmd/puppeth: remove support for exporting non-Geth genesis configurations (ethereum#25329) * cmd/puppeth: remove support for exporting non-Geth genesis configurations * remove unused function * params: set goerli TTD to 10_790_000 (ethereum#25324) * signer/core: add canonical TypedData hashing methods (ethereum#25283) * deps: update goleveldb * params: set sepolia mergeNetsplitBlock to 1735371 (ethereum#25372) * cmd/geth: eth/catalyst: enable authrpc by default (ethereum#25152) * cmd/geth: eth/catalyst: enable authrpc by default * eth/catalyst: rename catalyst -> Engine API in logs * eth/catalyst: don't panic * eth/catalyst: better warning for ttd not configured (ethereum#25394) * cmd: use flags.Merge for grouping flags (ethereum#25392) * consensus/beacon: fix typo in comment (ethereum#25391) * p2p/netutil: minor code cosmetic Signed-off-by: Abirdcfly <fp544037857@gmail.com> * eth, internal, light: fix error string capitalization (ethereum#25364) * light: fix differTries err message in tests (ethereum#25358) * all: add whitespace linter (ethereum#25312) * golangci: typo Signed-off-by: Delweng <delweng@gmail.com> * golangci: add whietspace Signed-off-by: Delweng <delweng@gmail.com> * *: rm whitesapce using golangci-lint Signed-off-by: Delweng <delweng@gmail.com> * cmd/puppeth: revert accidental resurrection Co-authored-by: Péter Szilágyi <peterke@gmail.com> * eth/tracers/js: fix capitalization in tests * eth: support bubbling up bad blocks from sync to the engine API (ethereum#25190) * eth: support bubbling up bad blocks from sync to the engine API * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * Update eth/catalyst/api.go * eth/catalyst: when forgetting bad hashes, also forget descendants * eth/catalyst: minor bad block tweaks for resilience Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Martin Holst Swende <martin@swende.se> * core: eth: rpc: implement safe rpc block (ethereum#25165) * core: eth: rpc: implement safe rpc block * core: fix setHead, panics * go.mod: downgrade leveldb (ethereum#25413) * params: go-ethereum v1.10.21 stable * params: begin v1.10.22 release cycle * core, trie, eth, cmd: rework preimage store (ethereum#25287) * core, trie, eth, cmd: rework preimage store * trie: address comment * eth/catalyst: fix NewPayload warn log when dropping due to snap sync * node: set JWT expiry to 60 seconds (ethereum#25416) * node: set JWT expiry to 60 seconds * node: rename var * eth/catalyst: return syncing not accepted (ethereum#25414) * eth/catalyst: return syncing not accepted * eth/catalyst: fix test * eth/catalyst: return 0x0 if latestvalid is pow block (ethereum#25423) * eth/catalyst: return 0x0 if latestvalid is pow block * eth/catalyst: return 0x0 if latestvalid is pow block * eth/catalyst: fix header retrieval, fix sign check Co-authored-by: Péter Szilágyi <peterke@gmail.com> * ethereum, ethclient: add FeeHistory support (ethereum#25403) Co-authored-by: Felix Lange <fjl@twurst.com> * all: use AbsTime.Add instead of conversion (ethereum#25417) * cm/puppeth: fix crash when of ethstats specifier doesn't contain `:` (ethereum#25405) Signed-off-by: Delweng <delweng@gmail.com> * eth: fix typo in comment (ethereum#25327) * common/compiler: json unmarshalling error checks (ethereum#25449) complier/solidity:add json.Unmarshal err check * cmd, core, eth, les, params: add merge-passed chain config (ethereum#24538) * cmd, core, eth, les, params: add merge-passed chain config * eth/catalyst, params: add various warning on malfunctioning beacons * eth/catalyst: fix warning for beacons without transition exchanges * eth: fix typo in catalyst api (ethereum#25460) eth: fix typo * build: upgrade -dlgo version to Go 1.18.5 * eth/gasprice/feehistory: support finalized block (ethereum#25442) * consensus/ethash: remove temp files created during DAG generation (ethereum#25381) This makes it remove not only the actual DAG file, but also the temporary file which the DAG data is written to while generating. * cmd/devp2p/internal/ethtest: update tests for eth/67 (ethereum#25306) * node, rpc: add ReadHeaderTimeout config option (ethereum#25338) This change makes http.Server.ReadHeaderTimeout configurable separately from ReadTimeout for RPC servers. The default is set to the same as ReadTimeout, which in order to cause no change in existing deployments. * core/types: fix typo in comment (ethereum#25359) * core: preallocate batch size in bloomIndexer (ethereum#25289) This change reduces allocations when committing bloombits indexes by creating the database batch with a larger initial size. * internal/ethapi: don't estimate gas if no limit provided in eth_createAccessList (ethereum#25467) Because the goal of eth_createAccessList is providing the caller with the largest-possible access list, it's generally not important that the gas limit used by the tracer will match the usage of the call exactly. Avoiding the gas estimation step is a performance improvement. As long as the call does not branch based on gas limit, the returned access list will be accurate. * graphql: embed *Resolver instead of backend interface (ethereum#25468) This creates some infrastructure to share resources between graphql API objects. * node: remove noop path.Join (ethereum#25475) Signed-off-by: Delweng <delweng@gmail.com> * core, trie: rework trie committer (ethereum#25320) * all: rework trie and trie committer * all: get rid of internal cache in trie * all: fixes * trie: polish * core, trie: address comments * trie: fix imports * core/state: address comments * core/state/snapshot: polish * trie: remove unused code * trie: update tests * trie: don't set db as nil * trie: address comments * trie: unskip test * core: use TryGetAccount to read what TryUpdateAccount has written (ethereum#25458) * core: use TryGetAccount to read where TryUpdateAccount has been used to write * Gary's review feedback * implement Gary's suggestion * fix bug + rename NewSecure into NewStateTrie * trie: add backwards-compatibility aliases for SecureTrie * Update database.go * make the linter happy Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * cmd, core, ethdb, node: move chain freezer one folder deeper (ethereum#25487) * cmd, core, ethdb, node: create chain freezer in a sub folder * core/rawdb: remove unused code * core, ethdb, node: add AncientDatadir API back * cmd, core: extend freezer info dump for sub-ancient-store * core/rawdb: rework freezer inspector * core/rawdb: address comments from Peter * core/rawdb: fix build issue * eth/downloader: fix log errors of queue_test.go (ethereum#25494) * core: fix uncle creation in TestFastVsFullChains (ethereum#25476) Co-authored-by: Felix Lange <fjl@twurst.com> * eth: formatted error nit (ethereum#25499) * eth/tracers: add onlyTopCall option to callTracer (ethereum#25430) This PR allows users to pass in a config object directly to the tracers. Previously only the struct logger was configurable. It also adds an option to the call tracer which if enabled makes it ignore any subcall and collect only information about the top-level call. See ethereum#25419 for discussion. The tracers will silently ignore if they are passed a config they don't care about. * all: cleanup the APIs for initializing genesis (ethereum#25473) * all: polish tests * core: apply feedback from Guillaume * core: fix comment * core: remove unused bc ChainContext in applyTransaction * signer/rules: register clef api properly when rules are used (ethereum#25455) signer/rules: register clef api properly when rules are used, fixes ethereum#25298 * build: add static linking support (ethereum#25492) This adds support for building statically-linked executables using ci.go. Static linking is enabled by default in Docker builds, making it possible to use the geth executable in any Docker image, regardless of the Linux distribution the Dockerfile is based on. Co-authored-by: Felix Lange <fjl@twurst.com> * accounts/abi: display name in "method/event not found" error (ethereum#25512) * internal/ethapi: rework setDefaults for tx args so fee logic is separate (ethereum#25197) Co-authored-by: bobpkr <bob.p@krustuniverse.com> * core/genesis: remove calaverasAllocData (ethereum#25516) core/genesis: calaverasAllocData no longer used * params: set ttdpassed on goerli (ethereum#25519) * params: set mainnet terminal total difficulty for the merge (ethereum#25528) * params: set mainnet ttd to 58_750_000_000_000_000_000_000 * params: set mainnet ttd to 58_750_000_000_000_000_000_000 * core, trie: flush preimages to db on blockchain close (ethereum#25533) * core, trie: flush preimages to db on database close Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * rename Close to CommitPreimages for clarity * core, trie: nitpick fixes Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> * core/state, trie, light: add a TryDeleteAccount method (ethereum#25531) * core/state, trie, light: Add a DeleteAccount method * review feedback * Update database.go * pr triage feedback Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * core: make tx journal check and open atomic (ethereum#25530) * core: reduce system call about `os` * avoid deprecated method * cmd. core: save preimages on genesis creation (ethereum#25538) force preimage dump for genesis * rlp/rlpgen: fix error handling when target type not found (ethereum#25547) typ will be nil when lookupStructType returns an error. cfg.Type should be used instead. * trie: improve node rlp decoding performance (ethereum#25357) This avoids copying the input []byte while decoding trie nodes. In most cases, particularly when the input slice is provided by the underlying database, this optimization is safe to use. For cases where the origin of the input slice is unclear, the copying version is retained. The new code performs better even when the input must be copied, because it is now only copied once in decodeNode. * all: fix some typos (ethereum#25551) * Fix some typos * Fix some mistakes * Revert 4byte.json * Fix an incorrect fix * Change files to fails * internal/ethapi: fix comment typo (ethereum#25548) * accounts/abi/bind/backends: typo fix (ethereum#25549) * eth, les: unlock downloader peerSet if there's an error (ethereum#25546) Unlock peerSet if there's an error in the downloader * cmd/geth: parse uint64 value with ParseUint instead of Atoi (ethereum#25545) Parse uint64 value with ParseUint instead of Atoi * consensus/beacon: check ttd reached on pos blocks (ethereum#25552) * consensus/beacon: check ttd reached on pos blocks * consensus/beacon: check ttd reached on pos blocks * consensus/beacon: check ttd reached on pos blocks * eth/filters: add global block logs cache (ethereum#25459) This adds a cache for block logs which is shared by all filters. The cache size of is configurable using the `--cache.blocklogs` flag. Co-authored-by: Felix Lange <fjl@twurst.com> * accounts/abi: fix set function (ethereum#25477) * accounts/abi: fix set function * don't break things * update test * internal/ethapi: fix build regression (ethereum#25555) * eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524) * eth/fetcher: introduce some lag in tx fetching * eth/fetcher: change conditions a bit * eth/fetcher: use per-batch quota check * eth/fetcher: fix some comments * eth/fetcher: address review concerns * eth/fetcher: fix panic + add warn log * eth/fetcher: fix log * eth/fetcher: fix log * cmd/devp2p/internal/ethtest: fix ignorign tx announcements from prev. tests * cmd/devp2p/internal/ethtest: fix TestLargeTxRequest This increases the number of tx relay messages the test waits for. Since go-ethereum now processes incoming txs in smaller batches, the announcement messages it sends are also smaller. Co-authored-by: Felix Lange <fjl@twurst.com> * Revert "eth/fetcher: don't spend too much time on transaction inclusion" (ethereum#25567) Revert "eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524)" This reverts commit 0ce494b. * eth/catalyst: warn less frequently if no beacon client is available (ethereum#25569) * eth/catalyst: warn less frequently if no beacon client is available * eth/catalyst: tweak warning frequency a bit * eth/catalyst: some more tweaks * Update api.go Co-authored-by: Felix Lange <fjl@twurst.com> * params: release go-ethereum v1.10.22 * params: begin v1.10.23 release cycle * core, eth/downloader: handle spurious junk bodies from racey rollbacks (ethereum#25578) * eth/downloader: handle junkbodies/receipts in the beacon sync * core: check for header presence when checking for blocks * core/state, trie: fix trie flush order for proper pruning * consensus/beacon: don't ignore errors * params: release Geth v1.10.23 * graphql: return correct logs for tx (ethereum#25612) * graphql: fix tx logs * minor * Use optimized search for selecting tx logs * graphql: fixes missing tx logs (ethereum#25745) * graphql: fix tx logs * graphql: refactor test service setup * graphql: add test for tx logs * Release Geth v1.10.24 * params: set TerminalTotalDifficultyPassed to true (ethereum#25769) * params: set TerminalTotalDifficultyPassed to true * Update params/config.go Co-authored-by: Martin Holst Swende <martin@swende.se> * params: release Geth v1.10.25 * eth/protocols/snap: fix problems due to idle-but-busy peers (ethereum#25651) * eth/protocols/snap: throttle trie heal requests when peers DoS us (ethereum#25666) * eth/protocols/snap: throttle trie heal requests when peers DoS us * eth/protocols/snap: lower heal throttle log to debug Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/protocols/snap: fix comment Co-authored-by: Martin Holst Swende <martin@swende.se> * trie: check childrens' existence concurrently for snap heal (ethereum#25694) * eth: fix a rare datarace on CHT challenge reply / shutdown (ethereum#25831) * eth/filters: change filter block to be by-ref (ethereum#26054) This PR changes the block field in the filter to be a pointer, to disambiguate between empty hash and no hash * rpc: handle wrong HTTP batch response length (ethereum#26064) * params: release geth v1.10.26 stable Signed-off-by: Abirdcfly <fp544037857@gmail.com> Signed-off-by: Delweng <delweng@gmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: Harry Kalodner <harry.kalodner@gmail.com> Co-authored-by: Boqin Qin(秦 伯钦) <Bobbqqin@gmail.com> Co-authored-by: Ivan Kuznetsov <me@jeiwan.ru> Co-authored-by: Jonathan Le Brun <42697488+icyfry@users.noreply.github.com> Co-authored-by: s7v7nislands <s7v7nislands@gmail.com> Co-authored-by: Paweł Bylica <chfast@gmail.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: Ikko Ashimine <eltociear@gmail.com> Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com> Co-authored-by: lwh <lwhile521@gmail.com> Co-authored-by: Seungbae.yu <72970043+dbadoy@users.noreply.github.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> Co-authored-by: Håvard Anda Estensen <haavard.ae@gmail.com> Co-authored-by: Rajaram Gaunker <zimbabao@gmail.com> Co-authored-by: henridf <henri@dubfer.com> Co-authored-by: int88 <106391185+int88@users.noreply.github.com> Co-authored-by: Luozhu <70309026+LuozhuZhang@users.noreply.github.com> Co-authored-by: Gustavo Silva <GustavoRSSilva@users.noreply.github.com> Co-authored-by: Ivan Aracki <aracki.ivan@gmail.com> Co-authored-by: lmittmann <lmittmann@users.noreply.github.com> Co-authored-by: Kosuke Taniguchi <73885532+TaniguchiKosuke@users.noreply.github.com> Co-authored-by: Zachinquarantine <Zachinquarantine@protonmail.com> Co-authored-by: ucwong <ucwong@126.com> Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: willian.eth <willian@ufpa.br> Co-authored-by: zeim839 <50573884+zeim839@users.noreply.github.com> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: Ruohui Wang <nomaru@outlook.com> Co-authored-by: Andre Patta <andre_luis@outlook.com> Co-authored-by: スパイク <1311798+spkjp@users.noreply.github.com> Co-authored-by: Marius Kjærstad <mkjaerstad@protonmail.com> Co-authored-by: Brion <4777457+cifer76@users.noreply.github.com> Co-authored-by: Philip Fan <fanwengang@hotmail.com> Co-authored-by: Jens W <8270201+DragonDev1906@users.noreply.github.com> Co-authored-by: Jens <jmw.1906@gmx.de> Co-authored-by: henridf <henridf@gmail.com> Co-authored-by: Lee Bousfield <ljbousfield@gmail.com> Co-authored-by: Ha ĐANG <dvietha@gmail.com> Co-authored-by: jwasinger <j-wasinger@hotmail.com> Co-authored-by: Nikhil Suri <nikhilsuri@comcast.net> Co-authored-by: Abirdcfly <fp544037857@gmail.com> Co-authored-by: Eval EXEC <execvy@gmail.com> Co-authored-by: Delweng <delweng@gmail.com> Co-authored-by: Rithwik Babu <rithwikbabu2020@gmail.com> Co-authored-by: Henry <101552941+henry-0@users.noreply.github.com> Co-authored-by: Manoj Kumar <mnjkmr398@gmail.com> Co-authored-by: Tristan-Wilson <87238672+Tristan-Wilson@users.noreply.github.com> Co-authored-by: yong <33920876+yzhaoyu@users.noreply.github.com> Co-authored-by: Seungbae Yu <dbadoy4874@gmail.com> Co-authored-by: ycyraum <ycyraum@fastmail.com> Co-authored-by: 0xe3b0c4 <110295932+0xe3b0c4@users.noreply.github.com> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: bobpkr <bob.p@krustuniverse.com> Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Co-authored-by: zhiqiangxu <652732310@qq.com> Co-authored-by: Jordan Krage <jmank88@gmail.com>
holiman
pushed a commit
that referenced
this pull request
Mar 23, 2023
With #25287 we made it so that preimages were not recorded by default. This had the side effect that the evm command is no longer able to dump state since it does a preimage lookup to determine the address represented by a key. This change enables the recording of preimages when the dump command is given.
gitteri
pushed a commit
to paxosglobal/go-ethereum
that referenced
this pull request
May 1, 2023
* cmd/bootnode, cmd/utils: add 'pmp:<IP>' to --nat flag description (ethereum#26381) * cmd/evm: fix typo in README.md (ethereum#26500) * build: upgrade -dlgo version to Go 1.19.5 (ethereum#26472) * cmd/evm: typo fix in docs (ethereum#26506) * metrics/influxdb: fix time ticker leaks (ethereum#26507) * eth/filters: fix typo in comment (ethereum#26515) * les/fetcher : fix requestTimer leak (ethereum#26514) les/fetcher : fix requestTimer leak * core/txpool: check if initcode size is exceeded (ethereum#26504) * core/txpool: check if initcode size is exceeded * core/txpool: move check * all: remove Kiln testnet (ethereum#26522) Kiln was deprecated after the merge. * console, internal/jsre: fix autocomplete issues (ethereum#26518) Fixes ethereum#26505 where the console crashed when a property getter raised an exception during autocompletion. I also noticed while fixing this issue that autocomplete wasn't working for objects/fields with numbers in them (most importantly web3.<tab><tab>) which is also now fixed. * go.mod: upgrade to go-bip39 v1.1.0 (ethereum#26527) * go.sum: tidy (ethereum#26525) * .travis.yml: go1.19.5 for android builds (ethereum#26524) * params: define cancun and prague as timestamp based forks (ethereum#26481) * params: define cancun and osaka as timestamp based forks * core, params: change osaka to prague * params: fix * signer/core: don't require capital lettered reference types (ethereum#26462) * miner, cmd, eth: require explicit etherbase address (ethereum#26413) This change introduces a breaking change to miner.etherbase is configured. Previously, users did not need to explicitly set the etherbase address via flag, since 'first' local account was used as etherbase automatically. This change removes the "default first account" feature. In Proof-of-stake world, the fee recipient address is provided by CL, and not configured in Geth any more - meaning that miner.etherbase is mostly for legacy networks(pow, clique networks etc). * go.mod: upgrade to latest goja (ethereum#26523) Co-authored-by: Felix Lange <fjl@twurst.com> * go.sum: go mod tidy (ethereum#26536) * all: use http package to replace http method names (ethereum#26535) * cmd/utils: improve parsing of --miner.etherbase address (ethereum#26541) This fixes a regression where the flag did not accept values without the 0x prefix anymore. What's worse, if an invalid value was passed, the client would just log an INFO level message and continue. * all: make timestamp-based fork checks based on uint64 (ethereum#26474) This PR changes the API so that uint64 is used for fork timestamps. It's a good choice because types.Header also uses uint64 for time. Co-authored-by: Felix Lange <fjl@twurst.com> * all: implement withdrawals (EIP-4895) (ethereum#26484) This change implements withdrawals as specified in EIP-4895. Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: marioevz <marioevz@gmail.com> Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Felix Lange <fjl@twurst.com> * cmd/utils: fix error at geth startup in --dev mode (ethereum#26550) This fixes a regression in ethereum#26541 where we turned the miner address being missing into a startup error. The address was not configured in --dev mode. * eth/catalyst: error on nil withdrawals post-shanghai (ethereum#26549) This adds explicit checks for the presence of withdrawals in the engine API. Co-authored-by: Felix Lange <fjl@twurst.com> * eth/catalyst: implement exchangeCapabilities method (ethereum#26555) Spec: ethereum/execution-apis#364 * params: fix timestamp display in fork banner (ethereum#26553) * params: remove deprecated bootnodes (ethereum#26530) This change removes the Infura rinkeby bootnode as well as two deprecated ropsten bootnodes. Co-authored-by: Nicola Cocchiaro <ncocchiaro@users.noreply.github.com> Co-authored-by: Martin Holst Swende <martin@swende.se> * go.mod: gnark-crypto upgrade (ethereum#26545) * cmd/evm: add blocktest subcommand to evm (ethereum#26526) Adds blocktest subcommand to the evm command, which is very similar to statetest, but instead of loading a StateTest static test it loads a BlockchainTest from a json file and runs it. Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * eth/catalyst: fix panic in TestWithdrawals (ethereum#26563) Fixes a regression introduced in ethereum#26549 * log: fix typo in comment (ethereum#26569) * cmd/devp2p: fix broken link in readme(ethereum#26576) fix broken link to DNS discovery tutorial * log: better sanitation (ethereum#26556) * ethclient/gethclient: fix typo (ethereum#26580) fix grammar typo * eth/tracer: rename to revertReason (ethereum#26574) * internal/ethapi: always return block withdrawals if present (ethereum#26565) The execution-apis specification says that the full list of withdrawals should always be returned when requesting a block over RPC: https://github.com/ethereum/execution-apis/blob/378c4304f75b5af2c9b5263c9c76b511e33e8984/src/schemas/block.yaml#L90-L94 This change adopts the expected behavior. * cmd/puppeth: remove puppeth * core: improve ambiguous block validation message (ethereum#26582) * eth/catalyst: return invalid params instead of invalid payload params (ethereum#26591) * cmd, eth, node: deprecate personal namespace (ethereum#26390) * eth: cmd: deprecate personal namespace * eth: cmd: move deprecation to node * node: disable toml of enablepersonal * node: disable personal on ipc as well * Update node/node.go Co-authored-by: Martin Holst Swende <martin@swende.se> * console: error -> warn * node: less roulette --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * accounts, build, mobile: remove Andriod and iOS support * core/vm: improve EVM instance reusability (ethereum#26341) This change improves reusability of the EVM struct. Two methods are added: - SetBlockContext(...) - SetTracer(...) Other attributes like the TransactionContext and the StateDB can already be updated. BlockContext and Tracer are partially not updateable right now. This change fixes it and opens the potential to reuse an EVM struct in more ways. Co-authored-by: Felix Lange <fjl@twurst.com> * eth/catalyst: implement engine_getPayloadBodiesByHash/Range methods (ethereum#26232) This change implements engine_getPayloadBodiesByHash and engine_getPayloadBodiesByRange, according to the specification at https://github.com/ethereum/execution-apis/blob/main/src/engine/shanghai.md#specification-4 . Co-authored-by: Martin Holst Swende <martin@swende.se> * readme: fix broken link (ethereum#26612) * rpc: fix off-by-one in ipc endpoint length check (ethereum#26614) This change fixes a minor flaw in the check for ipc endpoint length. The max_path_size is the max path that an ipc endpoint can have, which is 208. However, that size concerns the null-terminated pathname, so we need to account for an extra null-character too. * core/vm: add bn256ScalarMul testcase for zero scalar value (ethereum#26607) EIP-196 allows a zero value in the scalar argument to precompile `0x07`. This change adds a test for that case. * README: remove text about GPU mining (ethereum#26609) Co-authored-by: Felix Lange <fjl@twurst.com> * all: prepare for path-based trie storage (ethereum#26603) This PR moves some trie-related db accessor methods to a different file, and also removes the schema type. Instead of the schema type, a string is used to distinguish between hashbased/pathbased db accessors. This also moves some code from trie package to rawdb package. This PR is intended to be a no-functionality-change prep PR for ethereum#25963 . --------- Co-authored-by: Gary Rong <garyrong0905@gmail.com> * beacon/engine: move core/beacon to beacon/engine (ethereum#26616) This PR moves core/beacon to beacon/engine so that beacon-chain related code has its own top level package which also can house the the beacon lightclient-code. * build: upgrade to golangci-lint v1.51.1 (ethereum#26618) * tests: update (ethereum#26548) This updates the reference tests to the latest version. Co-authored-by: Felix Lange <fjl@twurst.com> * accounts/abi: fix integer encoding/decoding (ethereum#26568) This PR fixes this abi encoder/decoder to be more stringent. * rpc: remove DecimalOrHex type (ethereum#26629) It's the same as math.HexOrDecimal64, which has more uses across the codebase. * eth/catalyst,miner: include withdrawals in payload id calculation (ethereum#26554) According to the spec the payloadID needs to be random or dependent on all arguments, to prevent two payloads from clashing. This change adds withdrawals into the payload derivation. --------- Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Felix Lange <fjl@twurst.com> * light: fix receiver name from Python style to Go (ethereum#26631) Co-authored-by: Halil Yildirim <halilgolang@gmail.com> * log: allow tabs in log messages (ethereum#26630) * log: allow tabs in log messages This fixes a regression where panic reports in RPC handlers were quoted because they contain tab characters. * Update format.go * all: remove database commit callback, rework noderesolver (ethereum#26637) This change ports some changes from the main PBSS PR: - get rid of callback function in `trie.Database.Commit` which is not required anymore - rework the `nodeResolver` in `trie.Iterator` to make it compatible with multiple state scheme - some other shallow changes in tests and typo-fixes * eth/catalyst: make getPayloadBodiesByRange take hex inputs (ethereum#26624) Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * all: remove support for Ropsten (ethereum#26644) * ethdb: pebble backend (64bit platforms only) (ethereum#26517) * ethdb: use pebble Co-authored-by: Gary Rong <garyrong0905@gmail.com> foo update * apply suggested changes * flags: go format node: fix ddir lookup mistake accounts/abi/bind: fix go.mod replacement for generated binding deps: update pebble + with fix 32-bit build * ethdb/pebble: respect max memtable size * core/rawdb, ethdb: enable pebble on non-32bit platforms only * core/rawdb: fix build tags, fix some review concerns * core/rawdb: refactor methods for database opening * core/rawdb: remove erroneous build tag * cmd/geth: fix the flag default handling + testcase * cmd/geth: improve testing regarding custom backends * ethdb/pebble, deps: update pebble dependency * core/rawdb: replace method with Open * ethdb/pebble: several updates for pebble (ethereum#49) * ethdb/pebble: fix size count in batch * ethdb/pebble: disable seek compaction * ethdb/pebble: more fixes * ethdb, core, cmd: polish and fixes (ethereum#50) * cmd/utils, core/rawdb, ethdb/pebble: address some review concerns * Update flags.go * ethdb/pebble: minor refactors * ethdb/pebble: avoid copy on batch replay * ethdb: fix compilation flaw * cmd: fix test fail due to mismatching error message * cmd/geth, node: rename backingdb to db.engine --------- Co-authored-by: Jared Wasinger <j-wasinger@hotmail.com> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> * eth/catalyst: disallow forkchoiceupdate v1 post-shanghai (ethereum#26645) * common/prque: generic priority queue (ethereum#26290) * common, core, eth, les, trie: make prque generic * les/vflux/server: fixed issues in priorityPool * common, core, eth, les, trie: make priority also generic in prque * les/flowcontrol: add test case for priority accumulator overflow * les/flowcontrol: avoid priority value overflow * common/prque: use int priority in some tests No need to convert to int64 when we can just change the type used by the queue. * common/prque: remove comment about int64 range --------- Co-authored-by: Zsolt Felfoldi <zsfelfoldi@gmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> * ethdb/pebble: fix nil callbacks (ethereum#26650) * eth/downloader: fix timeout resurrection panic (ethereum#26652) * common/prque, eth/downloader: fix timeout resurrection panic * common/prque: revert -1 hack for les, temporaryly! * core/state, trie: remove unused error-return from trie Commit operation (ethereum#26641) * go.mod: update pebble to latest master (ethereum#26654) * core/vm: set tracer-observable `value` of a delegatecall to match parent `value` (ethereum#26632) This is a breaking change in the tracing hooks API as well as semantics of the callTracer: - CaptureEnter hook provided a nil value argument in case of DELEGATECALL. However to stay consistent with how delegate calls behave in EVM this hook is changed to pass in the value of the parent call. - callTracer will return parent call's value for DELEGATECALL frames. --------- Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> * ethdb: add benchmark test suite (ethereum#26659) * params: schedule shanghai fork on sepolia (ethereum#26662) * params: schedule shanghai fork on sepolia * params: u64 -> newUint64 * eth/filters: avoid block body retrieval when no matching logs (ethereum#25199) Logs stored on disk have minimal information. Contextual information such as block number, index of log in block, index of transaction in block are filled in upon request. We can fill in all these fields only having the block header and list of receipts. But determining the transaction hash of a log requires the block body. The goal of this PR is postponing this retrieval until we are sure we the transaction hash. It happens often that the header bloom filter signals there might be matches in a block, but after actually checking them reveals the logs do not match. We want to avoid fetching the body in this case. Note that this changes the semantics of Backend.GetLogs. Downstream callers of GetLogs now assume log context fields have not been derived, and need to call DeriveFields on the logs if necessary. * eth/tracers: more fork overrides in traceBlockToFile (ethereum#26655) This change allows all post-Berlin forks to be specified as overrides for futureForkBlock in the config parameter for traceBlockToFile. * tests/fuzzers: supply gnark multiexp config, fixes ethereum#26669 (ethereum#26670) This change fixes a fuzzer which broke when we updated the gnark dependency earlier. * cmd/devp2p: reduce output of node crawler (ethereum#26674) Our discovery crawler spits out a huge amount of logs, most of which is pretty non-interesting. This change moves the very verbose output to Debug, and adds a 8-second status log message giving the general idea about what's going on. * params: update mainnet + rinkeby CHT (ethereum#26677) This change updates the CHT entries for mainnet and rinkeby * eth/filters: replace atomic pointer with value (ethereum#26689) * eth/filters: replace atomic.Pointer * fix * improve Co-authored-by: Martin Holst Swende <martin@swende.se> --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * p2p/dnsdisc: fix tests with Go 1.20 (ethereum#26690) * eth/catalyst: return error if withdrawals are nil post-shanghai (ethereum#26691) Spec: https://github.com/ethereum/execution-apis/blob/main/src/engine/shanghai.md#request * ethdb/pebble: Fix `MemTableStopWritesThreshold` (ethereum#26692) MemTableStopWritesThreshold was set to the max size of all memtables before blocking writing but should be set to the max number of memtables. This is documented [here](https://github.com/cockroachdb/pebble/blob/master/options.go#L738-L742). * eth/downloader: handle missing withdrawals if empty list is expected (ethereum#26675) This PR relaxes the block body ingress handling a bit: if block body withdrawals are missing (but expected to be empty), the body withdrawals are set to 'empty list' before being passed to upper layers. This fixes an issue where a block passed from EthereumJS to geth was deemed invalid. * params: go-ethereum v1.11.0 stable * params: begin v1.11.1 release cycle * travis, build: update Go to 1.20.1 (ethereum#26653) travis, build: update Go to 1.20 * core: check genesis state presence by disk read (ethereum#26703) * core, eth/downloader: make body validation more strict (ethereum#26704) * eth/downloader: fix empty-body case in queue fetchresult (ethereum#26707) * eth/downloader: fix typo (ethereum#26716) * all: remove deprecated uses of math.rand (ethereum#26710) This PR is a (superior) alternative to ethereum#26708, it handles deprecation, primarily two specific cases. `rand.Seed` is typically used in two ways - `rand.Seed(time.Now().UnixNano())` -- we seed it, just to be sure to get some random, and not always get the same thing on every run. This is not needed, with global seeding, so those are just removed. - `rand.Seed(1)` this is typically done to ensure we have a stable test. If we rely on this, we need to fix up the tests to use a deterministic prng-source. A few occurrences like this has been replaced with a proper custom source. `rand.Read` has been replaced by `crypto/rand`.`Read` in this PR. * params: go-ethereum v1.11.1 stable * params: begin v1.11.2 release cycle * eth/catalyst: send INVALID instead of INVALID_BLOCK_HASH (ethereum#26696) This change will break one hive test, but pass another and it will be the better way going forward * ci: disable coverage reporting in appveyor and travis * eth/catalyst: request too large error (ethereum#26722) The method `GetPayloadBodiesByRangeV1` now returns "-38004: Too large request" error if the requested range is too large, according to spec Co-authored-by: Martin Holst Swende <martin@swende.se> * core/trie: remove trie tracer (ethereum#26665) This PR contains a small portion of the full pbss PR, namely Remove the tracer from trie (and comitter), and instead using an accessList. Related changes to the Nodeset. --------- Co-authored-by: Gary Rong <garyrong0905@gmail.com> * rpc: fix unmarshaling of null result in CallContext (ethereum#26723) The change fixes unmarshaling of JSON null results into json.RawMessage. --------- Co-authored-by: Jason Yuan <jason.yuan@curvegrid.com> Co-authored-by: Jason Yuan <jason.yuan869@gmail.com> * build: ship bootstrapper Go along with builder for PPA (ethereum#26731) * build: fix setting env var, temp early exit * build: fix gobootstrap path for the PPA * build: add some PPA debug logs, sigh * internal/build: revert raising the chunk size for PPA * build: yet another weird PPA fix * build: fix (finaly?) the PPA env vars for Go bootstrapping * build: fix Go 1.19.0 bootstrapper issues on 386 PPA * build: enable Lunar Lobster PPA builds * Revert "core/trie: remove trie tracer (ethereum#26665)" (ethereum#26732) This reverts commit 7c749c9. * cmd/geth: clarify dumpconfig options (ethereum#26729) Clarifies the documentation around dumpconfi Signed-off-by: Sungwoo Kim <git@sung-woo.kim> * core, eth: merge snap-sync chain download progress logs (ethereum#26676) * core: fix accessor mismatch for genesis state (ethereum#26747) * core/rawdb: expose chain freezer constructor without internals (ethereum#26748) * all: use unified emptyRootHash and emptyCodeHash (ethereum#26718) The EmptyRootHash and EmptyCodeHash are defined everywhere in the codebase, this PR replaces all of them with unified one defined in core/types package, and also defines constants for TxRoot, WithdrawalsRoot and UncleRoot * eth/filters: fix a breaking change and return rpctransaction (ethereum#26757) * eth/filters: fix a breaking change and return rpctransaction * eth/filters: fix test cases --------- Co-authored-by: Catror <me@catror.com> * common/math: allow HexOrDecimal to accept unquoted decimals too (ethereum#26758) * params: release Geth v1.11.2 * params: begin v.1.11.3 release cycle * log: improve documentation (ethereum#26753) Add usage examples * core/rawdb, node: use standalone flock dependency (ethereum#26633) * eth: use the last announced finalized block as the sync ancient limit (ethereum#26685) * cmd/devp2p: faster crawling + less verbose dns updates (ethereum#26697) This improves the speed of DHT crawling by using concurrent requests. It also removes logging of individual DNS updates. * eth/tracers: add native flatCallTracer (aka parity style tracer) (ethereum#26377) Adds support for a native call tracer with the Parity format, which outputs call frames in a flat array. This tracer accepts the following options: - `convertParityErrors: true` will convert error messages to match those of Parity - `includePrecompiles: true` will report all calls to precompiles. The default matches Parity's behavior where CALL and STATICCALLs to precompiles are excluded Incompatibilities with Parity include: - Parity removes the result object in case of failure. This behavior is maintained with the exception of reverts. Revert output usually contains useful information, i.e. Solidity revert reason. - The `gasUsed` field accounts for intrinsic gas (e.g. 21000 for simple transfers) and refunds unlike Parity - Block rewards are not reported Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> * core: improve withdrawal index assignment in GenerateChain (ethereum#26756) This fixes an issue where the withdrawal index was not calculated correctly for multiple withdrawals in a single block. Co-authored-by: Gary Rong <garyrong0905@gmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> * ethdb/pebble: fix range compaction (ethereum#26771) * ethdb/pebble: fix range compaction * ethdb/pebble: add comment * ethdb/pebble: fix max memorytable size (ethereum#26776) * ethclient: include withdrawals in ethclient block responses (ethereum#26778) * include withdrawals in ethclient responses * omit empty withdrawals array in json serialization * all: change chain head markers from block to header (ethereum#26777) * core/rawdb, ethdb/pebble: disable pebble on openbsd (ethereum#26801) * core: fix a merge fault (ethereum#26802) * README, go.mod, event, internal/version: bump min Go to 1.19 (ethereum#26803) * travi: remove strange leftover Go version * core, params: schedule Shanghai on goerli (ethereum#26795) * core: params: schedule Shanghai on goerli * core/forkid: fix comment * eth: remove admin.peers[i].eth.head and difficulty (ethereum#26804) * core/types: add EffectiveGasPrice in Receipt (ethereum#26713) This change adds a struct field EffectiveGasPrice in types.Receipt. The field is present in RPC responses, but not in the Go struct, and thus can't easily be accessed via ethclient. Co-authored-by: PulsarAI <dev@pulsar-systems.fi> * core, eth/catalyst: fix race conditions in tests (ethereum#26790) Fixes a race in TestNewPayloadOnInvalidTerminalBlock where setting the TTD raced with the miner. Solution: set the TTD on the blockchain config not the genesis config. Also fixes a race in CopyHeader which resulted in race reports all over the place. * metrics: improve accuracy of CPU gauges (ethereum#26793) This PR changes metrics collection to actually measure the time interval between collections, rather than assume 3 seconds. I did some ad hoc profiling, and on slower hardware (eg, my Raspberry Pi 4) I routinely saw intervals between 3.3 - 3.5 seconds, with some being as high as 4.5 seconds. This will generally cause the CPU gauge readings to be too high, and in some cases can cause impossibly large values for the CPU load metrics (eg. greater than 400 for a 4 core CPU). --------- Co-authored-by: Felix Lange <fjl@twurst.com> * ethclient: fix panic when requesting missing blocks (ethereum#26817) This fixes a regression introduced by ethereum#26723. Fixes ethereum#26816. * core, miner: revert block gas counter in case of invalid transaction (ethereum#26799) This change fixes a flaw where, in certain scenarios, the block sealer did not accurately reset the remaining gas after failing to include an invalid transaction. Fixes ethereum#26791 * internal/ethapi: add tests for transaction types JSON marshal/unmarshal (ethereum#26667) Checks that Transaction.MarshalJSON and newRPCTransaction JSON output can be parsed by Transaction.UnmarshalJSON --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd/evm: correct `alloc` for `t8n` testdata (ethereum#26822) Fixes a minor error in the testdata * eth/tracers/native: set created address to nil in case of failure (ethereum#26779) Fixes ethereum#26073 * accounts/usbwallet: mitigate ledger app chunking issue (ethereum#26773) This PR mitigates an issue with Ledger's on-device RLP deserialization, see LedgerHQ/app-ethereum#409 Ledger's RLP deserialization code does not validate the length of the RLP list received, and it may prematurely enter the signing flow when a APDU chunk boundary falls immediately before the EIP-155 chain_id when deserializing a transaction. Since the chain_id is uninitialized, it is 0 during this signing flow. This may cause the user to accidentally sign the transaction with chain_id = 0. That signature would be returned from the device 1 packet earlier than expected by the communication loop. The device blocks the second-to-last packet waiting for the signer flow, and then errors on the successive packet (which contains the chain_id, zeroed r, and zeroed s) Since the signature's early arrival causes successive errors during the communication process, geth does not parse the improper signature produced by the device, and therefore no improperly-signed transaction can be created. User funds are not at risk. We mitigate by selecting the highest chunk size that leaves at least 4 bytes in the final chunk. * beacon/engine: don't omit empty withdrawals in ExecutionPayloadBodies (ethereum#26698) This ensures the "withdrawals" field will always be present in responses to getPayloadBodiesByRangeV1 and getPayloadBodiesByHashV1. --------- Co-authored-by: Felix Lange <fjl@twurst.com> * build: update to go 1.20.2 (ethereum#26824) * params: go-ethereum v1.11.3 stable * params: begin v1.11.4 release cycle * core/rawdb: find smallest block stored in key-value store when chain gapped (ethereum#26719) This change prints out more information about the problem, in the case where geth detects a gap between leveldb and ancients, so we can determine more exactly where the gap is (what the first missing is). Also prints out more metadata. --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * signer/core: accept all solidity primitive types for EIP-712 signing (ethereum#26770) Accept all primitive types in Solidity for EIP-712 from intN, uintN, intN[], uintN[] for N as 0 to 256 in multiples of 8 --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * params: remove EF azure bootnodes (ethereum#26828) * core/vm: use golang native big.Int (ethereum#26834) reverts ethereum#26021, to use the upstream bigint instead. * core/vm: fix typo in comment (ethereum#26838) fixes eip 220 -> 2200 * core/forkid: fix issue in validation test (ethereum#26544) This changes the test to match the comment description. Using timestampedConfig in this test case is incorrect, the comment says 'local is at Gray Glacier' and isn't aware of more forks. * cmd/evm: update readmes for the tests (ethereum#26841) * core, core/types: plain Message struct (ethereum#25977) Here, the core.Message interface turns into a plain struct and types.Message gets removed. This is a breaking change to packages core and core/types. While we do not promise API stability for package core, we do for core/types. An exception can be made for types.Message, since it doesn't have any purpose apart from invoking the state transition in package core. types.Message was also marked deprecated by the same commit it got added in, 4dca5d4 (November 2016). The core.Message interface was added in December 2014, in commit db49417, for the purpose of 'testing' state transitions. It's the same change that made transaction struct fields private. Before that, the state transition used *types.Transaction directly. Over time, multiple implementations of the interface accrued across different packages, since constructing a Message is required whenever one wants to invoke the state transition. These implementations all looked very similar, a struct with private fields exposing the fields as accessor methods. By changing Message into a struct with public fields we can remove all these useless interface implementations. It will also hopefully simplify future changes to the type with less updates to apply across all of go-ethereum when a field is added to Message. --------- Co-authored-by: Felix Lange <fjl@twurst.com> * travis: only build PPAs nightly, not on every push, too heavy (ethereum#26846) * p2p: small comment typo (ethereum#26850) Update server.go * core: add Timestamp method in BlockGen (ethereum#26844) Since forks are now scheduled by block time, it can be necessary to check the timestamp of a block while generating transactions. * core/txpool: implement additional DoS defenses (ethereum#26648) This adds two new rules to the transaction pool: - A future transaction can not evict a pending transaction. - A transaction can not overspend available funds of a sender. --- Co-authored-by: dwn1998 <42262393+dwn1998@users.noreply.github.com> Co-authored-by: Martin Holst Swende <martin@swende.se> * params: go-ethereum v1.11.4 stable * params: begin v1.11.5 release cycle * tests: define `MuirGlacier` fork (ethereum#26856) add muir glacier to t8n * code/vm: fix comment typo (ethereum#26865) it should be constantinople rather than contantinople * core: minor code refactor (ethereum#26852) * core: refactor code * core: drop it from this anonymous goroutine func * core/txpool: use priceList.Put instead of heap.Push (ethereum#26863) Minor refactor to use the 'intended' accessor * eth: return error if 'safe' or 'finalized' tag used pre-merge (ethereum#26862) Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Felix Lange <fjl@twurst.com> * .travis.yml: reenable PPA build on tag push (ethereum#26873) * core/state, trie: port changes from PBSS (ethereum#26763) * p2p/discover: pass invalid discv5 packets to Unhandled channel (ethereum#26699) This makes it possible to run another protocol alongside discv5, by reading unhandled packets from the channel. * all: update links in documentation (ethereum#26882) Co-authored-by: Stephen Flynn <stephen.flynn@gapac.com> * Increase websocket frame size (from erigon rpc client) (ethereum#26883) This increases the maximum allowed message size to 32MB. Originally submitted at ledgerwatch/erigon#2739 example block failure: https://etherscan.io/tx/0x1317d973a55cedf9b0f2df6ea48e8077dd176f5444a3423368a46d6e4db89982#internal * cmd/devp2p, cmd/geth: add version in --help output (ethereum#26895) Not sure why this was removed, it's pretty useful to see the version also in --help. * core: show db error-info in case of mismatched hash root (ethereum#26870) When a database failure occurs, bubble it up a into statedb, and report it in suitable places, such as during a 'bad block' report. * consensus: improve consensus engine definition (ethereum#26871) Makes clear the distinction between Finalize and FinalizedAndAssemble: - In Finalize function, a series of state operations are applied according to consensus rules. The statedb is mutated and the root hash can be checked and compared afterwards. This function should be used in block processing(receive afrom network and apply it locally) but not block generation. - In FinalizeAndAssemble function, after applying state mutations, the block is also to be assembled with the latest state root computed, updating the header. This function should be used in block generation only. * eth/catalyst: increase update consensus timeout (ethereum#26840) Increases the time between consensus updates that we give the CL before we start warning the user. * internal/ethapi: avoid int overflow in GetTransactionReceipt (ethereum#26911) * trie, accounts/abi: add error-checks (ethereum#26914) * rlp: support for uint256 (ethereum#26898) This adds built-in support in package rlp for encoding, decoding and generating code dealing with uint256.Int. --------- Co-authored-by: Felix Lange <fjl@twurst.com> * eth: fix output file permissions in admin_exportChain (ethereum#26912) * api: Use 0700 file permissions for ExportChain * change perm to 0644 * Update api.go --------- Co-authored-by: Felix Lange <fjl@twurst.com> * trie: reduce unit test time (ethereum#26918) * core/txpool: use atomic int added in go1.19 (ethereum#26913) Makes use of atomic.Uint64 instead of atomic by pointer * params: schedule shanghai fork on mainnet (ethereum#26908) Schedules the shanghai hardfork on timestamp 1681338455 as discussed on ACDE 157: ethereum/execution-specs#727 * core/txpool: allow future local transactions (ethereum#26930) Local transactions should not be subject to the "future shouldn't churn pending txs" rule * params: go-ethereum v1.11.5 stable * params: begin v1.11.6 release cycle * build: allow building nightly archives via cron jobs (ethereum#26938) * log: add special casing of uint256 into the logger (ethereum#26936) * core/rawdb: use atomic int added in go1.19 (ethereum#26935) * core/vm: expose jumptable constructors (ethereum#26880) When interacting with geth as a library to e.g. produce state tests, it is desirable to obtain the consensus-correct jumptable definition for a given fork. This changes adds accessors so the instructionset can be obtained and characteristics about opcodes can be inspected. * eth/catalyst: fix races (ethereum#26950) * core/rawdb: update freezertable read meter (ethereum#26946) The meter for "for measuring the effective amount of data read" within the freezertable was never updated. This change remedies that. --------- Signed-off-by: jsvisa <delweng@gmail.com> * cmd/evm, tests: record preimages if dump is expected (ethereum#26955) With ethereum#25287 we made it so that preimages were not recorded by default. This had the side effect that the evm command is no longer able to dump state since it does a preimage lookup to determine the address represented by a key. This change enables the recording of preimages when the dump command is given. * core/state: add account address to Trie slot accessors (ethereum#26934) This changes the Trie interface to add the plain account address as a parameter to all storage-related methods. After the introduction of the TryAccount* functions, TryGet, TryUpdate and TryDelete are now only meant to read an account's storage. In their current form, they assume that an account storage is stored in a separate trie, and that the hashing of the slot is independent of its account's address. The proposed structure for a stateless storage breaks these two assumptions: the hashing of a slot key requires the address and all slots and accounts are stored in a single trie. This PR therefore adds an address parameter to the interface. It is ignored in the MPT version, so this change has no functional impact, however it will reduce the diff size when merging verkle trees. * metrics: add cpu counters (ethereum#26796) This PR adds counter metrics for the CPU system and the Geth process. Currently the only metrics available for these items are gauges. Gauges are fine when the consumer scrapes metrics data at the same interval as Geth produces new values (every 3 seconds), but it is likely that most consumers will not scrape that often. Intervals of 10, 15, or maybe even 30 seconds are probably more common. So the problem is, how does the consumer estimate what the CPU was doing in between scrapes. With a counter, it's easy ... you just subtract two successive values and divide by the time to get a nice, accurate average. But with a gauge, you can't do that. A gauge reading is an instantaneous picture of what was happening at that moment, but it gives you no idea about what was going on between scrapes. Taking an average of values is meaningless. * metrics/influxdb: use smaller dependency and reuse code between v1 and v2 reporters (ethereum#26963) This change switches to use the smaller influxdata/influxdb1-client package instead of depending on the whole infuxdb package. The new smaller client is very similar to the influxdb-v2 client, which made it possible to refactor the two reporters to reuse code a lot more. * eth/gasprice: change feehistory input type from int to uint64 (ethereum#26922) Change input param type from int to uint64 * go.mod: update golang.org/x/tools (ethereum#26960) * rlp/rlpgen: print want/expect output string if mismatch (ethereum#26932) Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * ethclient: ensure returned subscription is nil on error (ethereum#26976) * core/state, trie: remove Try prefix in Trie accessors (ethereum#26975) This change renames StateTrie methods to remove the Try* prefix. We added the Trie methods with prefix 'Try' a long time ago, working around the problem that most existing methods of Trie did not return the database error. This weird naming convention has persisted until now. Co-authored-by: Gary Rong <garyrong0905@gmail.com> * metrics/librato: ensure resp.body closed (ethereum#26969) This change ensures that we call Close on a http response body, in various places in the source code (mostly tests) * core/vm: use atomic.Bool (ethereum#26951) Make use of new atomic types --------- Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Martin Holst Swende <martin@swende.se> * core/bloombits: use atomic type (ethereum#26993) * core/state: use atomic.Bool (ethereum#26992) * graphql: fix data races (ethereum#26965) Fixes multiple data races caused by the fact that resolving fields are done concurrently by the graphql library. It also enforces caching at the stateobject level for account fields. * eth/tracers/native: prevent panic for LOG edge-cases (ethereum#26848) This PR fixes OOM panic in the callTracer as well as panicing on opcode validation errors (e.g. stack underflow) in callTracer and prestateTracer. Co-authored-by: Martin Holst Swende <martin@swende.se> * internal/debug: add log.logfmt flag to set logging to use logfmt (ethereum#26970) * docs: update outdated DeriveSha docs comment (ethereum#26968) * remove @gballet as a GraphQL codeowner (ethereum#27012) * core: use atomic type (ethereum#27011) * graphql: revert storage access regression (ethereum#27007) * cmd/geth: Add `--log.format` cli param (ethereum#27001) Removes the new --log.logfmt directive and hides --log.json, replacing both with log.format=(json|logfmt|terminal). The hidden log.json option is still respected if log.format is not specified for backwards compatibility. Co-authored-by: Martin Holst Swende <martin@swende.se> * ethdb/pebble: use atomic type (ethereum#27014) * common: fix json marshaller MixedcaseAddress (ethereum#26998) Fix the json marshaller of MixedcaseAddress * eth/catalyst: improve consensus heartbeat (ethereum#26896) improve the heartbeat function that is no longer suitable in the current situation Co-authored-by: “openex27” <“openexkevin@gmail.com”> * miner: use atomic type (ethereum#27013) Use the new typed atomics in the miner package * accounts/abi/bind: handle UnpackLog with zero topics (ethereum#26920) Adds error handling for the case that UnpackLog or UnpackLogIntoMap is called with a log that has zero topics. --------- Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> * cmd/evm: use correct parent number for t8n base fee calculation (ethereum#27032) Currently the t8n tool uses the same block number for the current block and its parent while calculating the base fee. This causes incorrect base fee calculation for the london fork block. This commit sets the parent block number to be one less than the current block number * go.mod : update snappy (ethereum#27027) * common: delete MakeName (ethereum#27023) common,p2p: remove unused function MakeName * cmd/geth: enable log rotation (ethereum#26843) This change enables log rotation, which can be activated using the flag --log.rotate. Additional parameters that can be given are: - log.maxsize to set maximum size before files are rotated, - log.maxbackups to set how many files are retailed, - log.maxage to configure max age of rotated files, - log.compress whether to compress rotated files The way to configure location of the logfile(s) is left unchanged, via the `log.logfile` parameter. --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd, miner, signer: avoid panic if keystore is not available (ethereum#27039) * cmd, miner, singer: avoid panic if keystore is not available * cmd/geth: print warning instead of panic * test/fuzzers: fuzz rlp handling of big.Int and uint256.Int (ethereum#26917) test/fuzzers: fuzz rlp handling of big.Lnt and uint256.Int * core/txpool: move some validation to outside of mutex (ethereum#27006) Currently, most of transaction validation while holding the txpool mutex: one exception being an early-on signature check. This PR changes that, so that we do all non-stateful checks before we entering the mutex area. This means they can be performed in parallel, and to enable that, certain fields have been made atomic bools and uint64. * eth/downloader: use atomic types (ethereum#27030) * eth/downloader: use atomic type * Update eth/downloader/downloader_test.go Co-authored-by: Martin Holst Swende <martin@swende.se> * Update eth/downloader/downloader_test.go Co-authored-by: Martin Holst Swende <martin@swende.se> --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * core/vm: clarify comment (ethereum#27045) * consensus, core/typer: add 4844 excessDataGas to header, tie it to Cancun (ethereum#27046) * consensus/misc, params: add EIP-4844 blobfee conversions (ethereum#27041) * consensus/misc, params: add EIP-4844 blobfee conversions * consensus/misc: pull in fakeExponential test cases * consensus/misc: reuse bigints * consensus/misc: nit renames, additional larger testcase --------- Co-authored-by: Roberto Bayardo <bayardo@alum.mit.edu> Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/tracers: report correct gasLimit in call tracers (ethereum#27029) This includes a semantic change to the `callTracer` as well as `flatCallTracer`. The value of field `gas` in the **first** call frame will change as follows: - It previously contained gas available after initial deductions (i.e. tx costs) - It will now contain the full tx gasLimit value Signed-off-by: jsvisa <delweng@gmail.com> * all: remove debug-field from vm config (ethereum#27048) This PR removes the Debug field from vmconfig, making it so that if a tracer is set, debug=true is implied. --------- Co-authored-by: 0xTylerHolmes <tyler@ethereum.org> Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> * metrics: make gauge_float64 and counter_float64 lock free (ethereum#27025) Makes the float-gauges lock-free name old time/op new time/op delta CounterFloat64Parallel-8 1.45µs ±10% 0.85µs ± 6% -41.65% (p=0.008 n=5+5) --------- Co-authored-by: Exca-DK <dev@DESKTOP-RI45P4J.localdomain> Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/tracers: use atomic type (ethereum#27031) Use the new atomic types in package eth/tracers --------- Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> * build: upgrade -dlgo version to Go 1.20.3 * core/txpool: disallow future churn by remote txs (ethereum#26907) Prior to this change, it was possible that transactions are erroneously deemed as 'future' although they are in fact 'pending', causing them to be dropped due to 'future' not being allowed to replace 'pending'. This change fixes that, by doing a more in-depth inspection of the queue. * core, miner: drop transactions from the same sender when error occurs (ethereum#27038) This PR unifies the error handling in miner. Whenever an error occur while applying a transaction, the transaction should be regarded as invalid and all following transactions from the same sender not executable because of the nonce restriction. The only exception is the `nonceTooLow` error which is handled separately. * params: new sepolia bootnodes (ethereum#27099) New sepolia bootnodes managed by EF devops * cmd/devp2p: fix erroneous log output in crawler (ethereum#27089) cmd/devp2p: fix log of ignored recent nodes counter * signer/core: rename testdata files (ethereum#27063) Sets a meaningful name on test-files * core: fix comment to reflect function name (ethereum#27070) * params: remove `EIP150Hash` from chainconfig (ethereum#27087) The EIP150Hash was an idea where, after the fork, we hardcoded the forked hash as an extra defensive mechanism. It wasn't really used, since forks weren't contentious and for all the various testnets and private networks it's been a hassle to have around. This change removes that config field. --------- Signed-off-by: jsvisa <delweng@gmail.com> * p2p: access embedded fields of Server directly (ethereum#27078) * consensus/ethash: use atomic type (ethereum#27068) * cmd/devp2p: make crawler-route53-updater less verbose (ethereum#27116) Follow-up to ethereum#26697, makes the crawler less verbose on route53-based scenarios. It also changes the loglevel from debug to info on Updates, which are typically the root, and can be interesting to see. * cmd/geth: rename --vmodule to --log.vmodule (ethereum#27071) renames `--vmodule` to `--log.vmodule`, and prints a warning if the old form is used. * core/vm: order opcodes properly (ethereum#27113) * metrics: use atomic type (ethereum#27121) * all: refactor trie API (ethereum#26995) In this PR, all TryXXX(e.g. TryGet) APIs of trie are renamed to XXX(e.g. Get) with an error returned. The original XXX(e.g. Get) APIs are renamed to MustXXX(e.g. MustGet) and does not return any error -- they print a log output. A future PR will change the behaviour to panic on errorrs. * params: go-ethereum v1.11.6 stable * fix merge conflicts * add market gas price to simulate duplicate nonce behavior (#7) --------- Signed-off-by: Sungwoo Kim <git@sung-woo.kim> Signed-off-by: jsvisa <delweng@gmail.com> Co-authored-by: Seungbae Yu <dbadoy4874@gmail.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Marius Kjærstad <sandakersmann@users.noreply.github.com> Co-authored-by: ucwong <ucwong@126.com> Co-authored-by: Paul <41552663+molecula451@users.noreply.github.com> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Zachinquarantine <Zachinquarantine@protonmail.com> Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: meehow <michal@ert.pl> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Shude Li <islishude@gmail.com> Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: marioevz <marioevz@gmail.com> Co-authored-by: Nicola Cocchiaro <3538109+ncocchiaro@users.noreply.github.com> Co-authored-by: Nicola Cocchiaro <ncocchiaro@users.noreply.github.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com> Co-authored-by: Mio <mshimmeris@gmail.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> Co-authored-by: lmittmann <3458786+lmittmann@users.noreply.github.com> Co-authored-by: delihiros <delihiros@gmail.com> Co-authored-by: raulk <raul.kripalani@gmail.com> Co-authored-by: Felföldi Zsolt <zsfelfoldi@gmail.com> Co-authored-by: zhiqiangxu <652732310@qq.com> Co-authored-by: halilylm <65048618+halilylm@users.noreply.github.com> Co-authored-by: Halil Yildirim <halilgolang@gmail.com> Co-authored-by: jwasinger <j-wasinger@hotmail.com> Co-authored-by: Chris Ziogas <ziogaschr@gmail.com> Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: Patrick O'Grady <prohb125@gmail.com> Co-authored-by: Roman Krasiuk <rokrassyuk@gmail.com> Co-authored-by: Jason Yuan <jason.yuan@curvegrid.com> Co-authored-by: Jason Yuan <jason.yuan869@gmail.com> Co-authored-by: Sungwoo Kim <git@sung-woo.kim> Co-authored-by: Yier <90763233+yierx@users.noreply.github.com> Co-authored-by: Catror <me@catror.com> Co-authored-by: Nate Armstrong <naterarmstrong@gmail.com> Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com> Co-authored-by: Peter (bitfly) <1674920+peterbitfly@users.noreply.github.com> Co-authored-by: PulsarAI <dev@pulsar-systems.fi> Co-authored-by: turboboost55 <7891737+turboboost55@users.noreply.github.com> Co-authored-by: Adrian Sutton <adrian@symphonious.net> Co-authored-by: Guruprasad Kamath <48196632+gurukamath@users.noreply.github.com> Co-authored-by: James Prestwich <10149425+prestwich@users.noreply.github.com> Co-authored-by: Daniel Fernandes <711733+daferna@users.noreply.github.com> Co-authored-by: Rafael Matias <rafael@skyle.net> Co-authored-by: xiyang <90125263+JBossBC@users.noreply.github.com> Co-authored-by: Roberto Bayardo <bayardo@alum.mit.edu> Co-authored-by: panicalways <113693386+panicalways@users.noreply.github.com> Co-authored-by: dwn1998 <42262393+dwn1998@users.noreply.github.com> Co-authored-by: s7v7nislands <s7v7nislands@gmail.com> Co-authored-by: Stephen Flynn <ssflynn@gmail.com> Co-authored-by: Stephen Flynn <stephen.flynn@gapac.com> Co-authored-by: Jonathan Otto <jonathan.otto@gmail.com> Co-authored-by: Delweng <delweng@gmail.com> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com> Co-authored-by: ucwong <ethereum2k@gmail.com> Co-authored-by: norwnd <112318969+norwnd@users.noreply.github.com> Co-authored-by: Adrian Sutton <adrian@oplabs.co> Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com> Co-authored-by: openex <openexkevin@gmail.com> Co-authored-by: “openex27” <“openexkevin@gmail.com”> Co-authored-by: sudeep <sudeepdino008@gmail.com> Co-authored-by: joohhnnn <68833933+joohhnnn@users.noreply.github.com> Co-authored-by: 0xTylerHolmes <tyler@ethereum.org> Co-authored-by: Exca-DK <85954505+Exca-DK@users.noreply.github.com> Co-authored-by: Exca-DK <dev@DESKTOP-RI45P4J.localdomain> Co-authored-by: Marius Kjærstad <mkjaerstad@protonmail.com> Co-authored-by: Parithosh Jayanthi <parithosh@indenwolken.xyz> Co-authored-by: noel <72006780+0x00Duke@users.noreply.github.com> Co-authored-by: Taeguk Kwon <xornrbboy@gmail.com> Co-authored-by: Anusha <63559942+anusha-ctrl@users.noreply.github.com> Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> Co-authored-by: susannapaxos <86749396+susannapaxos@users.noreply.github.com>
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
With ethereum#25287 we made it so that preimages were not recorded by default. This had the side effect that the evm command is no longer able to dump state since it does a preimage lookup to determine the address represented by a key. This change enables the recording of preimages when the dump command is given.
2 tasks
MoonShiesty
pushed a commit
to MoonShiesty/go-ethereum
that referenced
this pull request
Aug 30, 2023
With ethereum#25287 we made it so that preimages were not recorded by default. This had the side effect that the evm command is no longer able to dump state since it does a preimage lookup to determine the address represented by a key. This change enables the recording of preimages when the dump command is given.
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Sep 10, 2023
* ethdb/pebble: fix nil callbacks (ethereum#26650) * eth/downloader: fix timeout resurrection panic (ethereum#26652) * common/prque, eth/downloader: fix timeout resurrection panic * common/prque: revert -1 hack for les, temporaryly! * core/state, trie: remove unused error-return from trie Commit operation (ethereum#26641) * go.mod: update pebble to latest master (ethereum#26654) * core/vm: set tracer-observable `value` of a delegatecall to match parent `value` (ethereum#26632) This is a breaking change in the tracing hooks API as well as semantics of the callTracer: - CaptureEnter hook provided a nil value argument in case of DELEGATECALL. However to stay consistent with how delegate calls behave in EVM this hook is changed to pass in the value of the parent call. - callTracer will return parent call's value for DELEGATECALL frames. --------- Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> * ethdb: add benchmark test suite (ethereum#26659) * params: schedule shanghai fork on sepolia (ethereum#26662) * params: schedule shanghai fork on sepolia * params: u64 -> newUint64 * eth/filters: avoid block body retrieval when no matching logs (ethereum#25199) Logs stored on disk have minimal information. Contextual information such as block number, index of log in block, index of transaction in block are filled in upon request. We can fill in all these fields only having the block header and list of receipts. But determining the transaction hash of a log requires the block body. The goal of this PR is postponing this retrieval until we are sure we the transaction hash. It happens often that the header bloom filter signals there might be matches in a block, but after actually checking them reveals the logs do not match. We want to avoid fetching the body in this case. Note that this changes the semantics of Backend.GetLogs. Downstream callers of GetLogs now assume log context fields have not been derived, and need to call DeriveFields on the logs if necessary. * eth/tracers: more fork overrides in traceBlockToFile (ethereum#26655) This change allows all post-Berlin forks to be specified as overrides for futureForkBlock in the config parameter for traceBlockToFile. * tests/fuzzers: supply gnark multiexp config, fixes ethereum#26669 (ethereum#26670) This change fixes a fuzzer which broke when we updated the gnark dependency earlier. * cmd/devp2p: reduce output of node crawler (ethereum#26674) Our discovery crawler spits out a huge amount of logs, most of which is pretty non-interesting. This change moves the very verbose output to Debug, and adds a 8-second status log message giving the general idea about what's going on. * params: update mainnet + rinkeby CHT (ethereum#26677) This change updates the CHT entries for mainnet and rinkeby * eth/filters: replace atomic pointer with value (ethereum#26689) * eth/filters: replace atomic.Pointer * fix * improve Co-authored-by: Martin Holst Swende <martin@swende.se> --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * p2p/dnsdisc: fix tests with Go 1.20 (ethereum#26690) * eth/catalyst: return error if withdrawals are nil post-shanghai (ethereum#26691) Spec: https://github.com/ethereum/execution-apis/blob/main/src/engine/shanghai.md#request * ethdb/pebble: Fix `MemTableStopWritesThreshold` (ethereum#26692) MemTableStopWritesThreshold was set to the max size of all memtables before blocking writing but should be set to the max number of memtables. This is documented [here](https://github.com/cockroachdb/pebble/blob/master/options.go#L738-L742). * eth/downloader: handle missing withdrawals if empty list is expected (ethereum#26675) This PR relaxes the block body ingress handling a bit: if block body withdrawals are missing (but expected to be empty), the body withdrawals are set to 'empty list' before being passed to upper layers. This fixes an issue where a block passed from EthereumJS to geth was deemed invalid. * params: go-ethereum v1.11.0 stable * params: begin v1.11.1 release cycle * travis, build: update Go to 1.20.1 (ethereum#26653) travis, build: update Go to 1.20 * core: check genesis state presence by disk read (ethereum#26703) * core, eth/downloader: make body validation more strict (ethereum#26704) * eth/downloader: fix empty-body case in queue fetchresult (ethereum#26707) * eth/downloader: fix typo (ethereum#26716) * all: remove deprecated uses of math.rand (ethereum#26710) This PR is a (superior) alternative to ethereum#26708, it handles deprecation, primarily two specific cases. `rand.Seed` is typically used in two ways - `rand.Seed(time.Now().UnixNano())` -- we seed it, just to be sure to get some random, and not always get the same thing on every run. This is not needed, with global seeding, so those are just removed. - `rand.Seed(1)` this is typically done to ensure we have a stable test. If we rely on this, we need to fix up the tests to use a deterministic prng-source. A few occurrences like this has been replaced with a proper custom source. `rand.Read` has been replaced by `crypto/rand`.`Read` in this PR. * params: go-ethereum v1.11.1 stable * params: begin v1.11.2 release cycle * eth/catalyst: send INVALID instead of INVALID_BLOCK_HASH (ethereum#26696) This change will break one hive test, but pass another and it will be the better way going forward * ci: disable coverage reporting in appveyor and travis * eth/catalyst: request too large error (ethereum#26722) The method `GetPayloadBodiesByRangeV1` now returns "-38004: Too large request" error if the requested range is too large, according to spec Co-authored-by: Martin Holst Swende <martin@swende.se> * core/trie: remove trie tracer (ethereum#26665) This PR contains a small portion of the full pbss PR, namely Remove the tracer from trie (and comitter), and instead using an accessList. Related changes to the Nodeset. --------- Co-authored-by: Gary Rong <garyrong0905@gmail.com> * rpc: fix unmarshaling of null result in CallContext (ethereum#26723) The change fixes unmarshaling of JSON null results into json.RawMessage. --------- Co-authored-by: Jason Yuan <jason.yuan@curvegrid.com> Co-authored-by: Jason Yuan <jason.yuan869@gmail.com> * build: ship bootstrapper Go along with builder for PPA (ethereum#26731) * build: fix setting env var, temp early exit * build: fix gobootstrap path for the PPA * build: add some PPA debug logs, sigh * internal/build: revert raising the chunk size for PPA * build: yet another weird PPA fix * build: fix (finaly?) the PPA env vars for Go bootstrapping * build: fix Go 1.19.0 bootstrapper issues on 386 PPA * build: enable Lunar Lobster PPA builds * Revert "core/trie: remove trie tracer (ethereum#26665)" (ethereum#26732) This reverts commit 7c749c9. * cmd/geth: clarify dumpconfig options (ethereum#26729) Clarifies the documentation around dumpconfi Signed-off-by: Sungwoo Kim <git@sung-woo.kim> * core, eth: merge snap-sync chain download progress logs (ethereum#26676) * core: fix accessor mismatch for genesis state (ethereum#26747) * core/rawdb: expose chain freezer constructor without internals (ethereum#26748) * all: use unified emptyRootHash and emptyCodeHash (ethereum#26718) The EmptyRootHash and EmptyCodeHash are defined everywhere in the codebase, this PR replaces all of them with unified one defined in core/types package, and also defines constants for TxRoot, WithdrawalsRoot and UncleRoot * eth/filters: fix a breaking change and return rpctransaction (ethereum#26757) * eth/filters: fix a breaking change and return rpctransaction * eth/filters: fix test cases --------- Co-authored-by: Catror <me@catror.com> * common/math: allow HexOrDecimal to accept unquoted decimals too (ethereum#26758) * params: release Geth v1.11.2 * params: begin v.1.11.3 release cycle * log: improve documentation (ethereum#26753) Add usage examples * core/rawdb, node: use standalone flock dependency (ethereum#26633) * eth: use the last announced finalized block as the sync ancient limit (ethereum#26685) * cmd/devp2p: faster crawling + less verbose dns updates (ethereum#26697) This improves the speed of DHT crawling by using concurrent requests. It also removes logging of individual DNS updates. * eth/tracers: add native flatCallTracer (aka parity style tracer) (ethereum#26377) Adds support for a native call tracer with the Parity format, which outputs call frames in a flat array. This tracer accepts the following options: - `convertParityErrors: true` will convert error messages to match those of Parity - `includePrecompiles: true` will report all calls to precompiles. The default matches Parity's behavior where CALL and STATICCALLs to precompiles are excluded Incompatibilities with Parity include: - Parity removes the result object in case of failure. This behavior is maintained with the exception of reverts. Revert output usually contains useful information, i.e. Solidity revert reason. - The `gasUsed` field accounts for intrinsic gas (e.g. 21000 for simple transfers) and refunds unlike Parity - Block rewards are not reported Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> * core: improve withdrawal index assignment in GenerateChain (ethereum#26756) This fixes an issue where the withdrawal index was not calculated correctly for multiple withdrawals in a single block. Co-authored-by: Gary Rong <garyrong0905@gmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> * ethdb/pebble: fix range compaction (ethereum#26771) * ethdb/pebble: fix range compaction * ethdb/pebble: add comment * ethdb/pebble: fix max memorytable size (ethereum#26776) * ethclient: include withdrawals in ethclient block responses (ethereum#26778) * include withdrawals in ethclient responses * omit empty withdrawals array in json serialization * all: change chain head markers from block to header (ethereum#26777) * core/rawdb, ethdb/pebble: disable pebble on openbsd (ethereum#26801) * core: fix a merge fault (ethereum#26802) * README, go.mod, event, internal/version: bump min Go to 1.19 (ethereum#26803) * travi: remove strange leftover Go version * core, params: schedule Shanghai on goerli (ethereum#26795) * core: params: schedule Shanghai on goerli * core/forkid: fix comment * eth: remove admin.peers[i].eth.head and difficulty (ethereum#26804) * core/types: add EffectiveGasPrice in Receipt (ethereum#26713) This change adds a struct field EffectiveGasPrice in types.Receipt. The field is present in RPC responses, but not in the Go struct, and thus can't easily be accessed via ethclient. Co-authored-by: PulsarAI <dev@pulsar-systems.fi> * core, eth/catalyst: fix race conditions in tests (ethereum#26790) Fixes a race in TestNewPayloadOnInvalidTerminalBlock where setting the TTD raced with the miner. Solution: set the TTD on the blockchain config not the genesis config. Also fixes a race in CopyHeader which resulted in race reports all over the place. * metrics: improve accuracy of CPU gauges (ethereum#26793) This PR changes metrics collection to actually measure the time interval between collections, rather than assume 3 seconds. I did some ad hoc profiling, and on slower hardware (eg, my Raspberry Pi 4) I routinely saw intervals between 3.3 - 3.5 seconds, with some being as high as 4.5 seconds. This will generally cause the CPU gauge readings to be too high, and in some cases can cause impossibly large values for the CPU load metrics (eg. greater than 400 for a 4 core CPU). --------- Co-authored-by: Felix Lange <fjl@twurst.com> * ethclient: fix panic when requesting missing blocks (ethereum#26817) This fixes a regression introduced by ethereum#26723. Fixes ethereum#26816. * core, miner: revert block gas counter in case of invalid transaction (ethereum#26799) This change fixes a flaw where, in certain scenarios, the block sealer did not accurately reset the remaining gas after failing to include an invalid transaction. Fixes ethereum#26791 * internal/ethapi: add tests for transaction types JSON marshal/unmarshal (ethereum#26667) Checks that Transaction.MarshalJSON and newRPCTransaction JSON output can be parsed by Transaction.UnmarshalJSON --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd/evm: correct `alloc` for `t8n` testdata (ethereum#26822) Fixes a minor error in the testdata * eth/tracers/native: set created address to nil in case of failure (ethereum#26779) Fixes ethereum#26073 * accounts/usbwallet: mitigate ledger app chunking issue (ethereum#26773) This PR mitigates an issue with Ledger's on-device RLP deserialization, see LedgerHQ/app-ethereum#409 Ledger's RLP deserialization code does not validate the length of the RLP list received, and it may prematurely enter the signing flow when a APDU chunk boundary falls immediately before the EIP-155 chain_id when deserializing a transaction. Since the chain_id is uninitialized, it is 0 during this signing flow. This may cause the user to accidentally sign the transaction with chain_id = 0. That signature would be returned from the device 1 packet earlier than expected by the communication loop. The device blocks the second-to-last packet waiting for the signer flow, and then errors on the successive packet (which contains the chain_id, zeroed r, and zeroed s) Since the signature's early arrival causes successive errors during the communication process, geth does not parse the improper signature produced by the device, and therefore no improperly-signed transaction can be created. User funds are not at risk. We mitigate by selecting the highest chunk size that leaves at least 4 bytes in the final chunk. * beacon/engine: don't omit empty withdrawals in ExecutionPayloadBodies (ethereum#26698) This ensures the "withdrawals" field will always be present in responses to getPayloadBodiesByRangeV1 and getPayloadBodiesByHashV1. --------- Co-authored-by: Felix Lange <fjl@twurst.com> * build: update to go 1.20.2 (ethereum#26824) * params: go-ethereum v1.11.3 stable * params: begin v1.11.4 release cycle * core/rawdb: find smallest block stored in key-value store when chain gapped (ethereum#26719) This change prints out more information about the problem, in the case where geth detects a gap between leveldb and ancients, so we can determine more exactly where the gap is (what the first missing is). Also prints out more metadata. --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * signer/core: accept all solidity primitive types for EIP-712 signing (ethereum#26770) Accept all primitive types in Solidity for EIP-712 from intN, uintN, intN[], uintN[] for N as 0 to 256 in multiples of 8 --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * params: remove EF azure bootnodes (ethereum#26828) * core/vm: use golang native big.Int (ethereum#26834) reverts ethereum#26021, to use the upstream bigint instead. * core/vm: fix typo in comment (ethereum#26838) fixes eip 220 -> 2200 * core/forkid: fix issue in validation test (ethereum#26544) This changes the test to match the comment description. Using timestampedConfig in this test case is incorrect, the comment says 'local is at Gray Glacier' and isn't aware of more forks. * cmd/evm: update readmes for the tests (ethereum#26841) * core, core/types: plain Message struct (ethereum#25977) Here, the core.Message interface turns into a plain struct and types.Message gets removed. This is a breaking change to packages core and core/types. While we do not promise API stability for package core, we do for core/types. An exception can be made for types.Message, since it doesn't have any purpose apart from invoking the state transition in package core. types.Message was also marked deprecated by the same commit it got added in, 4dca5d4 (November 2016). The core.Message interface was added in December 2014, in commit db49417, for the purpose of 'testing' state transitions. It's the same change that made transaction struct fields private. Before that, the state transition used *types.Transaction directly. Over time, multiple implementations of the interface accrued across different packages, since constructing a Message is required whenever one wants to invoke the state transition. These implementations all looked very similar, a struct with private fields exposing the fields as accessor methods. By changing Message into a struct with public fields we can remove all these useless interface implementations. It will also hopefully simplify future changes to the type with less updates to apply across all of go-ethereum when a field is added to Message. --------- Co-authored-by: Felix Lange <fjl@twurst.com> * travis: only build PPAs nightly, not on every push, too heavy (ethereum#26846) * p2p: small comment typo (ethereum#26850) Update server.go * core: add Timestamp method in BlockGen (ethereum#26844) Since forks are now scheduled by block time, it can be necessary to check the timestamp of a block while generating transactions. * core/txpool: implement additional DoS defenses (ethereum#26648) This adds two new rules to the transaction pool: - A future transaction can not evict a pending transaction. - A transaction can not overspend available funds of a sender. --- Co-authored-by: dwn1998 <42262393+dwn1998@users.noreply.github.com> Co-authored-by: Martin Holst Swende <martin@swende.se> * params: go-ethereum v1.11.4 stable * params: begin v1.11.5 release cycle * tests: define `MuirGlacier` fork (ethereum#26856) add muir glacier to t8n * code/vm: fix comment typo (ethereum#26865) it should be constantinople rather than contantinople * core: minor code refactor (ethereum#26852) * core: refactor code * core: drop it from this anonymous goroutine func * core/txpool: use priceList.Put instead of heap.Push (ethereum#26863) Minor refactor to use the 'intended' accessor * eth: return error if 'safe' or 'finalized' tag used pre-merge (ethereum#26862) Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Felix Lange <fjl@twurst.com> * .travis.yml: reenable PPA build on tag push (ethereum#26873) * core/state, trie: port changes from PBSS (ethereum#26763) * p2p/discover: pass invalid discv5 packets to Unhandled channel (ethereum#26699) This makes it possible to run another protocol alongside discv5, by reading unhandled packets from the channel. * all: update links in documentation (ethereum#26882) Co-authored-by: Stephen Flynn <stephen.flynn@gapac.com> * Increase websocket frame size (from erigon rpc client) (ethereum#26883) This increases the maximum allowed message size to 32MB. Originally submitted at ledgerwatch/erigon#2739 example block failure: https://etherscan.io/tx/0x1317d973a55cedf9b0f2df6ea48e8077dd176f5444a3423368a46d6e4db89982#internal * cmd/devp2p, cmd/geth: add version in --help output (ethereum#26895) Not sure why this was removed, it's pretty useful to see the version also in --help. * core: show db error-info in case of mismatched hash root (ethereum#26870) When a database failure occurs, bubble it up a into statedb, and report it in suitable places, such as during a 'bad block' report. * consensus: improve consensus engine definition (ethereum#26871) Makes clear the distinction between Finalize and FinalizedAndAssemble: - In Finalize function, a series of state operations are applied according to consensus rules. The statedb is mutated and the root hash can be checked and compared afterwards. This function should be used in block processing(receive afrom network and apply it locally) but not block generation. - In FinalizeAndAssemble function, after applying state mutations, the block is also to be assembled with the latest state root computed, updating the header. This function should be used in block generation only. * eth/catalyst: increase update consensus timeout (ethereum#26840) Increases the time between consensus updates that we give the CL before we start warning the user. * internal/ethapi: avoid int overflow in GetTransactionReceipt (ethereum#26911) * trie, accounts/abi: add error-checks (ethereum#26914) * rlp: support for uint256 (ethereum#26898) This adds built-in support in package rlp for encoding, decoding and generating code dealing with uint256.Int. --------- Co-authored-by: Felix Lange <fjl@twurst.com> * eth: fix output file permissions in admin_exportChain (ethereum#26912) * api: Use 0700 file permissions for ExportChain * change perm to 0644 * Update api.go --------- Co-authored-by: Felix Lange <fjl@twurst.com> * trie: reduce unit test time (ethereum#26918) * core/txpool: use atomic int added in go1.19 (ethereum#26913) Makes use of atomic.Uint64 instead of atomic by pointer * params: schedule shanghai fork on mainnet (ethereum#26908) Schedules the shanghai hardfork on timestamp 1681338455 as discussed on ACDE 157: ethereum/execution-specs#727 * core/txpool: allow future local transactions (ethereum#26930) Local transactions should not be subject to the "future shouldn't churn pending txs" rule * params: go-ethereum v1.11.5 stable * params: begin v1.11.6 release cycle * build: allow building nightly archives via cron jobs (ethereum#26938) * log: add special casing of uint256 into the logger (ethereum#26936) * core/rawdb: use atomic int added in go1.19 (ethereum#26935) * core/vm: expose jumptable constructors (ethereum#26880) When interacting with geth as a library to e.g. produce state tests, it is desirable to obtain the consensus-correct jumptable definition for a given fork. This changes adds accessors so the instructionset can be obtained and characteristics about opcodes can be inspected. * eth/catalyst: fix races (ethereum#26950) * core/rawdb: update freezertable read meter (ethereum#26946) The meter for "for measuring the effective amount of data read" within the freezertable was never updated. This change remedies that. --------- Signed-off-by: jsvisa <delweng@gmail.com> * cmd/evm, tests: record preimages if dump is expected (ethereum#26955) With ethereum#25287 we made it so that preimages were not recorded by default. This had the side effect that the evm command is no longer able to dump state since it does a preimage lookup to determine the address represented by a key. This change enables the recording of preimages when the dump command is given. * core/state: add account address to Trie slot accessors (ethereum#26934) This changes the Trie interface to add the plain account address as a parameter to all storage-related methods. After the introduction of the TryAccount* functions, TryGet, TryUpdate and TryDelete are now only meant to read an account's storage. In their current form, they assume that an account storage is stored in a separate trie, and that the hashing of the slot is independent of its account's address. The proposed structure for a stateless storage breaks these two assumptions: the hashing of a slot key requires the address and all slots and accounts are stored in a single trie. This PR therefore adds an address parameter to the interface. It is ignored in the MPT version, so this change has no functional impact, however it will reduce the diff size when merging verkle trees. * metrics: add cpu counters (ethereum#26796) This PR adds counter metrics for the CPU system and the Geth process. Currently the only metrics available for these items are gauges. Gauges are fine when the consumer scrapes metrics data at the same interval as Geth produces new values (every 3 seconds), but it is likely that most consumers will not scrape that often. Intervals of 10, 15, or maybe even 30 seconds are probably more common. So the problem is, how does the consumer estimate what the CPU was doing in between scrapes. With a counter, it's easy ... you just subtract two successive values and divide by the time to get a nice, accurate average. But with a gauge, you can't do that. A gauge reading is an instantaneous picture of what was happening at that moment, but it gives you no idea about what was going on between scrapes. Taking an average of values is meaningless. * metrics/influxdb: use smaller dependency and reuse code between v1 and v2 reporters (ethereum#26963) This change switches to use the smaller influxdata/influxdb1-client package instead of depending on the whole infuxdb package. The new smaller client is very similar to the influxdb-v2 client, which made it possible to refactor the two reporters to reuse code a lot more. * eth/gasprice: change feehistory input type from int to uint64 (ethereum#26922) Change input param type from int to uint64 * go.mod: update golang.org/x/tools (ethereum#26960) * rlp/rlpgen: print want/expect output string if mismatch (ethereum#26932) Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * ethclient: ensure returned subscription is nil on error (ethereum#26976) * core/state, trie: remove Try prefix in Trie accessors (ethereum#26975) This change renames StateTrie methods to remove the Try* prefix. We added the Trie methods with prefix 'Try' a long time ago, working around the problem that most existing methods of Trie did not return the database error. This weird naming convention has persisted until now. Co-authored-by: Gary Rong <garyrong0905@gmail.com> * metrics/librato: ensure resp.body closed (ethereum#26969) This change ensures that we call Close on a http response body, in various places in the source code (mostly tests) * core/vm: use atomic.Bool (ethereum#26951) Make use of new atomic types --------- Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Martin Holst Swende <martin@swende.se> * core/bloombits: use atomic type (ethereum#26993) * core/state: use atomic.Bool (ethereum#26992) * graphql: fix data races (ethereum#26965) Fixes multiple data races caused by the fact that resolving fields are done concurrently by the graphql library. It also enforces caching at the stateobject level for account fields. * eth/tracers/native: prevent panic for LOG edge-cases (ethereum#26848) This PR fixes OOM panic in the callTracer as well as panicing on opcode validation errors (e.g. stack underflow) in callTracer and prestateTracer. Co-authored-by: Martin Holst Swende <martin@swende.se> * internal/debug: add log.logfmt flag to set logging to use logfmt (ethereum#26970) * docs: update outdated DeriveSha docs comment (ethereum#26968) * remove @gballet as a GraphQL codeowner (ethereum#27012) * core: use atomic type (ethereum#27011) * graphql: revert storage access regression (ethereum#27007) * cmd/geth: Add `--log.format` cli param (ethereum#27001) Removes the new --log.logfmt directive and hides --log.json, replacing both with log.format=(json|logfmt|terminal). The hidden log.json option is still respected if log.format is not specified for backwards compatibility. Co-authored-by: Martin Holst Swende <martin@swende.se> * ethdb/pebble: use atomic type (ethereum#27014) * common: fix json marshaller MixedcaseAddress (ethereum#26998) Fix the json marshaller of MixedcaseAddress * eth/catalyst: improve consensus heartbeat (ethereum#26896) improve the heartbeat function that is no longer suitable in the current situation Co-authored-by: “openex27” <“openexkevin@gmail.com”> * miner: use atomic type (ethereum#27013) Use the new typed atomics in the miner package * accounts/abi/bind: handle UnpackLog with zero topics (ethereum#26920) Adds error handling for the case that UnpackLog or UnpackLogIntoMap is called with a log that has zero topics. --------- Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> * cmd/evm: use correct parent number for t8n base fee calculation (ethereum#27032) Currently the t8n tool uses the same block number for the current block and its parent while calculating the base fee. This causes incorrect base fee calculation for the london fork block. This commit sets the parent block number to be one less than the current block number * go.mod : update snappy (ethereum#27027) * common: delete MakeName (ethereum#27023) common,p2p: remove unused function MakeName * cmd/geth: enable log rotation (ethereum#26843) This change enables log rotation, which can be activated using the flag --log.rotate. Additional parameters that can be given are: - log.maxsize to set maximum size before files are rotated, - log.maxbackups to set how many files are retailed, - log.maxage to configure max age of rotated files, - log.compress whether to compress rotated files The way to configure location of the logfile(s) is left unchanged, via the `log.logfile` parameter. --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd, miner, signer: avoid panic if keystore is not available (ethereum#27039) * cmd, miner, singer: avoid panic if keystore is not available * cmd/geth: print warning instead of panic * test/fuzzers: fuzz rlp handling of big.Int and uint256.Int (ethereum#26917) test/fuzzers: fuzz rlp handling of big.Lnt and uint256.Int * core/txpool: move some validation to outside of mutex (ethereum#27006) Currently, most of transaction validation while holding the txpool mutex: one exception being an early-on signature check. This PR changes that, so that we do all non-stateful checks before we entering the mutex area. This means they can be performed in parallel, and to enable that, certain fields have been made atomic bools and uint64. * eth/downloader: use atomic types (ethereum#27030) * eth/downloader: use atomic type * Update eth/downloader/downloader_test.go Co-authored-by: Martin Holst Swende <martin@swende.se> * Update eth/downloader/downloader_test.go Co-authored-by: Martin Holst Swende <martin@swende.se> --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * core/vm: clarify comment (ethereum#27045) * consensus, core/typer: add 4844 excessDataGas to header, tie it to Cancun (ethereum#27046) * consensus/misc, params: add EIP-4844 blobfee conversions (ethereum#27041) * consensus/misc, params: add EIP-4844 blobfee conversions * consensus/misc: pull in fakeExponential test cases * consensus/misc: reuse bigints * consensus/misc: nit renames, additional larger testcase --------- Co-authored-by: Roberto Bayardo <bayardo@alum.mit.edu> Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/tracers: report correct gasLimit in call tracers (ethereum#27029) This includes a semantic change to the `callTracer` as well as `flatCallTracer`. The value of field `gas` in the **first** call frame will change as follows: - It previously contained gas available after initial deductions (i.e. tx costs) - It will now contain the full tx gasLimit value Signed-off-by: jsvisa <delweng@gmail.com> * all: remove debug-field from vm config (ethereum#27048) This PR removes the Debug field from vmconfig, making it so that if a tracer is set, debug=true is implied. --------- Co-authored-by: 0xTylerHolmes <tyler@ethereum.org> Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> * metrics: make gauge_float64 and counter_float64 lock free (ethereum#27025) Makes the float-gauges lock-free name old time/op new time/op delta CounterFloat64Parallel-8 1.45µs ±10% 0.85µs ± 6% -41.65% (p=0.008 n=5+5) --------- Co-authored-by: Exca-DK <dev@DESKTOP-RI45P4J.localdomain> Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/tracers: use atomic type (ethereum#27031) Use the new atomic types in package eth/tracers --------- Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> * build: upgrade -dlgo version to Go 1.20.3 * core/txpool: disallow future churn by remote txs (ethereum#26907) Prior to this change, it was possible that transactions are erroneously deemed as 'future' although they are in fact 'pending', causing them to be dropped due to 'future' not being allowed to replace 'pending'. This change fixes that, by doing a more in-depth inspection of the queue. * core, miner: drop transactions from the same sender when error occurs (ethereum#27038) This PR unifies the error handling in miner. Whenever an error occur while applying a transaction, the transaction should be regarded as invalid and all following transactions from the same sender not executable because of the nonce restriction. The only exception is the `nonceTooLow` error which is handled separately. * params: new sepolia bootnodes (ethereum#27099) New sepolia bootnodes managed by EF devops * cmd/devp2p: fix erroneous log output in crawler (ethereum#27089) cmd/devp2p: fix log of ignored recent nodes counter * signer/core: rename testdata files (ethereum#27063) Sets a meaningful name on test-files * core: fix comment to reflect function name (ethereum#27070) * params: remove `EIP150Hash` from chainconfig (ethereum#27087) The EIP150Hash was an idea where, after the fork, we hardcoded the forked hash as an extra defensive mechanism. It wasn't really used, since forks weren't contentious and for all the various testnets and private networks it's been a hassle to have around. This change removes that config field. --------- Signed-off-by: jsvisa <delweng@gmail.com> * p2p: access embedded fields of Server directly (ethereum#27078) * consensus/ethash: use atomic type (ethereum#27068) * cmd/devp2p: make crawler-route53-updater less verbose (ethereum#27116) Follow-up to ethereum#26697, makes the crawler less verbose on route53-based scenarios. It also changes the loglevel from debug to info on Updates, which are typically the root, and can be interesting to see. * cmd/geth: rename --vmodule to --log.vmodule (ethereum#27071) renames `--vmodule` to `--log.vmodule`, and prints a warning if the old form is used. * core/vm: order opcodes properly (ethereum#27113) * metrics: use atomic type (ethereum#27121) * all: refactor trie API (ethereum#26995) In this PR, all TryXXX(e.g. TryGet) APIs of trie are renamed to XXX(e.g. Get) with an error returned. The original XXX(e.g. Get) APIs are renamed to MustXXX(e.g. MustGet) and does not return any error -- they print a log output. A future PR will change the behaviour to panic on errorrs. * params: go-ethereum v1.11.6 stable * dev: chg: regression changes for bor after merge * dev: chg: more regression changes for bor after merge * dev: chg: txpool_test regression changes after merge * dev: chg: gomock re-generate mocks for backend interface * dev: chg: regression changes after develop is merged into upstream-merge * dev: chg: further fixes merging develop into upstream-merge * dev: chg: apply changes to NewParallelBlockChain * dev: chg: solve some TODOs * dev: fix: CreateConsensusEngine for new ethereum objects * dev: fix: NewParallelBlockChain using Genesis * dev: fix: build ci.go * dev: fix: thelper and tparallel lint * dev: fix: http related and nilnil lint errors * dev: fix: ineffassign lint errors * dev: chg: comment position fix * dev: fix: govet lint errors * dev: fix: error related lint issues * dev: fix: bodyclose lint issues * dev: fix: some wsl lint issues * dev: fix: more wsl lint issues * dev: fix: errorcheck lint issues * dev: fix: solve more lint issues * dev: fix: more wsl lint issues * dev: fix: more errcheck lint issues * dev: fix: most of wsl lint issues * dev: fix: all remaining lint issues * dev: fix: t.Parallel called multiple times * dev: fix: tests failing due to t.Parallel * fix : runtime testcases * fix : testcase : config, addTxWithChain, burnAmount * fix : ethhash bor burn contract * fix : genspec config * fix : freezer, TestStateProcessorErrors * core,eth,miner: fix initial test cases (ethereum#922) * fix : TestTransactionIndices, testBeaconSync * fix : TestBeaconSync66 * core,eth: fix TestDeduplication, TestSyncAccountPerformance, TestTraceTransaction * fix : TestTxIndexer * rm : multiple coinbase balance * fix : testCommitInterruptExperimentBor * adding balance send to burntcontract back * Fix header encoding test * core,eth/tracers: fix TestPrestateWithDiffModeTracer * consensus/bor,eth/filters,miner,params,tests: fix mocks * fix : TestGraphQLConcurrentResolvers * fix : TestBuildPayload * common,core,miner: fix goleaks,duplicate init and inconsistent mutex (un)locks * fix : lint * fix : lint * fix : test-integration * fix : test-integration * core: restore AddFeeTransferLog post miner tipping * fix : TestGraphQLConcurrentResolvers * fix : deadlocks * rm: t.parallel from testQueueTimeLimiting tests * Merge branch 'develop' into mardizzone/upstream-merge * fix : lint * fix : test-integration * fix : TxDependency * add rpc.enabledeprecatedpersonal flag --------- Signed-off-by: Sungwoo Kim <git@sung-woo.kim> Signed-off-by: jsvisa <delweng@gmail.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Chris Ziogas <ziogaschr@gmail.com> Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Patrick O'Grady <prohb125@gmail.com> Co-authored-by: ucwong <ucwong@126.com> Co-authored-by: Roman Krasiuk <rokrassyuk@gmail.com> Co-authored-by: Jason Yuan <jason.yuan@curvegrid.com> Co-authored-by: Jason Yuan <jason.yuan869@gmail.com> Co-authored-by: Sungwoo Kim <git@sung-woo.kim> Co-authored-by: Yier <90763233+yierx@users.noreply.github.com> Co-authored-by: Catror <me@catror.com> Co-authored-by: Nate Armstrong <naterarmstrong@gmail.com> Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com> Co-authored-by: Peter (bitfly) <1674920+peterbitfly@users.noreply.github.com> Co-authored-by: PulsarAI <dev@pulsar-systems.fi> Co-authored-by: turboboost55 <7891737+turboboost55@users.noreply.github.com> Co-authored-by: Adrian Sutton <adrian@symphonious.net> Co-authored-by: Guruprasad Kamath <48196632+gurukamath@users.noreply.github.com> Co-authored-by: James Prestwich <10149425+prestwich@users.noreply.github.com> Co-authored-by: Daniel Fernandes <711733+daferna@users.noreply.github.com> Co-authored-by: Rafael Matias <rafael@skyle.net> Co-authored-by: xiyang <90125263+JBossBC@users.noreply.github.com> Co-authored-by: Roberto Bayardo <bayardo@alum.mit.edu> Co-authored-by: panicalways <113693386+panicalways@users.noreply.github.com> Co-authored-by: dwn1998 <42262393+dwn1998@users.noreply.github.com> Co-authored-by: s7v7nislands <s7v7nislands@gmail.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: Stephen Flynn <ssflynn@gmail.com> Co-authored-by: Stephen Flynn <stephen.flynn@gapac.com> Co-authored-by: Jonathan Otto <jonathan.otto@gmail.com> Co-authored-by: Delweng <delweng@gmail.com> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com> Co-authored-by: ucwong <ethereum2k@gmail.com> Co-authored-by: norwnd <112318969+norwnd@users.noreply.github.com> Co-authored-by: jwasinger <j-wasinger@hotmail.com> Co-authored-by: Adrian Sutton <adrian@oplabs.co> Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com> Co-authored-by: openex <openexkevin@gmail.com> Co-authored-by: “openex27” <“openexkevin@gmail.com”> Co-authored-by: sudeep <sudeepdino008@gmail.com> Co-authored-by: joohhnnn <68833933+joohhnnn@users.noreply.github.com> Co-authored-by: 0xTylerHolmes <tyler@ethereum.org> Co-authored-by: Exca-DK <85954505+Exca-DK@users.noreply.github.com> Co-authored-by: Exca-DK <dev@DESKTOP-RI45P4J.localdomain> Co-authored-by: Marius Kjærstad <mkjaerstad@protonmail.com> Co-authored-by: Parithosh Jayanthi <parithosh@indenwolken.xyz> Co-authored-by: noel <72006780+0x00Duke@users.noreply.github.com> Co-authored-by: Taeguk Kwon <xornrbboy@gmail.com> Co-authored-by: Anusha <63559942+anusha-ctrl@users.noreply.github.com> Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> Co-authored-by: Shivam Sharma <shivam691999@gmail.com> Co-authored-by: Raneet Debnath <35629432+Raneet10@users.noreply.github.com> Co-authored-by: Raneet Debnath <raneetdebnath10@gmail.com> Co-authored-by: Jerry <jerrycgh@gmail.com> Co-authored-by: Manav Darji <manavdarji.india@gmail.com>
maoueh
added a commit
to streamingfast/go-ethereum
that referenced
this pull request
Sep 20, 2023
* build: yet another weird PPA fix
* build: fix (finaly?) the PPA env vars for Go bootstrapping
* build: fix Go 1.19.0 bootstrapper issues on 386 PPA
* build: enable Lunar Lobster PPA builds
* Revert "core/trie: remove trie tracer (#26665)" (#26732)
This reverts commit 7c749c947a9d5181f5f2c1b3fdb5ea6b0e401e8e.
* cmd/geth: clarify dumpconfig options (#26729)
Clarifies the documentation around dumpconfi
Signed-off-by: Sungwoo Kim <git@sung-woo.kim>
* core, eth: merge snap-sync chain download progress logs (#26676)
* core: fix accessor mismatch for genesis state (#26747)
* core/rawdb: expose chain freezer constructor without internals (#26748)
* all: use unified emptyRootHash and emptyCodeHash (#26718)
The EmptyRootHash and EmptyCodeHash are defined everywhere in the codebase, this PR replaces all of them with unified one defined in core/types package, and also defines constants for TxRoot, WithdrawalsRoot and UncleRoot
* eth/filters: fix a breaking change and return rpctransaction (#26757)
* eth/filters: fix a breaking change and return rpctransaction
* eth/filters: fix test cases
---------
Co-authored-by: Catror <me@catror.com>
* common/math: allow HexOrDecimal to accept unquoted decimals too (#26758)
* params: release Geth v1.11.2
* params: begin v.1.11.3 release cycle
* log: improve documentation (#26753)
Add usage examples
* core/rawdb, node: use standalone flock dependency (#26633)
* eth: use the last announced finalized block as the sync ancient limit (#26685)
* cmd/devp2p: faster crawling + less verbose dns updates (#26697)
This improves the speed of DHT crawling by using concurrent requests.
It also removes logging of individual DNS updates.
* eth/tracers: add native flatCallTracer (aka parity style tracer) (#26377)
Adds support for a native call tracer with the Parity format, which outputs call frames
in a flat array. This tracer accepts the following options:
- `convertParityErrors: true` will convert error messages to match those of Parity
- `includePrecompiles: true` will report all calls to precompiles. The default
matches Parity's behavior where CALL and STATICCALLs to precompiles are excluded
Incompatibilities with Parity include:
- Parity removes the result object in case of failure. This behavior is maintained
with the exception of reverts. Revert output usually contains useful information,
i.e. Solidity revert reason.
- The `gasUsed` field accounts for intrinsic gas (e.g. 21000 for simple transfers)
and refunds unlike Parity
- Block rewards are not reported
Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
* core: improve withdrawal index assignment in GenerateChain (#26756)
This fixes an issue where the withdrawal index was not calculated correctly
for multiple withdrawals in a single block.
Co-authored-by: Gary Rong <garyrong0905@gmail.com>
Co-authored-by: Felix Lange <fjl@twurst.com>
* ethdb/pebble: fix range compaction (#26771)
* ethdb/pebble: fix range compaction
* ethdb/pebble: add comment
* ethdb/pebble: fix max memorytable size (#26776)
* ethclient: include withdrawals in ethclient block responses (#26778)
* include withdrawals in ethclient responses
* omit empty withdrawals array in json serialization
* all: change chain head markers from block to header (#26777)
* core/rawdb, ethdb/pebble: disable pebble on openbsd (#26801)
* core: fix a merge fault (#26802)
* README, go.mod, event, internal/version: bump min Go to 1.19 (#26803)
* travi: remove strange leftover Go version
* core, params: schedule Shanghai on goerli (#26795)
* core: params: schedule Shanghai on goerli
* core/forkid: fix comment
* eth: remove admin.peers[i].eth.head and difficulty (#26804)
* core/types: add EffectiveGasPrice in Receipt (#26713)
This change adds a struct field EffectiveGasPrice in types.Receipt. The field is present
in RPC responses, but not in the Go struct, and thus can't easily be accessed via ethclient.
Co-authored-by: PulsarAI <dev@pulsar-systems.fi>
* core, eth/catalyst: fix race conditions in tests (#26790)
Fixes a race in TestNewPayloadOnInvalidTerminalBlock where setting the TTD raced with
the miner. Solution: set the TTD on the blockchain config not the genesis config.
Also fixes a race in CopyHeader which resulted in race reports all over the place.
* metrics: improve accuracy of CPU gauges (#26793)
This PR changes metrics collection to actually measure the time interval between collections, rather
than assume 3 seconds. I did some ad hoc profiling, and on slower hardware (eg, my Raspberry Pi 4)
I routinely saw intervals between 3.3 - 3.5 seconds, with some being as high as 4.5 seconds. This
will generally cause the CPU gauge readings to be too high, and in some cases can cause impossibly
large values for the CPU load metrics (eg. greater than 400 for a 4 core CPU).
---------
Co-authored-by: Felix Lange <fjl@twurst.com>
* ethclient: fix panic when requesting missing blocks (#26817)
This fixes a regression introduced by #26723.
Fixes #26816.
* core, miner: revert block gas counter in case of invalid transaction (#26799)
This change fixes a flaw where, in certain scenarios, the block sealer did not accurately reset the remaining gas after failing to include an invalid transaction. Fixes #26791
* internal/ethapi: add tests for transaction types JSON marshal/unmarshal (#26667)
Checks that Transaction.MarshalJSON and newRPCTransaction JSON output can be parsed by Transaction.UnmarshalJSON
---------
Co-authored-by: Martin Holst Swende <martin@swende.se>
* cmd/evm: correct `alloc` for `t8n` testdata (#26822)
Fixes a minor error in the testdata
* eth/tracers/native: set created address to nil in case of failure (#26779)
Fixes #26073
* accounts/usbwallet: mitigate ledger app chunking issue (#26773)
This PR mitigates an issue with Ledger's on-device RLP deserialization, see
https://github.com/LedgerHQ/app-ethereum/issues/409
Ledger's RLP deserialization code does not validate the length of the RLP list received,
and it may prematurely enter the signing flow when a APDU chunk boundary falls immediately
before the EIP-155 chain_id when deserializing a transaction. Since the chain_id is
uninitialized, it is 0 during this signing flow. This may cause the user to accidentally
sign the transaction with chain_id = 0. That signature would be returned from the device 1
packet earlier than expected by the communication loop. The device blocks the
second-to-last packet waiting for the signer flow, and then errors on the successive
packet (which contains the chain_id, zeroed r, and zeroed s)
Since the signature's early arrival causes successive errors during the communication
process, geth does not parse the improper signature produced by the device, and therefore
no improperly-signed transaction can be created. User funds are not at risk.
We mitigate by selecting the highest chunk size that leaves at least 4 bytes in the
final chunk.
* beacon/engine: don't omit empty withdrawals in ExecutionPayloadBodies (#26698)
This ensures the "withdrawals" field will always be present in responses
to getPayloadBodiesByRangeV1 and getPayloadBodiesByHashV1.
---------
Co-authored-by: Felix Lange <fjl@twurst.com>
* build: update to go 1.20.2 (#26824)
* params: go-ethereum v1.11.3 stable
* params: begin v1.11.4 release cycle
* core/rawdb: find smallest block stored in key-value store when chain gapped (#26719)
This change prints out more information about the problem, in the case where geth detects a gap between leveldb and ancients, so we can determine more exactly where the gap is (what the first missing is). Also prints out more metadata.
---------
Co-authored-by: Martin Holst Swende <martin@swende.se>
* signer/core: accept all solidity primitive types for EIP-712 signing (#26770)
Accept all primitive types in Solidity for EIP-712 from intN, uintN, intN[], uintN[] for N as 0 to 256 in multiples of 8
---------
Co-authored-by: Martin Holst Swende <martin@swende.se>
* params: remove EF azure bootnodes (#26828)
* core/vm: use golang native big.Int (#26834)
reverts #26021, to use the upstream bigint instead.
* core/vm: fix typo in comment (#26838)
fixes eip 220 -> 2200
* core/forkid: fix issue in validation test (#26544)
This changes the test to match the comment description. Using timestampedConfig in this test case is incorrect, the comment says 'local is at Gray Glacier' and isn't aware of more forks.
* cmd/evm: update readmes for the tests (#26841)
* core, core/types: plain Message struct (#25977)
Here, the core.Message interface turns into a plain struct and
types.Message gets removed.
This is a breaking change to packages core and core/types. While we do
not promise API stability for package core, we do for core/types. An
exception can be made for types.Message, since it doesn't have any
purpose apart from invoking the state transition in package core.
types.Message was also marked deprecated by the same commit it
got added in, 4dca5d4db7 (November 2016).
The core.Message interface was added in December 2014, in commit
db494170dc, for the purpose of 'testing' state transitions. It's the
same change that made transaction struct fields private. Before that,
the state transition used *types.Transaction directly.
Over time, multiple implementations of the interface accrued across
different packages, since constructing a Message is required whenever
one wants to invoke the state transition. These implementations all
looked very similar, a struct with private fields exposing the fields
as accessor methods.
By changing Message into a struct with public fields we can remove all
these useless interface implementations. It will also hopefully
simplify future changes to the type with less updates to apply across
all of go-ethereum when a field is added to Message.
---------
Co-authored-by: Felix Lange <fjl@twurst.com>
* travis: only build PPAs nightly, not on every push, too heavy (#26846)
* p2p: small comment typo (#26850)
Update server.go
* core: add Timestamp method in BlockGen (#26844)
Since forks are now scheduled by block time, it can be necessary
to check the timestamp of a block while generating transactions.
* core/txpool: implement additional DoS defenses (#26648)
This adds two new rules to the transaction pool:
- A future transaction can not evict a pending transaction.
- A transaction can not overspend available funds of a sender.
---
Co-authored-by: dwn1998 <42262393+dwn1998@users.noreply.github.com>
Co-authored-by: Martin Holst Swende <martin@swende.se>
* params: go-ethereum v1.11.4 stable
* params: begin v1.11.5 release cycle
* tests: define `MuirGlacier` fork (#26856)
add muir glacier to t8n
* code/vm: fix comment typo (#26865)
it should be constantinople rather than contantinople
* core: minor code refactor (#26852)
* core: refactor code
* core: drop it from this anonymous goroutine func
* core/txpool: use priceList.Put instead of heap.Push (#26863)
Minor refactor to use the 'intended' accessor
* eth: return error if 'safe' or 'finalized' tag used pre-merge (#26862)
Co-authored-by: Martin Holst Swende <martin@swende.se>
Co-authored-by: Felix Lange <fjl@twurst.com>
* .travis.yml: reenable PPA build on tag push (#26873)
* core/state, trie: port changes from PBSS (#26763)
* p2p/discover: pass invalid discv5 packets to Unhandled channel (#26699)
This makes it possible to run another protocol alongside discv5, by reading
unhandled packets from the channel.
* all: update links in documentation (#26882)
Co-authored-by: Stephen Flynn <stephen.flynn@gapac.com>
* Increase websocket frame size (from erigon rpc client) (#26883)
This increases the maximum allowed message size to 32MB.
Originally submitted at https://github.com/ledgerwatch/erigon/pull/2739
example block failure: https://etherscan.io/tx/0x1317d973a55cedf9b0f2df6ea48e8077dd176f5444a3423368a46d6e4db89982#internal
* cmd/devp2p, cmd/geth: add version in --help output (#26895)
Not sure why this was removed, it's pretty useful to see the version
also in --help.
* core: show db error-info in case of mismatched hash root (#26870)
When a database failure occurs, bubble it up a into statedb, and report it in suitable places, such as during a 'bad block' report.
* consensus: improve consensus engine definition (#26871)
Makes clear the distinction between Finalize and FinalizedAndAssemble:
- In Finalize function, a series of state operations are applied according to consensus rules. The statedb is mutated and the root hash can be checked and compared afterwards.
This function should be used in block processing(receive afrom network and apply it locally) but not block generation.
- In FinalizeAndAssemble function, after applying state mutations, the block is also to be assembled with the latest
state root computed, updating the header.
This function should be used in block generation only.
* eth/catalyst: increase update consensus timeout (#26840)
Increases the time between consensus updates that we give the CL before we start warning the user.
* internal/ethapi: avoid int overflow in GetTransactionReceipt (#26911)
* trie, accounts/abi: add error-checks (#26914)
* rlp: support for uint256 (#26898)
This adds built-in support in package rlp for encoding, decoding and generating code dealing with uint256.Int.
---------
Co-authored-by: Felix Lange <fjl@twurst.com>
* eth: fix output file permissions in admin_exportChain (#26912)
* api: Use 0700 file permissions for ExportChain
* change perm to 0644
* Update api.go
---------
Co-authored-by: Felix Lange <fjl@twurst.com>
* trie: reduce unit test time (#26918)
* core/txpool: use atomic int added in go1.19 (#26913)
Makes use of atomic.Uint64 instead of atomic by pointer
* params: schedule shanghai fork on mainnet (#26908)
Schedules the shanghai hardfork on timestamp 1681338455 as discussed on ACDE 157: https://github.com/ethereum/execution-specs/pull/727
* core/txpool: allow future local transactions (#26930)
Local transactions should not be subject to the "future shouldn't churn pending txs" rule
* params: go-ethereum v1.11.5 stable
* params: begin v1.11.6 release cycle
* build: allow building nightly archives via cron jobs (#26938)
* log: add special casing of uint256 into the logger (#26936)
* core/rawdb: use atomic int added in go1.19 (#26935)
* core/vm: expose jumptable constructors (#26880)
When interacting with geth as a library to e.g. produce state tests, it is desirable to obtain the consensus-correct jumptable definition for a given fork. This changes adds accessors so the instructionset can be obtained and characteristics about opcodes can be inspected.
* eth/catalyst: fix races (#26950)
* core/rawdb: update freezertable read meter (#26946)
The meter for "for measuring the effective amount of data read" within the freezertable was never updated. This change remedies that.
---------
Signed-off-by: jsvisa <delweng@gmail.com>
* cmd/evm, tests: record preimages if dump is expected (#26955)
With #25287 we made it so that preimages were not recorded by default. This had the side effect that the evm command is no longer able to dump state since it does a preimage lookup to determine the address represented by a key.
This change enables the recording of preimages when the dump command is given.
* core/state: add account address to Trie slot accessors (#26934)
This changes the Trie interface to add the plain account address as a
parameter to all storage-related methods.
After the introduction of the TryAccount* functions, TryGet, TryUpdate and
TryDelete are now only meant to read an account's storage. In their current
form, they assume that an account storage is stored in a separate trie, and
that the hashing of the slot is independent of its account's address.
The proposed structure for a stateless storage breaks these two
assumptions: the hashing of a slot key requires the address and all slots
and accounts are stored in a single trie.
This PR therefore adds an address parameter to the interface. It is ignored
in the MPT version, so this change has no functional impact, however it
will reduce the diff size when merging verkle trees.
* metrics: add cpu counters (#26796)
This PR adds counter metrics for the CPU system and the Geth process.
Currently the only metrics available for these items are gauges. Gauges are
fine when the consumer scrapes metrics data at the same interval as Geth
produces new values (every 3 seconds), but it is likely that most consumers
will not scrape that often. Intervals of 10, 15, or maybe even 30 seconds
are probably more common.
So the problem is, how does the consumer estimate what the CPU was doing in
between scrapes. With a counter, it's easy ... you just subtract two
successive values and divide by the time to get a nice, accurate average.
But with a gauge, you can't do that. A gauge reading is an instantaneous
picture of what was happening at that moment, but it gives you no idea
about what was going on between scrapes. Taking an average of values is
meaningless.
* metrics/influxdb: use smaller dependency and reuse code between v1 and v2 reporters (#26963)
This change switches to use the smaller influxdata/influxdb1-client package instead of depending on the whole infuxdb package. The new smaller client is very similar to the influxdb-v2 client, which made it possible to refactor the two reporters to reuse code a lot more.
* eth/gasprice: change feehistory input type from int to uint64 (#26922)
Change input param type from int to uint64
* go.mod: update golang.org/x/tools (#26960)
* rlp/rlpgen: print want/expect output string if mismatch (#26932)
Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
* ethclient: ensure returned subscription is nil on error (#26976)
* core/state, trie: remove Try prefix in Trie accessors (#26975)
This change renames StateTrie methods to remove the Try* prefix.
We added the Trie methods with prefix 'Try' a long time ago, working
around the problem that most existing methods of Trie did not return the
database error. This weird naming convention has persisted until now.
Co-authored-by: Gary Rong <garyrong0905@gmail.com>
* metrics/librato: ensure resp.body closed (#26969)
This change ensures that we call Close on a http response body, in various places in the source code (mostly tests)
* core/vm: use atomic.Bool (#26951)
Make use of new atomic types
---------
Co-authored-by: Felix Lange <fjl@twurst.com>
Co-authored-by: Martin Holst Swende <martin@swende.se>
* core/bloombits: use atomic type (#26993)
* core/state: use atomic.Bool (#26992)
* graphql: fix data races (#26965)
Fixes multiple data races caused by the fact that resolving fields are done concurrently by the graphql library. It also enforces caching at the stateobject level for account fields.
* eth/tracers/native: prevent panic for LOG edge-cases (#26848)
This PR fixes OOM panic in the callTracer as well as panicing on
opcode validation errors (e.g. stack underflow) in callTracer and
prestateTracer.
Co-authored-by: Martin Holst Swende <martin@swende.se>
* internal/debug: add log.logfmt flag to set logging to use logfmt (#26970)
* docs: update outdated DeriveSha docs comment (#26968)
* remove @gballet as a GraphQL codeowner (#27012)
* core: use atomic type (#27011)
* graphql: revert storage access regression (#27007)
* cmd/geth: Add `--log.format` cli param (#27001)
Removes the new --log.logfmt directive and hides --log.json, replacing both with log.format=(json|logfmt|terminal). The hidden log.json option is still respected if log.format is not specified for backwards compatibility.
Co-authored-by: Martin Holst Swende <martin@swende.se>
* ethdb/pebble: use atomic type (#27014)
* common: fix json marshaller MixedcaseAddress (#26998)
Fix the json marshaller of MixedcaseAddress
* eth/catalyst: improve consensus heartbeat (#26896)
improve the heartbeat function that is no longer suitable in the current situation
Co-authored-by: “openex27” <“openexkevin@gmail.com”>
* miner: use atomic type (#27013)
Use the new typed atomics in the miner package
* accounts/abi/bind: handle UnpackLog with zero topics (#26920)
Adds error handling for the case that UnpackLog or UnpackLogIntoMap is called with a log that has zero topics.
---------
Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
* cmd/evm: use correct parent number for t8n base fee calculation (#27032)
Currently the t8n tool uses the same block number for the current block and its parent while calculating the base fee. This causes incorrect base fee calculation for the london fork block. This commit sets the parent block number to be one less than the current block number
* go.mod : update snappy (#27027)
* common: delete MakeName (#27023)
common,p2p: remove unused function MakeName
* cmd/geth: enable log rotation (#26843)
This change enables log rotation, which can be activated using the flag --log.rotate. Additional parameters that can be given are:
- log.maxsize to set maximum size before files are rotated,
- log.maxbackups to set how many files are retailed,
- log.maxage to configure max age of rotated files,
- log.compress whether to compress rotated files
The way to configure location of the logfile(s) is left unchanged, via the `log.logfile` parameter.
---------
Co-authored-by: Martin Holst Swende <martin@swende.se>
* cmd, miner, signer: avoid panic if keystore is not available (#27039)
* cmd, miner, singer: avoid panic if keystore is not available
* cmd/geth: print warning instead of panic
* test/fuzzers: fuzz rlp handling of big.Int and uint256.Int (#26917)
test/fuzzers: fuzz rlp handling of big.Lnt and uint256.Int
* core/txpool: move some validation to outside of mutex (#27006)
Currently, most of transaction validation while holding the txpool mutex: one exception being an early-on signature check.
This PR changes that, so that we do all non-stateful checks before we entering the mutex area. This means they can be performed in parallel, and to enable that, certain fields have been made atomic bools and uint64.
* eth/downloader: use atomic types (#27030)
* eth/downloader: use atomic type
* Update eth/downloader/downloader_test.go
Co-authored-by: Martin Holst Swende <martin@swende.se>
* Update eth/downloader/downloader_test.go
Co-authored-by: Martin Holst Swende <martin@swende.se>
---------
Co-authored-by: Martin Holst Swende <martin@swende.se>
* core/vm: clarify comment (#27045)
* consensus, core/typer: add 4844 excessDataGas to header, tie it to Cancun (#27046)
* consensus/misc, params: add EIP-4844 blobfee conversions (#27041)
* consensus/misc, params: add EIP-4844 blobfee conversions
* consensus/misc: pull in fakeExponential test cases
* consensus/misc: reuse bigints
* consensus/misc: nit renames, additional larger testcase
---------
Co-authored-by: Roberto Bayardo <bayardo@alum.mit.edu>
Co-authored-by: Martin Holst Swende <martin@swende.se>
* eth/tracers: report correct gasLimit in call tracers (#27029)
This includes a semantic change to the `callTracer` as well as `flatCallTracer`.
The value of field `gas` in the **first** call frame will change as follows:
- It previously contained gas available after initial deductions (i.e. tx costs)
- It will now contain the full tx gasLimit value
Signed-off-by: jsvisa <delweng@gmail.com>
* all: remove debug-field from vm config (#27048)
This PR removes the Debug field from vmconfig, making it so that if a tracer is set, debug=true is implied.
---------
Co-authored-by: 0xTylerHolmes <tyler@ethereum.org>
Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com>
* metrics: make gauge_float64 and counter_float64 lock free (#27025)
Makes the float-gauges lock-free
name old time/op new time/op delta
CounterFloat64Parallel-8 1.45µs ±10% 0.85µs ± 6% -41.65% (p=0.008 n=5+5)
---------
Co-authored-by: Exca-DK <dev@DESKTOP-RI45P4J.localdomain>
Co-authored-by: Martin Holst Swende <martin@swende.se>
* eth/tracers: use atomic type (#27031)
Use the new atomic types in package eth/tracers
---------
Co-authored-by: Martin Holst Swende <martin@swende.se>
Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
* build: upgrade -dlgo version to Go 1.20.3
* core/txpool: disallow future churn by remote txs (#26907)
Prior to this change, it was possible that transactions are erroneously deemed as 'future' although they are in fact 'pending', causing them to be dropped due to 'future' not being allowed to replace 'pending'.
This change fixes that, by doing a more in-depth inspection of the queue.
* core, miner: drop transactions from the same sender when error occurs (#27038)
This PR unifies the error handling in miner.
Whenever an error occur while applying a transaction, the transaction should be regarded as invalid and all following transactions from the same sender not executable because of the nonce restriction. The only exception is the `nonceTooLow` error which is handled separately.
* params: new sepolia bootnodes (#27099)
New sepolia bootnodes managed by EF devops
* cmd/devp2p: fix erroneous log output in crawler (#27089)
cmd/devp2p: fix log of ignored recent nodes counter
* signer/core: rename testdata files (#27063)
Sets a meaningful name on test-files
* core: fix comment to reflect function name (#27070)
* params: remove `EIP150Hash` from chainconfig (#27087)
The EIP150Hash was an idea where, after the fork, we hardcoded the forked hash as an extra defensive mechanism. It wasn't really used, since forks weren't contentious and for all the various testnets and private networks it's been a hassle to have around.
This change removes that config field.
---------
Signed-off-by: jsvisa <delweng@gmail.com>
* p2p: access embedded fields of Server directly (#27078)
* consensus/ethash: use atomic type (#27068)
* cmd/devp2p: make crawler-route53-updater less verbose (#27116)
Follow-up to #26697, makes the crawler less verbose on route53-based scenarios.
It also changes the loglevel from debug to info on Updates, which are typically the root, and can be interesting to see.
* cmd/geth: rename --vmodule to --log.vmodule (#27071)
renames `--vmodule` to `--log.vmodule`, and prints a warning if the old form is used.
* core/vm: order opcodes properly (#27113)
* metrics: use atomic type (#27121)
* all: refactor trie API (#26995)
In this PR, all TryXXX(e.g. TryGet) APIs of trie are renamed to XXX(e.g. Get) with an error returned.
The original XXX(e.g. Get) APIs are renamed to MustXXX(e.g. MustGet) and does not return any error -- they print a log output. A future PR will change the behaviour to panic on errorrs.
* params: go-ethereum v1.11.6 stable
* dev: chg: regression changes for bor after merge
* dev: chg: more regression changes for bor after merge
* Use `big.Int#Set` instead of `big.Int#SetBytes` when possible (#896)
There is no reason to make the bytes transformation and back to big int to assign a big int to another one.
The `Set` method should be used instead.
* dev: chg: txpool_test regression changes after merge
* dev: chg: gomock re-generate mocks for backend interface
* dev: chg: regression changes after develop is merged into upstream-merge
* dev: chg: further fixes merging develop into upstream-merge
* dev: chg: apply changes to NewParallelBlockChain
* dev: chg: solve some TODOs
* dev: fix: CreateConsensusEngine for new ethereum objects
* dev: fix: NewParallelBlockChain using Genesis
* dev: fix: build ci.go
* dev: fix: thelper and tparallel lint
* dev: fix: http related and nilnil lint errors
* dev: fix: ineffassign lint errors
* dev: chg: comment position fix
* dev: fix: govet lint errors
* dev: fix: error related lint issues
* dev: fix: bodyclose lint issues
* dev: fix: some wsl lint issues
* dev: fix: more wsl lint issues
* dev: fix: errorcheck lint issues
* dev: fix: solve more lint issues
* dev: fix: more wsl lint issues
* dev: fix: more errcheck lint issues
* dev: fix: most of wsl lint issues
* dev: fix: all remaining lint issues
* fixed MVHashMap being enabled even when paralellUniverse is set to 0 (#900)
* dev: fix: t.Parallel called multiple times
* dev: fix: tests failing due to t.Parallel
* fix : runtime testcases
* fix : testcase : config, addTxWithChain, burnAmount
* fix : ethhash bor burn contract
* fix : genspec config
* dev: chg: pos-1465: remove snyk and sonarqube (#908)
* fix : freezer, TestStateProcessorErrors
* core,eth,miner: fix initial test cases (#922)
* fix : TestTransactionIndices, testBeaconSync
* fix : TestBeaconSync66
* core,eth: fix TestDeduplication, TestSyncAccountPerformance, TestTraceTransaction
* fix : TestTxIndexer
* rm : multiple coinbase balance
* fix : testCommitInterruptExperimentBor
* adding balance send to burntcontract back
* Fix header encoding test
* Fix worker tracing `nil` pointer exception (#899)
The `baseFee` can be `nil` in certain situations, the tracing must not use `baseFee` unless it was checked otherwise if such case happen, Go is going to panic.
* core,eth/tracers: fix TestPrestateWithDiffModeTracer
* fixed go files
* consensus/bor,eth/filters,miner,params,tests: fix mocks
* fix : TestGraphQLConcurrentResolvers
* fix : TestBuildPayload
* common,core,miner: fix goleaks,duplicate init and inconsistent mutex (un)locks
* fix : lint
* fix : lint
* Move NumSpeculativeProcs from module variable to function parameter (#931)
This will prevent data races when more than one parallel execution are running at the same time.
* fix : test-integration
* fix : test-integration
* Calculate tx dependency only when mining is enabled (#935)
* core: restore AddFeeTransferLog post miner tipping
* fix : TestGraphQLConcurrentResolvers
* mardizzone/POS-1605: go and deps upgrade (#929)
* dev: chg: pos-1605: fix govulns by bumping golang version and replacing mongodb version
* dev: chg: pos-1605: update some dependencies to solve dependabot vulns
* dev: chg: update linter for compatibility with upgraded go version
* dev: chg: update go version in golangci lintere
* dev: chg: update go version in ci workflow, docker and travis
* dev: chg: change govulncheck version to a stable fixed one
* dev: chg: fix govulncheck version
* dev: chg: remove vulncheck version
* dev: chg: adapt tests based on go-ethereum for go version upgrade
* dev: chg: use explicit go version for templum action
* dev: chg: fix lint
* dev: chg: fix lint
* dev: chg: 1.20.x explicitly in packager
* dev: chg: ignore some additional leak to be fixed
* dev: chg: ignore some additional leak to be fixed
* dev: chg: fix lint
* rpc: add execution pool metrics (#919)
* rpc: add execution pool metrics
* rpc: stop execution pool and report metrics using ticker
* fix lint
* update go.mod, update metric report interval
* handle empty workerpool case to fix tests
* fix lint
* refactor ep metrics collection based on each service
* remove log
* rpc: convert processed metric to histogram
* lint
* Moved TxDependency Metadata to ExtraData in Block Header (#930)
* moved TxDependency Metadata to ExtraData in Block Header
* updated unit tests
* lints
* small bug fix
* small improvement
* minor bug fix
* addressed comments
* bug fix, only using the BlockExtraData structure after the Parallel Universe HF
* addressed comments
* fixed an error
* bug fix
* encoding nil ValidatorBytes and TxDependency in prepare if the current block is not the last block of the sprint
* bug fix
* fix : deadlocks
* rm: t.parallel from testQueueTimeLimiting tests
* Merge branch 'develop' into mardizzone/upstream-merge
* fix : lint
* fix : test-integration
* fix : TxDependency
* Update discord link in README.md (#938)
* add rpc.enabledeprecatedpersonal flag
* Upstream merge from go-ethereum/v1.11.6 (#901)
* ethdb/pebble: fix nil callbacks (#26650)
* eth/downloader: fix timeout resurrection panic (#26652)
* common/prque, eth/downloader: fix timeout resurrection panic
* common/prque: revert -1 hack for les, temporaryly!
* core/state, trie: remove unused error-return from trie Commit operation (#26641)
* go.mod: update pebble to latest master (#26654)
* core/vm: set tracer-observable `value` of a delegatecall to match parent `value` (#26632)
This is a breaking change in the tracing hooks API as well as semantics of the callTracer:
- CaptureEnter hook provided a nil value argument in case of DELEGATECALL. However to stay consistent with how delegate calls behave in EVM this hook is changed to pass in the value of the parent call.
- callTracer will return parent call's value for DELEGATECALL frames.
---------
Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
* ethdb: add benchmark test suite (#26659)
* params: schedule shanghai fork on sepolia (#26662)
* params: schedule shanghai fork on sepolia
* params: u64 -> newUint64
* eth/filters: avoid block body retrieval when no matching logs (#25199)
Logs stored on disk have minimal information. Contextual information such as block
number, index of log in block, index of transaction in block are filled in upon request.
We can fill in all these fields only having the block header and list of receipts.
But determining the transaction hash of a log requires the block body.
The goal of this PR is postponing this retrieval until we are sure we the transaction hash.
It happens often that the header bloom filter signals there might be matches in a block,
but after actually checking them reveals the logs do not match. We want to avoid fetching
the body in this case.
Note that this changes the semantics of Backend.GetLogs. Downstream callers of
GetLogs now assume log context fields have not been derived, and need to call
DeriveFields on the logs if necessary.
* eth/tracers: more fork overrides in traceBlockToFile (#26655)
This change allows all post-Berlin forks to be specified as overrides for futureForkBlock in the config parameter for traceBlockToFile.
* tests/fuzzers: supply gnark multiexp config, fixes #26669 (#26670)
This change fixes a fuzzer which broke when we updated the gnark dependency earlier.
* cmd/devp2p: reduce output of node crawler (#26674)
Our discovery crawler spits out a huge amount of logs, most of which is pretty non-interesting. This change moves the very verbose output to Debug, and adds a 8-second status log message giving the general idea about what's going on.
* params: update mainnet + rinkeby CHT (#26677)
This change updates the CHT entries for mainnet and rinkeby
* eth/filters: replace atomic pointer with value (#26689)
* eth/filters: replace atomic.Pointer
* fix
* improve
Co-authored-by: Martin Holst Swende <martin@swende.se>
---------
Co-authored-by: Martin Holst Swende <martin@swende.se>
* p2p/dnsdisc: fix tests with Go 1.20 (#26690)
* eth/catalyst: return error if withdrawals are nil post-shanghai (#26691)
Spec: https://github.com/ethereum/execution-apis/blob/main/src/engine/shanghai.md#request
* ethdb/pebble: Fix `MemTableStopWritesThreshold` (#26692)
MemTableStopWritesThreshold was set to the max size of all memtables before blocking writing but should be set to the max number of memtables. This is documented [here](https://github.com/cockroachdb/pebble/blob/master/options.go#L738-L742).
* eth/downloader: handle missing withdrawals if empty list is expected (#26675)
This PR relaxes the block body ingress handling a bit: if block body withdrawals are missing (but expected to be empty), the body withdrawals are set to 'empty list' before being passed to upper layers.
This fixes an issue where a block passed from EthereumJS to geth was deemed invalid.
* params: go-ethereum v1.11.0 stable
* params: begin v1.11.1 release cycle
* travis, build: update Go to 1.20.1 (#26653)
travis, build: update Go to 1.20
* core: check genesis state presence by disk read (#26703)
* core, eth/downloader: make body validation more strict (#26704)
* eth/downloader: fix empty-body case in queue fetchresult (#26707)
* eth/downloader: fix typo (#26716)
* all: remove deprecated uses of math.rand (#26710)
This PR is a (superior) alternative to https://github.com/ethereum/go-ethereum/pull/26708, it handles deprecation, primarily two specific cases.
`rand.Seed` is typically used in two ways
- `rand.Seed(time.Now().UnixNano())` -- we seed it, just to be sure to get some random, and not always get the same thing on every run. This is not needed, with global seeding, so those are just removed.
- `rand.Seed(1)` this is typically done to ensure we have a stable test. If we rely on this, we need to fix up the tests to use a deterministic prng-source. A few occurrences like this has been replaced with a proper custom source.
`rand.Read` has been replaced by `crypto/rand`.`Read` in this PR.
* params: go-ethereum v1.11.1 stable
* params: begin v1.11.2 release cycle
* eth/catalyst: send INVALID instead of INVALID_BLOCK_HASH (#26696)
This change will break one hive test, but pass another and it will be the better way going forward
* ci: disable coverage reporting in appveyor and travis
* eth/catalyst: request too large error (#26722)
The method `GetPayloadBodiesByRangeV1` now returns "-38004: Too large request" error if the requested range is too large, according to spec
Co-authored-by: Martin Holst Swende <martin@swende.se>
* core/trie: remove trie tracer (#26665)
This PR contains a small portion of the full pbss PR, namely
Remove the tracer from trie (and comitter), and instead using an accessList.
Related changes to the Nodeset.
---------
Co-authored-by: Gary Rong <garyrong0905@gmail.com>
* rpc: fix unmarshaling of null result in CallContext (#26723)
The change fixes unmarshaling of JSON null results into json.RawMessage.
---------
Co-authored-by: Jason Yuan <jason.yuan@curvegrid.com>
Co-authored-by: Jason Yuan <jason.yuan869@gmail.com>
* build: ship bootstrapper Go along with builder for PPA (#26731)
* build: fix setting env var, temp early exit
* build: fix gobootstrap path for the PPA
* build: add some PPA debug logs, sigh
* internal/build: revert raising the chunk size for PPA
* build: yet another weird PPA fix
* build: fix (finaly?) the PPA env vars for Go bootstrapping
* build: fix Go 1.19.0 bootstrapper issues on 386 PPA
* build: enable Lunar Lobster PPA builds
* Revert "core/trie: remove trie tracer (#26665)" (#26732)
This reverts commit 7c749c947a9d5181f5f2c1b3fdb5ea6b0e401e8e.
* cmd/geth: clarify dumpconfig options (#26729)
Clarifies the documentation around dumpconfi
Signed-off-by: Sungwoo Kim <git@sung-woo.kim>
* core, eth: merge snap-sync chain download progress logs (#26676)
* core: fix accessor mismatch for genesis state (#26747)
* core/rawdb: expose chain freezer constructor without internals (#26748)
* all: use unified emptyRootHash and emptyCodeHash (#26718)
The EmptyRootHash and EmptyCodeHash are defined everywhere in the codebase, this PR replaces all of them with unified one defined in core/types package, and also defines constants for TxRoot, WithdrawalsRoot and UncleRoot
* eth/filters: fix a breaking change and return rpctransaction (#26757)
* eth/filters: fix a breaking change and return rpctransaction
* eth/filters: fix test cases
---------
Co-authored-by: Catror <me@catror.com>
* common/math: allow HexOrDecimal to accept unquoted decimals too (#26758)
* params: release Geth v1.11.2
* params: begin v.1.11.3 release cycle
* log: improve documentation (#26753)
Add usage examples
* core/rawdb, node: use standalone flock dependency (#26633)
* eth: use the last announced finalized block as the sync ancient limit (#26685)
* cmd/devp2p: faster crawling + less verbose dns updates (#26697)
This improves the speed of DHT crawling by using concurrent requests.
It also removes logging of individual DNS updates.
* eth/tracers: add native flatCallTracer (aka parity style tracer) (#26377)
Adds support for a native call tracer with the Parity format, which outputs call frames
in a flat array. This tracer accepts the following options:
- `convertParityErrors: true` will convert error messages to match those of Parity
- `includePrecompiles: true` will report all calls to precompiles. The default
matches Parity's behavior where CALL and STATICCALLs to precompiles are excluded
Incompatibilities with Parity include:
- Parity removes the result object in case of failure. This behavior is maintained
with the exception of reverts. Revert output usually contains useful information,
i.e. Solidity revert reason.
- The `gasUsed` field accounts for intrinsic gas (e.g. 21000 for simple transfers)
and refunds unlike Parity
- Block rewards are not reported
Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
* core: improve withdrawal index assignment in GenerateChain (#26756)
This fixes an issue where the withdrawal index was not calculated correctly
for multiple withdrawals in a single block.
Co-authored-by: Gary Rong <garyrong0905@gmail.com>
Co-authored-by: Felix Lange <fjl@twurst.com>
* ethdb/pebble: fix range compaction (#26771)
* ethdb/pebble: fix range compaction
* ethdb/pebble: add comment
* ethdb/pebble: fix max memorytable size (#26776)
* ethclient: include withdrawals in ethclient block responses (#26778)
* include withdrawals in ethclient responses
* omit empty withdrawals array in json serialization
* all: change chain head markers from block to header (#26777)
* core/rawdb, ethdb/pebble: disable pebble on openbsd (#26801)
* core: fix a merge fault (#26802)
* README, go.mod, event, internal/version: bump min Go to 1.19 (#26803)
* travi: remove strange leftover Go version
* core, params: schedule Shanghai on goerli (#26795)
* core: params: schedule Shanghai on goerli
* core/forkid: fix comment
* eth: remove admin.peers[i].eth.head and difficulty (#26804)
* core/types: add EffectiveGasPrice in Receipt (#26713)
This change adds a struct field EffectiveGasPrice in types.Receipt. The field is present
in RPC responses, but not in the Go struct, and thus can't easily be accessed via ethclient.
Co-authored-by: PulsarAI <dev@pulsar-systems.fi>
* core, eth/catalyst: fix race conditions in tests (#26790)
Fixes a race in TestNewPayloadOnInvalidTerminalBlock where setting the TTD raced with
the miner. Solution: set the TTD on the blockchain config not the genesis config.
Also fixes a race in CopyHeader which resulted in race reports all over the place.
* metrics: improve accuracy of CPU gauges (#26793)
This PR changes metrics collection to actually measure the time interval between collections, rather
than assume 3 seconds. I did some ad hoc profiling, and on slower hardware (eg, my Raspberry Pi 4)
I routinely saw intervals between 3.3 - 3.5 seconds, with some being as high as 4.5 seconds. This
will generally cause the CPU gauge readings to be too high, and in some cases can cause impossibly
large values for the CPU load metrics (eg. greater than 400 for a 4 core CPU).
---------
Co-authored-by: Felix Lange <fjl@twurst.com>
* ethclient: fix panic when requesting missing blocks (#26817)
This fixes a regression introduced by #26723.
Fixes #26816.
* core, miner: revert block gas counter in case of invalid transaction (#26799)
This change fixes a flaw where, in certain scenarios, the block sealer did not accurately reset the remaining gas after failing to include an invalid transaction. Fixes #26791
* internal/ethapi: add tests for transaction types JSON marshal/unmarshal (#26667)
Checks that Transaction.MarshalJSON and newRPCTransaction JSON output can be parsed by Transaction.UnmarshalJSON
---------
Co-authored-by: Martin Holst Swende <martin@swende.se>
* cmd/evm: correct `alloc` for `t8n` testdata (#26822)
Fixes a minor error in the testdata
* eth/tracers/native: set created address to nil in case of failure (#26779)
Fixes #26073
* accounts/usbwallet: mitigate ledger app chunking issue (#26773)
This PR mitigates an issue with Ledger's on-device RLP deserialization, see
https://github.com/LedgerHQ/app-ethereum/issues/409
Ledger's RLP deserialization code does not validate the length of the RLP list received,
and it may prematurely enter the signing flow when a APDU chunk boundary falls immediately
before the EIP-155 chain_id when deserializing a transaction. Since the chain_id is
uninitialized, it is 0 during this signing flow. This may cause the user to accidentally
sign the transaction with chain_id = 0. That signature would be returned from the device 1
packet earlier than expected by the communication loop. The device blocks the
second-to-last packet waiting for the signer flow, and then errors on the successive
packet (which contains the chain_id, zeroed r, and zeroed s)
Since the signature's early arrival causes successive errors during the communication
process, geth does not parse the improper signature produced by the device, and therefore
no improperly-signed transaction can be created. User funds are not at risk.
We mitigate by selecting the highest chunk size that leaves at least 4 bytes in the
final chunk.
* beacon/engine: don't omit empty withdrawals in ExecutionPayloadBodies (#26698)
This ensures the "withdrawals" field will always be present in responses
to getPayloadBodiesByRangeV1 and getPayloadBodiesByHashV1.
---------
Co-authored-by: Felix Lange <fjl@twurst.com>
* build: update to go 1.20.2 (#26824)
* params: go-ethereum v1.11.3 stable
* params: begin v1.11.4 release cycle
* core/rawdb: find smallest block stored in key-value store when chain gapped (#26719)
This change prints out more information about the problem, in the case where geth detects a gap between leveldb and ancients, so we can determine more exactly where the gap is (what the first missing is). Also prints out more metadata.
---------
Co-authored-by: Martin Holst Swende <martin@swende.se>
* signer/core: accept all solidity primitive types for EIP-712 signing (#26770)
Accept all primitive types in Solidity for EIP-712 from intN, uintN, intN[], uintN[] for N as 0 to 256 in multiples of 8
---------
Co-authored-by: Martin Holst Swende <martin@swende.se>
* params: remove EF azure bootnodes (#26828)
* core/vm: use golang native big.Int (#26834)
reverts #26021, to use the upstream bigint instead.
* core/vm: fix typo in comment (#26838)
fixes eip 220 -> 2200
* core/forkid: fix issue in validation test (#26544)
This changes the test to match the comment description. Using timestampedConfig in this test case is incorrect, the comment says 'local is at Gray Glacier' and isn't aware of more forks.
* cmd/evm: update readmes for the tests (#26841)
* core, core/types: plain Message struct (#25977)
Here, the core.Message interface turns into a plain struct and
types.Message gets removed.
This is a breaking change to packages core and core/types. While we do
not promise API stability for package core, we do for core/types. An
exception can be made for types.Message, since it doesn't have any
purpose apart from invoking the state transition in package core.
types.Message was also marked deprecated by the same commit it
got added in, 4dca5d4db7 (November 2016).
The core.Message interface was added in December 2014, in commit
db494170dc, for the purpose of 'testing' state transitions. It's the
same change that made transaction struct fields private. Before that,
the state transition used *types.Transaction directly.
Over time, multiple implementations of the interface accrued across
different packages, since constructing a Message is required whenever
one wants to invoke the state transition. These implementations all
looked very similar, a struct with private fields exposing the fields
as accessor methods.
By changing Message into a struct with public fields we can remove all
these useless interface implementations. It will also hopefully
simplify future changes to the type with less updates to apply across
all of go-ethereum when a field is added to Message.
---------
Co-authored-by: Felix Lange <fjl@twurst.com>
* travis: only build PPAs nightly, not on every push, too heavy (#26846)
* p2p: small comment typo (#26850)
Update server.go
* core: add Timestamp method in BlockGen (#26844)
Since forks are now scheduled by block time, it can be necessary
to check the timestamp of a block while generating transactions.
* core/txpool: implement additional DoS defenses (#26648)
This adds two new rules to the transaction pool:
- A future transaction can not evict a pending transaction.
- A transaction can not overspend available funds of a sender.
---
Co-authored-by: dwn1998 <42262393+dwn1998@users.noreply.github.com>
Co-authored-by: Martin Holst Swende <martin@swende.se>
* params: go-ethereum v1.11.4 stable
* params: begin v1.11.5 release cycle
* tests: define `MuirGlacier` fork (#26856)
add muir glacier to t8n
* code/vm: fix comment typo (#26865)
it should be constantinople rather than contantinople
* core: minor code refactor (#26852)
* core: refactor code
* core: drop it from this anonymous goroutine func
* core/txpool: use priceList.Put instead of heap.Push (#26863)
Minor refactor to use the 'intended' accessor
* eth: return error if 'safe' or 'finalized' tag used pre-merge (#26862)
Co-authored-by: Martin Holst Swende <martin@swende.se>
Co-authored-by: Felix Lange <fjl@twurst.com>
* .travis.yml: reenable PPA build on tag push (#26873)
* core/state, trie: port changes from PBSS (#26763)
* p2p/discover: pass invalid discv5 packets to Unhandled channel (#26699)
This makes it possible to run another protocol alongside discv5, by reading
unhandled packets from the channel.
* all: update links in documentation (#26882)
Co-authored-by: Stephen Flynn <stephen.flynn@gapac.com>
* Increase websocket frame size (from erigon rpc client) (#26883)
This increases the maximum allowed message size to 32MB.
Originally submitted at https://github.com/ledgerwatch/erigon/pull/2739
example block failure: https://etherscan.io/tx/0x1317d973a55cedf9b0f2df6ea48e8077dd176f5444a3423368a46d6e4db89982#internal
* cmd/devp2p, cmd/geth: add version in --help output (#26895)
Not sure why this was removed, it's pretty useful to see the version
also in --help.
* core: show db error-info in case of mismatched hash root (#26870)
When a database failure occurs, bubble it up a into statedb, and report it in suitable places, such as during a 'bad block' report.
* consensus: improve consensus engine definition (#26871)
Makes clear the distinction between Finalize and FinalizedAndAssemble:
- In Finalize function, a series of state operations are applied according to consensus rules. The statedb is mutated and the root hash can be checked and compared afterwards.
This function should be used in block processing(receive afrom network and apply it locally) but not block generation.
- In FinalizeAndAssemble function, after applying state mutations, the block is also to be assembled with the latest
state root computed, updating the header.
This function should be used in block generation only.
* eth/catalyst: increase update consensus timeout (#26840)
Increases the time between consensus updates that we give the CL before we start warning the user.
* internal/ethapi: avoid int overflow in GetTransactionReceipt (#26911)
* trie, accounts/abi: add error-checks (#26914)
* rlp: support for uint256 (#26898)
This adds built-in support in package rlp for encoding, decoding and generating code dealing with uint256.Int.
---------
Co-authored-by: Felix Lange <fjl@twurst.com>
* eth: fix output file permissions in admin_exportChain (#26912)
* api: Use 0700 file permissions for ExportChain
* change perm to 0644
* Update api.go
---------
Co-authored-by: Felix Lange <fjl@twurst.com>
* trie: reduce unit test time (#26918)
* core/txpool: use atomic int added in go1.19 (#26913)
Makes use of atomic.Uint64 instead of atomic by pointer
* params: schedule shanghai fork on mainnet (#26908)
Schedules the shanghai hardfork on timestamp 1681338455 as discussed on ACDE 157: https://github.com/ethereum/execution-specs/pull/727
* core/txpool: allow future local transactions (#26930)
Local transactions should not be subject to the "future shouldn't churn pending txs" rule
* params: go-ethereum v1.11.5 stable
* params: begin v1.11.6 release cycle
* build: allow building nightly archives via cron jobs (#26938)
* log: add special casing of uint256 into the logger (#26936)
* core/rawdb: use atomic int added in go1.19 (#26935)
* core/vm: expose jumptable constructors (#26880)
When interacting with geth as a library to e.g. produce state tests, it is desirable to obtain the consensus-correct jumptable definition for a given fork. This changes adds accessors so the instructionset can be obtained and characteristics about opcodes can be inspected.
* eth/catalyst: fix races (#26950)
* core/rawdb: update freezertable read meter (#26946)
The meter for "for measuring the effective amount of data read" within the freezertable was never updated. This change remedies that.
---------
Signed-off-by: jsvisa <delweng@gmail.com>
* cmd/evm, tests: record preimages if dump is expected (#26955)
With #25287 we made it so that preimages were not recorded by default. This had the side effect that the evm command is no longer able to dump state since it does a preimage lookup to determine the address represented by a key.
This change enables the recording of preimages when the dump command is given.
* core/state: add account address to Trie slot accessors (#26934)
This changes the Trie interface to add the plain account address as a
parameter to all storage-related methods.
After the introduction of the TryAccount* functions, TryGet, TryUpdate and
TryDelete are now only meant to read an account's storage. In their current
form, they assume that an account storage is stored in a separate trie, and
that the hashing of the slot is independent of its account's address.
The proposed structure for a stateless storage breaks these two
assumptions: the hashing of a slot key requires the address and all slots
and accounts are stored in a single trie.
This PR therefore adds an address parameter to the interface. It is ignored
in the MPT version, so this change has no functional impact, however it
will reduce the diff size when merging verkle trees.
* metrics: add cpu counters (#26796)
This PR adds counter metrics for the CPU system and the Geth process.
Currently the only metrics available for these items are gauges. Gauges are
fine when the consumer scrapes metrics data at the same interval as Geth
produces new values (every 3 seconds), but it is likely that most consumers
will not scrape that often. Intervals of 10, 15, or maybe even 30 seconds
are probably more common.
So the problem is, how does the consumer estimate what the CPU was doing in
between scrapes. With a counter, it's easy ... you just subtract two
successive values and divide by the time to get a nice, accurate average.
But with a gauge, you can't do that. A gauge reading is an instantaneous
picture of what was happening at that moment, but it gives you no idea
about what was going on between scrapes. Taking an average of values is
meaningless.
* metrics/influxdb: use smaller dependency and reuse code between v1 and v2 reporters (#26963)
This change switches to use the smaller influxdata/influxdb1-client package instead of depending on the whole infuxdb package. The new smaller client is very similar to the influxdb-v2 client, which made it possible to refactor the two reporters to reuse code a lot more.
* eth/gasprice: change feehistory input type from int to uint64 (#26922)
Change input param type from int to uint64
* go.mod: update golang.org/x/tools (#26960)
* rlp/rlpgen: print want/expect output string if mismatch (#26932)
Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
* ethclient: ensure returned subscription is nil on error (#26976)
* core/state, trie: remove Try prefix in Trie accessors (#26975)
This change renames StateTrie methods to remove the Try* prefix.
We added the Trie methods with prefix 'Try' a long time ago, working
around the problem that most existing methods of Trie did not return the
database error. This weird naming convention has persisted until now.
Co-authored-by: Gary Rong <garyrong0905@gmail.com>
* metrics/librato: ensure resp.body closed (#26969)
This change ensures that we call Close on a http response body, in various places in the source code (mostly tests)
* core/vm: use atomic.Bool (#26951)
Make use of new atomic types
---------
Co-authored-by: Felix Lange <fjl@twurst.com>
Co-authored-by: Martin Holst Swende <martin@swende.se>
* core/bloombits: use atomic type (#26993)
* core/state: use atomic.Bool (#26992)
* graphql: fix data races (#26965)
Fixes multiple data races caused by the fact that resolving fields are done concurrently by the graphql library. It also enforces caching at the stateobject level for account fields.
* eth/tracers/native: prevent panic for LOG edge-cases (#26848)
This PR fixes OOM panic in the callTracer as well as panicing on
opcode validation errors (e.g. stack underflow) in callTracer and
prestateTracer.
Co-authored-by: Martin Holst Swende <martin@swende.se>
* internal/debug: add log.logfmt flag to set logging to use logfmt (#26970)
* docs: update outdated DeriveSha docs comment (#26968)
* remove @gballet as a GraphQL codeowner (#27012)
* core: use atomic type (#27011)
* graphql: revert storage access regression (#27007)
* cmd/geth: Add `--log.format` cli param (#27001)
Removes the new --log.logfmt directive and hides --log.json, replacing both with log.format=(json|logfmt|terminal). The hidden log.json option is still respected if log.format is not specified for backwards compatibility.
Co-authored-by: Martin Holst Swende <martin@swende.se>
* ethdb/pebble: use atomic type (#27014)
* common: fix json marshaller MixedcaseAddress (#26998)
Fix the json marshaller of MixedcaseAddress
* eth/catalyst: improve consensus heartbeat (#26896)
improve the heartbeat function that is no longer suitable in the current situation
Co-authored-by: “openex27” <“openexkevin@gmail.com”>
* miner: use atomic type (#27013)
Use the new typed atomics in the miner package
* accounts/abi/bind: handle UnpackLog with zero topics (#26920)
Adds error handling for the case that UnpackLog or UnpackLogIntoMap is called with a log that has zero topics.
---------
Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
* cmd/evm: use correct parent number for t8n base fee calculation (#27032)
Currently the t8n tool uses the same block number for the current block and its parent while calculating the base fee. This causes incorrect base fee calculation for the london fork block. This commit sets the parent block number to be one less than the current block number
* go.mod : update snappy (#27027)
* common: delete MakeName (#27023)
common,p2p: remove unused function MakeName
* cmd/geth: enable log rotation (#26843)
This change enables log rotation, which can be activated using the flag --log.rotate. Additional parameters that can be given are:
- log.maxsize to set maximum size before files are rotated,
- log.maxbackups to set how many files are retailed,
- log.maxage to configure max age of rotated files,
- log.compress whether to compress rotated files
The way to configure location of the logfile(s) is left unchanged, via the `log.logfile` parameter.
---------
Co-authored-by: Martin Holst Swende <martin@swende.se>
* cmd, miner, signer: avoid panic if keystore is not available (#27039)
* cmd, miner, singer: avoid panic if keystore is not available
* cmd/geth: print warning instead of panic
* test/fuzzers: fuzz rlp handling of big.Int and uint256.Int (#26917)
test/fuzzers: fuzz rlp handling of big.Lnt and uint256.Int
* core/txpool: move some validation to outside of mutex (#27006)
Currently, most of transaction validation while holding the txpool mutex: one exception being an early-on signature check.
This PR changes that, so that we do all non-stateful checks before we entering the mutex area. This means they can be performed in parallel, and to enable that, certain fields have been made atomic bools and uint64.
* eth/downloader: use atomic types (#27030)
* eth/downloader: use atomic type
* Update eth/downloader/downloader_test.go
Co-authored-by: Martin Holst Swende <martin@swende.se>
* Update eth/downloader/downloader_test.go
Co-authored-by: Martin Holst Swende <martin@swende.se>
---------
Co-authored-by: Martin Holst Swende <martin@swende.se>
* core/vm: clarify comment (#27045)
* consensus, core/typer: add 4844 excessDataGas to header, tie it to Cancun (#27046)
* consensus/misc, params: add EIP-4844 blobfee conversions (#27041)
* consensus/misc, params: add EIP-4844 blobfee conversions
* consensus/misc: pull in fakeExponential test cases
* consensus/misc: reuse bigints
* consensus/misc: nit renames, additional larger testcase
---------
Co-authored-by: Roberto Bayardo <bayardo@alum.mit.edu>
Co-authored-by: Martin Holst Swende <martin@swende.se>
* eth/tracers: report correct gasLimit in call tracers (#27029)
This includes a semantic change to the `callTracer` as well as `flatCallTracer`.
The value of field `gas` in the **first** call frame will change as follows:
- It previously contained gas available after initial deductions (i.e. tx costs)
- It will now contain the full tx gasLimit value
Signed-off-by: jsvisa <delweng@gmail.com>
* all: remove debug-field from vm config (#27048)
This PR removes the Debug field from vmconfig, making it so that if a tracer is set, debug=true is implied.
---------
Co-authored-by: 0xTylerHolmes <tyler@ethereum.org>
Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com>
* metrics: make gauge_float64 and counter_float64 lock free (#27025)
Makes the float-gauges lock-free
name old time/op new time/op delta
CounterFloat64Parallel-8 1.45µs ±10% 0.85µs ± 6% -41.65% (p=0.008 n=5+5)
---------
Co-authored-by: Exca-DK <dev@DESKTOP-RI45P4J.localdomain>
Co-authored-by: Martin Holst Swende <martin@swende.se>
* eth/tracers: use atomic type (#27031)
Use the new atomic types in package eth/tracers
---------
Co-authored-by: Martin Holst Swende <martin@swende.se>
Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
* build: upgrade -dlgo version to Go 1.20.3
* core/txpool: disallow future churn by remote txs (#26907)
Prior to this change, it was possible that transactions are erroneously deemed as 'future' although they are in fact 'pending', causing them to be dropped due to 'future' not being allowed to replace 'pending'.
This change fixes that, by doing a more in-depth inspection of the queue.
* core, miner: drop transactions from the same sender when error occurs (#27038)
This PR unifies the error handling in miner.
Whenever an error occur while applying a transaction, the transaction should be regarded as invalid and all following transactions from the same sender not executable because of the nonce restriction. The only exception is the `nonceTooLow` error which is handled separately.
* params: new sepolia bootnodes (#27099)
New sepolia bootnodes managed by EF devops
* cmd/devp2p: fix erroneous log output in crawler (#27089)
cmd/devp2p: fix log of ignored recent nodes counter
* signer/core: rename testdata files (#27063)
Sets a meaningful na…
cp-wjhan
pushed a commit
to cp-yoonjin/go-wemix
that referenced
this pull request
Oct 10, 2023
* core, trie, eth, cmd: rework preimage store * trie: address comment
mmsqe
pushed a commit
to mmsqe/go-ethereum
that referenced
this pull request
Dec 7, 2023
With ethereum#25287 we made it so that preimages were not recorded by default. This had the side effect that the evm command is no longer able to dump state since it does a preimage lookup to determine the address represented by a key. This change enables the recording of preimages when the dump command is given.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the preimage logic to a standalone struct called
preimageStore. It should simplify the code a bit.Also another big change in this PR is: the preimage recording is disabled by default now.