Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo error: keccack256 -> keccak256 #25054

Merged
merged 1 commit into from Jun 10, 2022
Merged

typo error: keccack256 -> keccak256 #25054

merged 1 commit into from Jun 10, 2022

Conversation

LuozhuZhang
Copy link
Contributor

No description provided.

jwasinger
jwasinger requested changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@jwasinger jwasinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also two instances of keccack in internal/ethapi/api.go. maybe wise to correct those in this PR as well.

@LuozhuZhang
Copy link
Contributor Author

LuozhuZhang commented Jun 10, 2022 •
edited

keccack

Hi. Thanks for your attention

Here is the correct usage. The method name is Keccak256, and the annotation is also

And I've marked other typos here and here

I will fix these typo bugs

@LuozhuZhang LuozhuZhang mentioned this pull request Jun 10, 2022
Merged
@LuozhuZhang
Copy link
Contributor Author

LuozhuZhang commented Jun 10, 2022 •
edited

there's also two instances of keccack in internal/ethapi/api.go. maybe wise to correct those in this PR as well.

Fix the bug, submit a new pr, pls review it ~

LuozhuZhang
LuozhuZhang commented Jun 10, 2022
View reviewed changes
Copy link
Contributor Author

@LuozhuZhang LuozhuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer to this pr

s1na
s1na approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s1na s1na merged commit c57e378 into ethereum:gh-pages Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwasinger jwasinger jwasinger requested changes

@s1na s1na s1na approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LuozhuZhang @s1na @jwasinger