deps: update prometheus/prometheus/tsdb #24752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willianpaixao
requested review from
fjl,
karalabe,
holiman and
rjl493456442
as code owners
willianpaixao
force-pushed
the
update-tsdb
branch
from
aa8a898
to
bba4504
Compare
|
The updates in this PR are a lot more than just prometheus. I'll fix it up |
|
Did a rebase (freezer had changed), but couldn't seem to get rid of the other dependency-changes. |
|
@holiman could you please assign a reviewer? |
|
We'll get to this -- it's not a high prio PR, since we only use a very small snippet of code from prometheus/tsdb. |
willianpaixao
force-pushed
the
update-tsdb
branch
2 times, most recently
from
833a942
to
249ef6d
Compare
holiman
changed the title
|
rebased on master |
|
Triage discussion: it really makes no sense to pull in the gigantic prometheus dependenciy for this one feature. We'll leave it be, and instead try to replace it with something standalone/small at some point in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #24751,
github.com/prometheus/tsdbwas moved togithub.com/prometheus/prometheus/tsdbin 2019 and no updates on the original path are made since.This PR simply replaces the path and bumps to the latest stable version.