Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: migrate to urfave/cli/v2 #24751

Merged
merged 16 commits into from Jun 27, 2022
Merged

cmd: migrate to urfave/cli/v2 #24751

merged 16 commits into from Jun 27, 2022

Commits on Jun 25, 2022

  1. cmd/*: port to cli/v2 

    cmd/geth: ignore output in account help test

cmd/geth: fix arg/flag order in TestAccountImport

cmd/geth: fix arg/flag order in les test

cmd/utils: gofmt

internal/flags: gofmt
    @willianpaixao @fjl
    willianpaixao authored and fjl committed Jun 25, 2022
    Copy the full SHA
    cd40e60 View commit details
    Browse the repository at this point in the history

  2. cmd/geth: fix args accesses for cli/v2

    @fjl
    fjl committed Jun 25, 2022
    Copy the full SHA
    5ce5c8b View commit details
    Browse the repository at this point in the history

  3. cmd/utils: put back HelpPrinter

    @fjl
    fjl committed Jun 25, 2022
    Copy the full SHA
    a4fa5d4 View commit details
    Browse the repository at this point in the history

  4. internal/flags: remove useless cli.App metadata

    @fjl
    fjl committed Jun 25, 2022
    Copy the full SHA
    657cfdd View commit details
    Browse the repository at this point in the history

  5. cmd: use cli/v2 flag categories 

    In the new library version, flags have a Category field. Using this
feature, we can remove our custom usage templates and flag
categorization logic.

To make the usage output look reasonable and aligned, we now override
cli.FlagStringer instead of creating a custom template. Since geth flags
have a lot of description text, I've changed the output to be more
spacious. Flag descriptions are now word-wrapped and are printed on a
separate line below the flag name.
    @fjl
    fjl committed Jun 25, 2022
    Copy the full SHA
    fd3aa2e View commit details
    Browse the repository at this point in the history

  6. cmd/geth: remove command categories 

    They were added a long time ago and not shown in the custom usage
template we had. Removing them now because the usage output looks very
unaligned with the categories printed.
    @fjl
    fjl committed Jun 25, 2022
    Copy the full SHA
    cd91b89 View commit details
    Browse the repository at this point in the history

  7. cmd/utils: remove FilePath in custom flags

    @fjl
    fjl committed Jun 25, 2022
    Copy the full SHA
    6542a6b View commit details
    Browse the repository at this point in the history

  8. cmd/p2psim: use flags.NewApp

    @fjl
    fjl committed Jun 25, 2022
    Copy the full SHA
    573a874 View commit details
    Browse the repository at this point in the history

  9. cmd/*: use RunAndExitOnError

    @fjl
    fjl committed Jun 25, 2022
    Copy the full SHA
    bbfe416 View commit details
    Browse the repository at this point in the history

  10. cmd/utils: move custom flag types to package internal/flags

    @fjl
    fjl committed Jun 25, 2022
    Copy the full SHA
    1d93f3b View commit details
    Browse the repository at this point in the history

  11. cmd: implement MigrateFlags as App.Before hook 

    This makes it unnecessary to wrap each action function with
utils.MigrateFlags in source code.
    @fjl
    fjl committed Jun 25, 2022
    Copy the full SHA
    1dfc46f View commit details
    Browse the repository at this point in the history

  12. go.sum: go mod tidy

    @fjl
    fjl committed Jun 25, 2022
    Copy the full SHA
    ff67f12 View commit details
    Browse the repository at this point in the history

  13. cmd/geth: shorten version-check command description

    @fjl
    fjl committed Jun 25, 2022
    Copy the full SHA
    6c453a5 View commit details
    Browse the repository at this point in the history

  14. build: remove markdown dependency in release builds

    @fjl
    fjl committed Jun 25, 2022
    Copy the full SHA
    e0481d4 View commit details
    Browse the repository at this point in the history

  15. Revert "cmd/*: use RunAndExitOnError" 

    This reverts commit bbfe416.
    @fjl
    fjl committed Jun 25, 2022
    Copy the full SHA
    7487098 View commit details
    Browse the repository at this point in the history

  16. internal/flags: remove debug output

    @fjl
    fjl committed Jun 25, 2022
    Copy the full SHA
    86f6176 View commit details
    Browse the repository at this point in the history