all: separate catalyst package #24280
Conversation
rjl493456442
requested review from
gballet,
holiman,
karalabe and
zsfelfoldi
as code owners
|
@rjl493456442 I've added a commit on top that adds some doc and moves some methods around. If you agree with the docs, we should also add them to the LES package (didn't do that yet, since I wanted to have someone look over it before doing so) |
MariusVanDerWijden
force-pushed
the
refactor-catalyst
branch
from
c2da34c
to
4dddcc6
Compare
| } | ||
| td := api.eth.BlockChain().GetTd(newHeadBlock.Hash(), newHeadBlock.NumberU64()) | ||
| if td != nil && td.Cmp(api.eth.BlockChain().Config().TerminalTotalDifficulty) < 0 { | ||
| return &InvalidTB | ||
| return &beacon.InvalidTB |
There was a problem hiding this comment.
What if the td is nil while the headBlock is present? In case of some database corruption?
There was a problem hiding this comment.
This should only happen if the database is fried and we have the headBlock in DB, but not the TD for it in the DB.
I'm not sure if we should handle it here or if this should blow up at some other point.
Maybe @karalabe can weigh in here: Should we double check and error or should we ignore and eventually blow up in case of database corruption
There was a problem hiding this comment.
What about returning a &beacon.GenericServerError here?
There was a problem hiding this comment.
Yeah, might be better than silently accepting
|
@MariusVanDerWijden I applied your changes to LES and also moved some common functions into the Also I left another comment, please check it. |
* all: seperate catalyst package * eth/catalyst: moved some methods, added docs * eth/catalyst, les/catalyst: add method docs * core, eth, les, miner: move common function to beacon package * eth/catalyst: goimported * cmd/utils, miner/stress/beacon: naming nitpicks Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Péter Szilágyi <peterke@gmail.com>
* all: seperate catalyst package * eth/catalyst: moved some methods, added docs * eth/catalyst, les/catalyst: add method docs * core, eth, les, miner: move common function to beacon package * eth/catalyst: goimported * cmd/utils, miner/stress/beacon: naming nitpicks Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Péter Szilágyi <peterke@gmail.com>
This PR separate the mega catalyst package into two small one
eth/catalystandles/catalystin sake of simplification.