Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/rawdb: simple legacy receipt converter #24028

Merged
merged 10 commits into from Mar 23, 2022
Merged

core/rawdb: simple legacy receipt converter #24028

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fe98df1
cmd,core: add simple legacy receipt converter
s1na Dec 1, 2021
3d7ec7e
minor fix
s1na Mar 17, 2022
52612e6
sanity check for tail-deletion
s1na Mar 17, 2022
0b14470
add log before moving files around
s1na Mar 17, 2022
e08d82f
speed-up hack for mainnet
s1na Mar 17, 2022
8e4b429
fix mainnet check, use networkid instead
s1na Mar 17, 2022
c503ec0
check mainnet genesis
s1na Mar 18, 2022
94e7e93
review fixes
s1na Mar 23, 2022
561c180
resume previous migration attempt
s1na Mar 23, 2022
8a63c99
core/rawdb: lint fix
holiman Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmd/geth/config.go
View file
Open in desktop
Expand Up @@ -32,6 +32,7 @@ import (
"github.com/ethereum/go-ethereum/accounts/scwallet"
"github.com/ethereum/go-ethereum/accounts/usbwallet"
"github.com/ethereum/go-ethereum/cmd/utils"
"github.com/ethereum/go-ethereum/core/rawdb"
"github.com/ethereum/go-ethereum/eth/ethconfig"
"github.com/ethereum/go-ethereum/internal/ethapi"
"github.com/ethereum/go-ethereum/log"
Expand Down Expand Up @@ -167,7 +168,8 @@ func makeFullNode(ctx *cli.Context) (*node.Node, ethapi.Backend) {
firstIdx := uint64(0)
// Hack to speed up check for mainnet because we know
// the first non-empty block.
if cfg.Eth.NetworkId == 1 {
ghash := rawdb.ReadCanonicalHash(eth.ChainDb(), 0)
if cfg.Eth.NetworkId == 1 && ghash == params.MainnetGenesisHash {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever we check for "Is Mainnet?", we usually only care about the genesis hash, not checking the networkid. I think we can ignore the network id

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any downsides to checking it nevertheless?

firstIdx = 46147
}
isLegacy, _, err := dbHasLegacyReceipts(eth.ChainDb(), firstIdx)
Expand Down