eth/tracers: Add support for REVERT/SELFDESTRUCT in evmdis_tracer #24016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
requested review from
holiman,
karalabe and
rjl493456442
as code owners
|
The modified JS code needs to be also embedded into go. I tried to do this but didn't have write permissions to the PR. You can do it by: go install github.com/kevinburke/go-bindata/go-bindata@latest
go generate ./eth/tracers/js/internal/tracers |
|
Thanks, regenerated! @s1na added you to the repo, it may be handy in the future too. |
holiman
reviewed
Nov 29, 2021
| @@ -71,7 +71,7 @@ | |||
| opinfo["ops"] = []; | |||
| this.stack.push(opinfo); | |||
| break; | |||
| case "RETURN": | |||
| case "RETURN": case "REVERT": | |||
There was a problem hiding this comment.
This tracer is also using SUICIDE, as opposed to SELFDESTRUCT -- I think this tracer is kind of bitrotted. Also, it was written to be used along with disasm (https://github.com/Arachnid/evmdis ) which hasn't been updated since 2018.
There was a problem hiding this comment.
Yeah I was going to submit a PR renaming SUICIDE in multiple places, but decided to put a stop to creating new PRs for now 😅
There was a problem hiding this comment.
Fixed this instance of suicide here.
axic
changed the title
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
…thereum#24016) * eth/tracers: Add support for REVERT in evmdis_tracer * evm/tracers: Fix evmdis_tracer to use SELFDESTRUCT instead of SUICIDE * eth/tracers: Regenerate tracer library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.