core/vm: Rename SHA3 instruction to KECCAK256 #23976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename helper functions.
axic
requested review from
holiman,
karalabe and
rjl493456442
as code owners
holiman
reviewed
Nov 25, 2021
| @@ -254,7 +254,7 @@ var opCodeToString = map[OpCode]string{ | |||
| MULMOD: "MULMOD", | |||
|
|
|||
| // 0x20 range - crypto. | |||
| SHA3: "SHA3", | |||
| KECCAK256: "KECCAK256", | |||
There was a problem hiding this comment.
This will 'break' the API for differential tracing. It's pretty easy to fix in the tracer shims though, so not a blocker for me
There was a problem hiding this comment.
If you have some links, I can try submitting support pre-emptively. Note that evmone already outputs KECCAK256 so the shims should be updated to accept both in any case.
There was a problem hiding this comment.
I think e.g. this just need an alias: https://github.com/holiman/goevmlab/blob/0d79a9a3f8e4f25dcac009f1e4b7f0e1d458c238/ops/operations.go#L304 . It's not a biggie, I can fix whenever I need it next
There was a problem hiding this comment.
Here's my attempt: holiman/goevmlab#46
This is solved: ethereum/yellowpaper#825 😅 |
|
Oh my, we're out of spec!!
|
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
This was proposed in 2016, Solidity uses this since 2017, and evmone and other VMs use the keccak256 name. This brings geth in line with those.
This was referenced Sep 23, 2022
yperbasis
added a commit
to ledgerwatch/erigon
that referenced
this pull request
Oct 28, 2022
Cherry-pick ethereum/go-ethereum#23976 Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
banteg
added a commit
to banteg/storage-layout
that referenced
this pull request
Aug 4, 2023
banteg
added a commit
to banteg/evm-trace
that referenced
this pull request
Aug 4, 2023
the opcode was renamed in geth and erigon, but still called sha3 in reth ethereum/go-ethereum#23976 ledgerwatch/erigon#5890
4 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 23, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 23, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 23, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 26, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 27, 2024
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 27, 2024
This was proposed in 2016, Solidity uses this since 2017, and evmone and other VMs use the keccak256 name. This brings geth in line with those.
19 tasks
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 27, 2024
This was proposed in 2016, Solidity uses this since 2017, and evmone and other VMs use the keccak256 name. This brings geth in line with those.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Mar 1, 2024
This was proposed in 2016, Solidity uses this since 2017, and evmone and other VMs use the keccak256 name. This brings geth in line with those.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Mar 1, 2024
This was proposed in 2016, Solidity uses this since 2017, and evmone and other VMs use the keccak256 name. This brings geth in line with those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename helper functions.
This was proposed in 2016, Solidity uses this since 2017, and evmone and other VMs use the
keccak256name. This brings geth in line with those.The only concern could be if there is some kind of intput/output geth produces where this makes a difference.
There is also a field which is serialised as
sha3Uncles-- not sure what relies on it, but of course haven't touched that here.