core/vm: Simplify Contract.GetByte function #23974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Nov 25, 2021
| } | ||
|
|
||
| return 0 | ||
| return STOP |
There was a problem hiding this comment.
Perhaps a comment could help:
Suggested change
| return STOP | |
| // Reading over code is defined to return the byte 0, which is the STOP instruction | |
| return STOP |
gumb0
requested review from
holiman,
karalabe and
rjl493456442
as code owners
holiman
approved these changes
Nov 25, 2021
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Nov 26, 2021
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
This was referenced Sep 23, 2022
yperbasis
added a commit
to ledgerwatch/erigon
that referenced
this pull request
Dec 19, 2022
Cherry-pick ethereum/go-ethereum#23974 Co-authored-by: Andrei Maiboroda <andrei@ethereum.org>
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 23, 2024
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 23, 2024
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 23, 2024
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 26, 2024
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 27, 2024
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 27, 2024
19 tasks
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Mar 1, 2024
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cleanup to remove unneed extra helper + use
STOPliteral instead of0.