Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/vm: use proper JumpTable type #23967

Merged
merged 1 commit into from Nov 25, 2021
Merged

core/vm: use proper JumpTable type #23967

merged 1 commit into from Nov 25, 2021

Conversation

chfast
Copy link
Contributor

@chfast chfast commented Nov 24, 2021

No description provided.

holiman
holiman approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (aside from the fact that we have the parameter name being exactly identical to the type name -- which does not look good to me. However, I can't blame this PR for that)

@chfast
Copy link
Contributor Author

chfast commented Nov 25, 2021

It looks the jumpTable field can be private.

@chfast
Copy link
Contributor Author

chfast commented Nov 25, 2021

Or we can name the type: OperationTable or operationTable, and the field opTable or OpTable.

@karalabe karalabe added this to the 1.10.14 milestone Nov 25, 2021
@karalabe karalabe merged commit 4ebeca1 into ethereum:master Nov 25, 2021
@chfast chfast deleted the evm_jumptable_type branch November 25, 2021 12:23
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Nov 25, 2021
@karalabe
Merge pull request ethereum#23967 from ipsilon/evm_jumptable_type
5331a23 
core/vm: use proper JumpTable type
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Feb 23, 2024
@chfast @gzliudan
core/vm: use proper JumpTable type (ethereum#23967)
382ef90
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Feb 26, 2024
@chfast @gzliudan
core/vm: use proper JumpTable type (ethereum#23967)
e8995b6
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Feb 27, 2024
@chfast @gzliudan
core/vm: use proper JumpTable type (ethereum#23967)
e03fd22
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Feb 27, 2024
@chfast @gzliudan
core/vm: use proper JumpTable type (ethereum#23967)
166e3f3
@gzliudan gzliudan mentioned this pull request Feb 27, 2024
Merged
19 tasks
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Mar 1, 2024
@chfast @gzliudan
core/vm: use proper JumpTable type (ethereum#23967)
3d3cc6c
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Mar 1, 2024
@chfast @gzliudan
core/vm: use proper JumpTable type (ethereum#23967)
a484ff2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chfast @holiman @karalabe