clique: fix block number unmarshal #23961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
reviewed
Nov 23, 2021
consensus/clique/api.go
Outdated
| @@ -196,7 +196,11 @@ func (sb *blockNumberOrHashOrRLP) UnmarshalJSON(data []byte) error { | |||
| if err := json.Unmarshal(data, &input); err != nil { | |||
| return err | |||
| } | |||
| sb.RLP = hexutil.MustDecode(input) | |||
| unhexed, err := hexutil.Decode(input) | |||
There was a problem hiding this comment.
Please call it blob :) We use it throughout the code when referring to a decoded binary... blob :)
There was a problem hiding this comment.
Fixed. Missed opportunity to call it bob :)
rjl493456442
approved these changes
Nov 24, 2021
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Nov 24, 2021
* clique: fix block number unmarshal * clique: rename
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
* clique: fix block number unmarshal * clique: rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing
clique.getSigner('00ff')(hex string without0x) in the console caused a crash