accounts/abi/bind Handle structs used only as constructor params #23940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arams Fixes issue ethereum#23939 The `structs` map is populated by iterating over all methods except the constructor, which results in a nil-pointer dereference. I've first reproduced the problem with a new test and then implemented the fix.
divergencetech
requested review from
gballet and
MariusVanDerWijden
as code owners
divergencetech
commented
Nov 20, 2021
| } | ||
| // Generate the test file with the injected test code | ||
| code := fmt.Sprintf(` | ||
| t.Run(tt.name, func(t *testing.T) { |
There was a problem hiding this comment.
The diff here suggests more substantial changes than I've actually performed. I've merely run each test as a sub-test for improved reporting as they're easier to read than test %d.
|
Thanks for the quick review. Is it possible to rerun the checks? The failing test looks spurious and unrelated. I've run |
Doing that now |
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
…params (ethereum#23940) The `structs` map is populated by iterating over all methods except the constructor, which results in a nil-pointer dereference. I've first reproduced the problem with a new test and then implemented the fix. Co-authored-by: Arran Schlosberg <me@arranschlosberg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #23939
The
structsmap is populated by iterating over all methods except the constructor,which results in a nil-pointer dereference.
I've first reproduced the problem with a new test and then implemented the fix.