all: mv loggers to eth/tracers #23892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So most of the changes were trivial, only moving stuff around and changing some imports. Only thing was the struct logger's |
s1na
requested review from
holiman,
karalabe and
rjl493456442
as code owners
holiman
reviewed
Nov 23, 2021
eth/tracers/logger/logger_test.go
Outdated
Comment on lines
60
to
66
| contract.Code = []byte{byte(vm.PUSH32)} | ||
| one := uint256.NewInt(1).Bytes32() | ||
| zero := new(uint256.Int).Bytes32() | ||
| contract.Code = append(contract.Code, one[:]...) | ||
| contract.Code = append(contract.Code, byte(vm.PUSH32)) | ||
| contract.Code = append(contract.Code, zero[:]...) | ||
| contract.Code = append(contract.Code, byte(vm.SSTORE)) |
There was a problem hiding this comment.
Suggested change
| contract.Code = []byte{byte(vm.PUSH32)} | |
| one := uint256.NewInt(1).Bytes32() | |
| zero := new(uint256.Int).Bytes32() | |
| contract.Code = append(contract.Code, one[:]...) | |
| contract.Code = append(contract.Code, byte(vm.PUSH32)) | |
| contract.Code = append(contract.Code, zero[:]...) | |
| contract.Code = append(contract.Code, byte(vm.SSTORE)) | |
| contract.Code = []byte{ | |
| byte(vm.PUSH1), 0x1, | |
| byte(vm.PUSH1), 0x0, | |
| byte(vm.SSTORE), | |
| } |
There was a problem hiding this comment.
Could even be further simplified by changing to sstore(1,1):
contract.Code = []byte{
byte(vm.PUSH1), 0x1, byte(vm.DUP1), byte(vm.SSTORE),
}
There was a problem hiding this comment.
Ah right, that's what I had first but it was failing, as I later found out, for another reason. Fixed
karalabe
reviewed
Nov 25, 2021
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Nov 25, 2021
* all: mv loggers to eth/tracers * core/vm: minor * eth/tracers: tmp comment out testStoreCapture * eth/tracers: uncomment and fix logger test * eth/tracers: simplify test * core/vm: re-add license * core/vm: minor * rename LogConfig to Config
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
* all: mv loggers to eth/tracers * core/vm: minor * eth/tracers: tmp comment out testStoreCapture * eth/tracers: uncomment and fix logger test * eth/tracers: simplify test * core/vm: re-add license * core/vm: minor * rename LogConfig to Config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly creating the PR so i can see the failures through CI xD