Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/evm: make t9n intrinsicGas output hex, fixes #23883 #23889

Merged
merged 1 commit into from Nov 19, 2021
Merged

cmd/evm: make t9n intrinsicGas output hex, fixes #23883 #23889

merged 1 commit into from Nov 19, 2021

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Nov 11, 2021

current output

  {
    "error": "gasPrice exceeds 256 bits",
    "address": "0x54b0dfad82e7660aa185dbd371c359757fc3e656",
    "hash": "0x63cc78c654a6cc5f8ab4f17d03caef02d49ef43275282b12d432880f1192b987",
    "intrinsicGas": 21000
  }

new output:

  {
    "error": "gasPrice exceeds 256 bits",
    "address": "0x54b0dfad82e7660aa185dbd371c359757fc3e656",
    "hash": "0x63cc78c654a6cc5f8ab4f17d03caef02d49ef43275282b12d432880f1192b987",
    "intrinsicGas": "0x5208"
  }

@winsvega winsvega mentioned this pull request Nov 14, 2021
Merged
@holiman holiman added this to the 1.10.13 milestone Nov 16, 2021
MariusVanDerWijden
MariusVanDerWijden approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman merged commit e761255 into ethereum:master Nov 19, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Nov 19, 2021
@holiman
cmd/evm: make t9n intrinsicGas output hex, fixes ethereum#23883 (ethe…
aa9fdd1 
…reum#23889)
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
@holiman @zzyalbert
cmd/evm: make t9n intrinsicGas output hex, fixes ethereum#23883 (ethe…
a89f110 
…reum#23889)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe left review comments

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@holiman @karalabe @MariusVanDerWijden @ligi