Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/evm: add b11r tool #23843

Merged
merged 26 commits into from Nov 22, 2021
Merged

cmd/evm: add b11r tool #23843

merged 26 commits into from Nov 22, 2021

Conversation

lightclient
Copy link
Member

@lightclient lightclient commented Nov 1, 2021

Adds b11r tool to evm. This program can build and seal blocks from JSON input.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also - check out the t8n_test, it uses a pretty cool trick (not my invention) to re-execute itself as a command, and thus the test can execute the command itself and verify the expected output

cmd/evm/internal/t8ntool/block.go Outdated Show resolved Hide resolved
@lightclient lightclient force-pushed the add-b11r branch 3 times, most recently from 7625df1 to f5a69f6 Compare November 13, 2021 04:55
@lightclient lightclient marked this pull request as ready for review November 13, 2021 15:52
@lightclient
Copy link
Member Author

I think this is ready to review now. @holiman curious if this is still in line with what we discussed.

Copy link

@09306677806 09306677806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone help me tell me how can I get my Atrium line and my website back?

@lightclient
Copy link
Member Author

lightclient commented Nov 15, 2021

@09306677806 I recommend turning it off and then back on again. Studies have shown it solves 98.7% of technical issues.

@holiman holiman force-pushed the add-b11r branch 2 times, most recently from 385870b to 85f35cc Compare November 16, 2021 09:03
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman
Copy link
Contributor

holiman commented Nov 18, 2021

@lightclient does my changes LGTY? Do you consider this done, or is there anything else to add/change?

@lightclient
Copy link
Member Author

lightclient commented Nov 18, 2021

@holiman yes, your changes look good to me (thank you). I'm currently using b11r to generate tests and it appears to working as expected. Over the next couple weeks, I'll be using it more thoroughly so some issues may be uncovered. Generally, I think LGTM since no one else depends on it and it is in a pretty good place at the moment.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remaining thing I'm not sure about, otherwise LGTM

cmd/evm/internal/t8ntool/block.go Outdated Show resolved Hide resolved
@holiman holiman added this to the 1.10.13 milestone Nov 22, 2021
@holiman holiman merged commit 441c7f2 into ethereum:master Nov 22, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Nov 23, 2021
evm block-builder (a.k.a b11r) is a utility to help assemble blocks, for use during the test-creation process.
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
evm block-builder (a.k.a b11r) is a utility to help assemble blocks, for use during the test-creation process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants