Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: increase C thread stack size on linux #23676

Merged
merged 3 commits into from Oct 11, 2021

Conversation

gballet
Copy link
Member

@gballet gballet commented Oct 1, 2021

A potential solution for #23669. This PR forces a thread stack size of 8MB, which is the case on every major linux distro except Alpine Linux.

@fjl fjl changed the title build: increase thread stack size when running alpine linux build: increase C thread stack size on linux Oct 8, 2021
@holiman
Copy link
Contributor

holiman commented Oct 11, 2021

This fix doesn't seem to work. When I do a docker build ., this is output:

...
# github.com/ethereum/go-ethereum/cmd/geth
/usr/lib/gcc/x86_64-alpine-linux-musl/10.3.1/../../../../x86_64-alpine-linux-musl/bin/ld: warning: -z -stack-size=0x800000 ignored

And later on, the same crash happens

@gballet gballet force-pushed the dockerfile-alpine-increase-stack branch from e3f2480 to 75838c1 Compare October 11, 2021 11:21
@gballet
Copy link
Member Author

gballet commented Oct 11, 2021

right, there was a typo. @holiman try again please.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this seems to solve it on Alpine.

Can't speak for any other side-effects, supposedly this doesn't change the other platforms

@gballet gballet merged commit 8b6e018 into ethereum:master Oct 11, 2021
@gballet gballet added this to the 1.10.10 milestone Oct 11, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Oct 11, 2021
* build: increase thread stack size when running alpine linux

* review feedback: force a stack size of 8M on all linux distribs

* fix missing extldflags
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
* build: increase thread stack size when running alpine linux

* review feedback: force a stack size of 8M on all linux distribs

* fix missing extldflags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants