internal: support optional filter expression for debug.stacks #23605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand what I'm doing wrong. |
|
It seems to split up |
|
@holiman Sorry about that, made the last min modification to not auto-expand into |
|
Would be pretty neat if this was supported too: |
holiman
reviewed
Sep 20, 2021
internal/debug/api.go
Outdated
Comment on lines
210
to
211
| expanded = regexp.MustCompile("[/\\.A-Za-z0-9_-]+").ReplaceAllString(expanded, "`$0` in Value") | ||
| expanded = regexp.MustCompile("!(`[/\\.A-Za-z0-9_-]+`)").ReplaceAllString(expanded, "$1 not") |
There was a problem hiding this comment.
Suggested change
| expanded = regexp.MustCompile("[/\\.A-Za-z0-9_-]+").ReplaceAllString(expanded, "`$0` in Value") | |
| expanded = regexp.MustCompile("!(`[/\\.A-Za-z0-9_-]+`)").ReplaceAllString(expanded, "$1 not") | |
| expanded = regexp.MustCompile("[/\\:.A-Za-z0-9_-]+").ReplaceAllString(expanded, "`$0` in Value") | |
| expanded = regexp.MustCompile("!(`[/\\:.A-Za-z0-9_-]+`)").ReplaceAllString(expanded, "$1 not") |
For
> debug.stacks("console.go:419")
INFO [09-20|13:22:16.459] Expanded filter expression filter=console.go:419 expanded="`console.go:419` in Value"
goroutine 140 [chan receive]:
github.com/ethereum/go-ethereum/console.(*Console).readLines(0xc000596310, 0xc0004566e8, 0xc000dc3ff0, 0xc0000bb7b0)
github.com/ethereum/go-ethereum/console/console.go:419 +0x46
created by github.com/ethereum/go-ethereum/console.(*Console).Interactive
github.com/ethereum/go-ethereum/console/console.go:363 +0x1ef
There was a problem hiding this comment.
Just move the : to the front of the regexp. I think the - must be the last, otherwise it's interpreted as an interval i.e. from _ to :
There was a problem hiding this comment.
Done. THat's actually how I had it in my own code, but when I wrote the comment here I moved it. WCGW right? ;)
holiman
approved these changes
Sep 20, 2021
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
…um#23605) * internal: support optional filter expression for debug.stacks * internal/debug: fix string regexp * internal/debug: support searching for line numbers too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever Geth hangs, we use the
debug.stacksAPI endpoint to try and find what might be off. This is fine-ish, but it generates a huge dump of goroutines and it's quite a pain to find a needle in the haystack and see if there's something wrong or not.The initial idea was to add a filter parameter where we can specify packages to filter for, potentially multiple - comma separated - but even that produces too much noise. Adding both inclusion filters and exclusion filters would be necessary, but that would get both nasty as well as probably still not flexible enough.
The solution is to use a single filter that can contain both inclusion and exclusion clauses, as well as the possibility to combine these arbitrarily. Without hinting further, the only way to solve it is to have the filter be a boolean expression that gets evaluated runtime and returns those goroutines which evaluate to
true.The PR uses HashiCorp's boolean expression parser and evaluator, but to keep the filter complexity down, I've defined a simpler purpose-built syntax that gets transformed under the hood to the one used by
bexpr. Our filter language consists of:/downloader/,handler.go,wait)&&and||(e.g.downloader || snap)!(e.g.snap && !p2p)excludea paranthesis.(downloader || snap) && select)