consensus/clique: prevent 0 len extradata from panicing #23538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was a known bug that we deliberately didn't fix. Perhaps just crashing isn't ideal, but a network with 0 signers isn't meaningful either. Perhaps we should add a genesis validation vs. just silently make a non functional chain. |
MariusVanDerWijden
requested review from
holiman and
rjl493456442
as code owners
|
Moved the check to |
|
Btw, I think with the genesis check, you can still shoot yourself in the foot if the signer outvotes itself. But :D, not sure we want to do all the fool-proofing :) |
holiman
approved these changes
Sep 8, 2021
Co-authored-by: Martin Holst Swende <martin@swende.se>
Co-authored-by: Martin Holst Swende <martin@swende.se>
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
Closes ethereum#23522 Co-authored-by: Martin Holst Swende <martin@swende.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #23522