internal/ethapi/api: return maxFeePerGas for gasPrice for EIP-1559 txs #23345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently geth returns
0
null
(console converts to0
) forgasPrice
for pending transactions:After this change, it will return
maxFeePerGas
as specified by the RPC spec:edit: I realize I included an invalid value
maxTipPerGas
, but it ended up just estimating a priority fee so I don't think it affects the overall issue at all.