cmd/utils: actually show Aliased Flags as deprecated #23317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm working on getting the Aliased RPC flags removed entirely over at my fork of geth, but, until then, this will actually show the RPC commands as deprecated when someone runs ``geth show-deprecated-flags``.
holiman
reviewed
Aug 3, 2021
|
@holiman can you check this PR again, please? |
|
Closing this, this is added in #23213. |
Zachinquarantine
deleted the
Zachinquarantine-show-aliased-flags-as-deprecated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on getting the Aliased RPC flags removed entirely over at #23358, but, until then, this will actually show the RPC commands as deprecated when someone runs
geth show-deprecated-flags.