Rename to Clone()

common/types.go

@@ -339,9 +339,8 @@ func (a Address) Value() (driver.Value, error) {
 	return a[:], nil
 }
 
-// CopyPointer returns a new pointer to a copy of the address or nil
-// if [a] is nil.
-func (a *Address) CopyPointer() *Address {
+// Clone returns a pointer to a copy of [a] (or nil if [a] is nil)
+func (a *Address) Clone() *Address {
 	if a == nil {
 		return nil
 	}

common/types_test.go

@@ -460,7 +460,7 @@ func TestCopyAddress(t *testing.T) {
 		t.Fatalf("Expected original address bytes to be unmodified")
 	}
 	addrPtr := &addr
-	cpy := addrPtr.CopyPointer()
+	cpy := addrPtr.Clone()
 	cpy.SetBytes([]byte("deadbeef"))
 	if !bytes.Equal(addr.Bytes(), addrBytes) {
 		t.Fatal("Expected original address bytes to be unmodified")
@@ -470,7 +470,7 @@ func TestCopyAddress(t *testing.T) {
 	}
 
 	var nilAddr *Address
-	copiedNilAddr := nilAddr.CopyPointer()
+	copiedNilAddr := nilAddr.Clone()
 	if copiedNilAddr != nil {
 		t.Fatalf("Expected copied nil address to be nil, but got %s", copiedNilAddr)
 	}

core/types/access_list_tx.go

@@ -59,7 +59,7 @@ type AccessListTx struct {
 func (tx *AccessListTx) copy() TxData {
 	cpy := &AccessListTx{
 		Nonce: tx.Nonce,
-		To:    tx.To.CopyPointer(),
+		To:    tx.To.Clone(),
 		Data:  common.CopyBytes(tx.Data),
 		Gas:   tx.Gas,
 		// These are copied below.

core/types/dynamic_fee_tx.go

@@ -43,7 +43,7 @@ type DynamicFeeTx struct {
 func (tx *DynamicFeeTx) copy() TxData {
 	cpy := &DynamicFeeTx{
 		Nonce: tx.Nonce,
-		To:    tx.To.CopyPointer(),
+		To:    tx.To.Clone(),
 		Data:  common.CopyBytes(tx.Data),
 		Gas:   tx.Gas,
 		// These are copied below.

core/types/legacy_tx.go

@@ -62,7 +62,7 @@ func NewContractCreation(nonce uint64, amount *big.Int, gasLimit uint64, gasPric
 func (tx *LegacyTx) copy() TxData {
 	cpy := &LegacyTx{
 		Nonce: tx.Nonce,
-		To:    tx.To.CopyPointer(),
+		To:    tx.To.Clone(),
 		Data:  common.CopyBytes(tx.Data),
 		Gas:   tx.Gas,
 		// These are initialized below.