core/vm: unroll loops in analysis bitmap population

Unroll loops in bitvec.setN(): first one can at most run 2 times, second one at most once.
ethereum · Dec 21, 2021 · 4c15734 · 4c15734
1 parent aa68587
commit 4c15734
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/core/vm/analysis.go b/core/vm/analysis.go
@@ -81,13 +81,20 @@ func codeBitmapInternal(code, bits bitvec) bitvec {
 		}
 		numbits := op - PUSH1 + 1
 		if numbits >= 8 {
-			for ; numbits >= 16; numbits -= 16 {
+			if numbits >= 16 {
 				bits.set16(pc)
 				pc += 16
+				numbits -= 16
 			}
-			for ; numbits >= 8; numbits -= 8 {
+			if numbits >= 16 {
+				bits.set16(pc)
+				pc += 16
+				numbits -= 16
+			}
+			if numbits >= 8 {
 				bits.set8(pc)
 				pc += 8
+				numbits -= 8
 			}
 		}
 		switch numbits {