-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"View in English" on Translation banner leads to broken link #12292
Comments
Noting #12293 temporarily removed the "View in English" button, so that will need to be added back by whoever fixes this issue. Not certain, but the @tomasgrusz You're currently assigned to that issue... If you're interested would you mind taking a peak at this as well to see if these two issues share a culprit? Let us know and can assign you here as well, otherwise can let someone else pick this up. |
edit 2: just noticed the button has been removed, that's why I cannot see it. Will take a look |
you can assign me, I'll try and fix it. Should I also re-implement the button? @wackerow |
Thanks @tomasgrusz! Yes please... if you find a fix for this, we then need to reimplement that button (to allow the user to quickly switch to the more up-to-date English version of the same page). See this commit for it's removal |
This issue is stale because it has been open 45 days with no activity. |
Hey @tomasgrusz! Curious if you've had any luck here, or a chance to look into it |
Hey @wackerow, sorry for the radio silence about this PR. Reproducing the issue outside of the production environment was quite difficult, and unfortunately, I was unable to introduce a suitable fix for this. If there's anyone who knows how to fix it, feel free to reassign it, otherwise internal dev may be needed for it. |
Okay, no worries! Thanks for the update! I'll un-assign to open it back up, but just let us know if you wanna jump back in. Will likely take a peak soon myself to see if I can help out here |
Describe the bug
The 'View in English' button, which appears on the translation banner under specific conditions (when the page has been translated but the English version is more recent), is currently malfunctioning.
Instead of directing users to the English version of the page, the button retains the current language in the URL. For example, clicking the button on a Finnish page redirects to a non-existent page (https://ethereum.org/fi/en), rather than the correct English page (https://ethereum.org/en).
This issue is causing many hidden 404 errors across thousands of pages on our website.
To reproduce
Expected behavior
The 'View in English' button should redirect to the English page, stripping the current language path out of the URL
Screenshots
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional context
Will open a PR to temporarily remove this button whilst we work on a fix.
Would you like to work on this issue?
The text was updated successfully, but these errors were encountered: