Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"View in English" on Translation banner leads to broken link #12292

Open
2 tasks
minimalsm opened this issue Feb 26, 2024 · 8 comments
Open
2 tasks

"View in English" on Translation banner leads to broken link #12292

minimalsm opened this issue Feb 26, 2024 · 8 comments
Labels
bug 🐛 Something isn't working dev required This requires developer resources help wanted Extra attention is needed or someone is needed to help medium priority This has a medium priority SEO

Comments

@minimalsm
Copy link
Contributor

Describe the bug

The 'View in English' button, which appears on the translation banner under specific conditions (when the page has been translated but the English version is more recent), is currently malfunctioning.

Instead of directing users to the English version of the page, the button retains the current language in the URL. For example, clicking the button on a Finnish page redirects to a non-existent page (https://ethereum.org/fi/en), rather than the correct English page (https://ethereum.org/en).

This issue is causing many hidden 404 errors across thousands of pages on our website.

Screenshot 2024-02-26 at 09 17 16

To reproduce

  1. Go to (https://ethereum.org/fi/what-is-ethereum/
  2. Inspect page in dev tools and search for /fi/en/
  3. See error

Expected behavior

The 'View in English' button should redirect to the English page, stripping the current language path out of the URL

Screenshots

Screenshot_2024-02-23_at_12 39 03

Screenshot_2024-02-22_at_12 32 39

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

Will open a PR to temporarily remove this button whilst we work on a fix.

Would you like to work on this issue?

  • Yes
  • No
@minimalsm minimalsm added bug 🐛 Something isn't working help wanted Extra attention is needed or someone is needed to help SEO labels Feb 26, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Feb 26, 2024
@wackerow
Copy link
Member

Noting #12293 temporarily removed the "View in English" button, so that will need to be added back by whoever fixes this issue.


Not certain, but the /fi/en comment makes me think this may be the same issue as reported in #12471

@tomasgrusz You're currently assigned to that issue... If you're interested would you mind taking a peak at this as well to see if these two issues share a culprit? Let us know and can assign you here as well, otherwise can let someone else pick this up.

@wackerow wackerow added medium priority This has a medium priority dev required This requires developer resources and removed needs triage 📥 This issue needs triaged before being worked on labels Mar 19, 2024
@tomasgrusz
Copy link
Contributor

tomasgrusz commented Mar 19, 2024

I'm unable to replicate this issue by following the steps above - no links with duplicate localisations.
Is it showing on your end @wackerow ?

edit: also tried with a link checker, no broken links found

edit 2: just noticed the button has been removed, that's why I cannot see it. Will take a look

@tomasgrusz
Copy link
Contributor

you can assign me, I'll try and fix it. Should I also re-implement the button? @wackerow

@wackerow
Copy link
Member

Thanks @tomasgrusz! Yes please... if you find a fix for this, we then need to reimplement that button (to allow the user to quickly switch to the more up-to-date English version of the same page). See this commit for it's removal

Copy link
Contributor

github-actions bot commented May 4, 2024

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 4, 2024
@wackerow wackerow removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 13, 2024
@wackerow
Copy link
Member

Hey @tomasgrusz! Curious if you've had any luck here, or a chance to look into it

@tomasgrusz
Copy link
Contributor

Hey @wackerow, sorry for the radio silence about this PR. Reproducing the issue outside of the production environment was quite difficult, and unfortunately, I was unable to introduce a suitable fix for this. If there's anyone who knows how to fix it, feel free to reassign it, otherwise internal dev may be needed for it.

@wackerow
Copy link
Member

Okay, no worries! Thanks for the update! I'll un-assign to open it back up, but just let us know if you wanna jump back in. Will likely take a peak soon myself to see if I can help out here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working dev required This requires developer resources help wanted Extra attention is needed or someone is needed to help medium priority This has a medium priority SEO
Projects
None yet
Development

No branches or pull requests

3 participants