Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Functionality is not fetching any results on 404 Page #12518

Open
1 of 2 tasks
Codex-Bugmenot opened this issue Mar 20, 2024 · 3 comments
Open
1 of 2 tasks

Search Functionality is not fetching any results on 404 Page #12518

Codex-Bugmenot opened this issue Mar 20, 2024 · 3 comments
Assignees
Labels
bug 🐛 Something isn't working dev required internal 🏠 Internal changes in dependencies/tests or project maintenance medium priority This has a medium priority Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@Codex-Bugmenot
Copy link

Describe the bug

The Search Functionality (ctrl + K) fetches results based on query typed in the search field but in a 404 page the results are shown as "No Results Found" for every query

To reproduce

  1. Go to any 404 page , i used "https://ethereum.org/en/1"
  2. Click on Search Bar or hold (ctrl + K)
  3. Search for any known search term in the website
  4. Observe that is fetches no results no matter the query

Expected behavior

The Search Functionality should Fetch Results in a 404 i.e in case some one really ends up in a 404 page they should be able to find their way back through search

Screenshots

Results
NoResults

Desktop (please complete the following information)

  • Browser : Brave (Chromium Build)

Smartphone (please complete the following information)

  • Browser : Brave (Chromium Build)

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@Codex-Bugmenot Codex-Bugmenot added the bug 🐛 Something isn't working label Mar 20, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Mar 20, 2024
@tomasgrusz
Copy link
Contributor

Would like to add that the language change doesn't work either, which leads me to suspect that the DEFAULT language messes up the logic discussed in this issue, as well as in issues #12471 and #12292.

@wackerow
Copy link
Member

Yeah.. I agree @tomasgrusz... think we're starting to see the edge cases from that default locale decision.

The search component utilizes Algolia, which does include a "facet" option that breaks up the index according to the lang attribute assigned to the html element... in the case of the 404 page, this is being set to default instead of en. We're then querying for a part of our index with lang="default", which doesn't exist.

I'll assign myself for now, but also cc: @pettinarip to keep you in the loop here. I'll take a look at Algolia and see if there is anything we can do on that end to try and use the en index as the default.

@wackerow wackerow self-assigned this Mar 21, 2024
@wackerow wackerow added medium priority This has a medium priority internal 🏠 Internal changes in dependencies/tests or project maintenance dev required and removed needs triage 📥 This issue needs triaged before being worked on labels Mar 21, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working dev required internal 🏠 Internal changes in dependencies/tests or project maintenance medium priority This has a medium priority Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Development

No branches or pull requests

3 participants